Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2358398imm; Mon, 28 May 2018 06:40:40 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoQmUYBVYJwQ/TNND3sKLM8IULGjq5i/zQ0r0PaFaPK0tjIXwyJ5R1h/WF9YfgHljMFd8zl X-Received: by 2002:a17:902:7446:: with SMTP id e6-v6mr12554655plt.382.1527514840906; Mon, 28 May 2018 06:40:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527514840; cv=none; d=google.com; s=arc-20160816; b=GeUaX0OWB0KaqSnEgfuGtXlQCaBCBPZaDoYUB5ArcjJHKyvmIA0r/LUvT4qBp8KEc9 HuV0tmpADdZOkyWZsKGE/W3B517hW4vKHz9nY5t9EJkFdBvfhv48rix1FbWkbs6gTP7G Eqhdaf+KEdiE9VWbzjTpXHZrph2WwDymOQE6Hy8LSi2+w+aE3qNPTcHtgR9PVNky2hV+ vcYjM26lilAoOfG0h8HFR5FfbuUsWv/PasliweyT/B8Dm5cJIWZyfznqJVBU7vLvJ4m9 UoezZMf8E+pt9bHKo1hDwI6XUQYiPCB9PPAYg5OnWbNaDI6YT7IvgRpxoRGMMIjl6SOw adaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=NfarnIb4oWV5LN0tnd6RIiSjD7xhav9MyvZGyVD4Aic=; b=f+zlkhvVN5Q36DCt2ajw7NaGa+n8diTraVtTfrsYTqXjrHs70dJXLOo6e30q8DsKC+ oTyxGD2SLln1dgN6xlLv6UB3wS6G2Hnqt/F/RxCiOP05sxva2PEQmq2d7LU61446wvaE cyh1+873ivee12WuWhxg7dGB27VPFtRtuaq9AQytnAt/YyQhOPOkl4W204HUw+SpvClI +zmBuStzfLb0IZCImTGgdaC9d34n0p7WzsFQ8IStFZ8+26HS9ld05InMa39+RdboKm31 u5yECtGoU1Vp80ClGlDGGpFvtrMItnAbt2HCtmbzS/95nlhF8GfZt4kz+4+pHSf8c0wp Ml/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VTaTzFfq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c2-v6si900441pfb.139.2018.05.28.06.40.25; Mon, 28 May 2018 06:40:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VTaTzFfq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937687AbeE1Kom (ORCPT + 99 others); Mon, 28 May 2018 06:44:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:35322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937393AbeE1Koi (ORCPT ); Mon, 28 May 2018 06:44:38 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5389720660; Mon, 28 May 2018 10:44:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527504277; bh=EgtoaIadxTmfGqs6lzZ5ZqqMNu5tn4NRc6f/nWQJAeM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VTaTzFfq4Z+3l0/YAP/XY9fOwN0EXMSOyZdAtj07gldE30lgamQQNjyDG919o06h2 I32FuzGTVnRRbsaYK27prrXckqDhJsq/f12v1noK6SZBTlEIQn1vF5DPR4u08Ih60Q YH7GFdTB2W+EnmjecBtT2pagUluFMO6YO3fX4Sqs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robin Murphy , Heiko Stuebner , Sasha Levin Subject: [PATCH 4.14 080/496] arm64: dts: rockchip: Fix DWMMC clocks Date: Mon, 28 May 2018 11:57:45 +0200 Message-Id: <20180528100323.146750058@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528100319.498712256@linuxfoundation.org> References: <20180528100319.498712256@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Robin Murphy [ Upstream commit ca9eee95a2decc6f60bed65b5b836a26bff825c1 ] Trying to boot an RK3328 box with an HS200-capable eMMC, I see said eMMC fail to initialise as it can't run its tuning procedure, because the sample clock is missing. Upon closer inspection, whilst the clock is present in the DT, its name is subtly incorrect per the binding, so __of_clk_get_by_name() never finds it. By inspection, the drive clock suffers from a similar problem, so has never worked properly either. Fix up all instances of the incorrect clock names across the 64-bit DTs. Fixes: d717f7352ec6 ("arm64: dts: rockchip: add sdmmc/sdio/emmc nodes for RK3328 SoCs") Fixes: b790c2cab5ca ("arm64: dts: add Rockchip rk3368 core dtsi and board dts for the r88 board") Signed-off-by: Robin Murphy Signed-off-by: Heiko Stuebner Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 6 +++--- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -683,7 +683,7 @@ interrupts = ; clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; - clock-names = "biu", "ciu", "ciu_drv", "ciu_sample"; + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; fifo-depth = <0x100>; status = "disabled"; }; @@ -694,7 +694,7 @@ interrupts = ; clocks = <&cru HCLK_SDIO>, <&cru SCLK_SDIO>, <&cru SCLK_SDIO_DRV>, <&cru SCLK_SDIO_SAMPLE>; - clock-names = "biu", "ciu", "ciu_drv", "ciu_sample"; + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; fifo-depth = <0x100>; status = "disabled"; }; @@ -705,7 +705,7 @@ interrupts = ; clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>, <&cru SCLK_EMMC_DRV>, <&cru SCLK_EMMC_SAMPLE>; - clock-names = "biu", "ciu", "ciu_drv", "ciu_sample"; + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; fifo-depth = <0x100>; status = "disabled"; }; --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi @@ -257,7 +257,7 @@ max-frequency = <150000000>; clocks = <&cru HCLK_SDIO0>, <&cru SCLK_SDIO0>, <&cru SCLK_SDIO0_DRV>, <&cru SCLK_SDIO0_SAMPLE>; - clock-names = "biu", "ciu", "ciu_drv", "ciu_sample"; + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; fifo-depth = <0x100>; interrupts = ; resets = <&cru SRST_SDIO0>;