Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2442552imm; Mon, 28 May 2018 08:10:13 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLeh2L1FaTqmPoPGPmBxjUBGGH3yuSPdyUNYlPxDPW4xrCqyErS243TOGLdqqz80p50eNG+ X-Received: by 2002:a62:119d:: with SMTP id 29-v6mr9473717pfr.102.1527520213452; Mon, 28 May 2018 08:10:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527520213; cv=none; d=google.com; s=arc-20160816; b=UBXP1vLUb+f1ClGLKRUXEw64mt+DuYfTDBdC3+TqoqltpOjiZDelkt6uaHELHNT/2h jgb302/GUii540/nV7JHMoWmMRV3YYU8536p/caqbtG/X9OaTGQkA6+HrCI7TE4ob2JY BB+U6PhkfYnC14hO0xaJA3YM4tARu4jHqpRYcx63LuQy9RiMk/1ln854SHvD91fYhjN+ 6gK4YXt9g1V+Q/ImOICO5Ww0mB0hpKQVsQoD1rIbtSYgAFbaf8OpEWsdH6toV8OYrvA2 uzyKoVvoA1ntwyCi7TuIFhjoIr+LCMI2yIE4aFJR8+3aywmuHCliblAWv3ZhmqP8hmy+ xEgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=W00I9iemXU0ZAqVNNu47KM50jze2v77OEkScEvTbEnc=; b=zYVOXmwY+RP+y0B6/7gpI5MF//uRS+tr0gTUOwDnX7QyctpM93ZkjcHKOdy0Bf9Zgp G8oEiIZ5kuB52pYWh4HtFpQrSjH1YbFPX+vuzZ3lEyQUbIyXuorh0EtYIRw+zQTe8TFW WVSdOF7wuDR5gsZzXYdBBbQ4njL84AgDQBpSZvu5wDzV31O29FmKYHZwgw9/GlgQHNvJ lx0iNgK4uCpSk07SPHa6AqX99w2e9E8w1T3W68smd81fCZPt/H0JZHlalOs957YTcbeT bar4u1HJlbYMZqkW0g7j8Nca2vPJQB0KsPHDrOzRdRFmekv7CcyD7lnWpFqbZdNEWdfk qKBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2fZKOZWA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b7-v6si23448840pge.228.2018.05.28.08.09.58; Mon, 28 May 2018 08:10:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2fZKOZWA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033846AbeE1KYf (ORCPT + 99 others); Mon, 28 May 2018 06:24:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:43810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033613AbeE1KY3 (ORCPT ); Mon, 28 May 2018 06:24:29 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BAD020844; Mon, 28 May 2018 10:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527503068; bh=ZL+Jm5nzvmd11HQhtOYPajR1hjbTFxnv/RZpqAKy65Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2fZKOZWAtzKr0RkJckOXheHP2Aa0B94pHqFnlfVBaduPxv91UwK8xCvmPzqRYfSAs F1cfa9Wo5wtu6+/mk1BWQbyleIi7lnz6yPtNX51qNsun0rWcb7Iwub4jyvAAOpOVDr yFTzm1+VtYeleBBjNrI2rxtEl/5nZptIcmQ1vKBc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Brad Love , Michael Ira Krufky , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 232/268] media: em28xx: USB bulk packet size fix Date: Mon, 28 May 2018 12:03:26 +0200 Message-Id: <20180528100229.629939514@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528100202.045206534@linuxfoundation.org> References: <20180528100202.045206534@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Brad Love [ Upstream commit c7c7e8d7803406daa21e96d00c357de8b77b6764 ] Hauppauge em28xx bulk devices exhibit continuity errors and corrupted packets, when run in VMWare virtual machines. Unknown if other manufacturers bulk models exhibit the same issue. KVM/Qemu is unaffected. According to documentation the maximum packet multiplier for em28xx in bulk transfer mode is 256 * 188 bytes. This changes the size of bulk transfers to maximum supported value and have a bonus beneficial alignment. Before: After: This sets up USB to expect just as many bytes as the em28xx is set to emit. Successful usage under load afterwards natively and in both VMWare and KVM/Qemu virtual machines. Signed-off-by: Brad Love Reviewed-by: Michael Ira Krufky Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/em28xx/em28xx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/usb/em28xx/em28xx.h +++ b/drivers/media/usb/em28xx/em28xx.h @@ -187,7 +187,7 @@ USB 2.0 spec says bulk packet size is always 512 bytes */ #define EM28XX_BULK_PACKET_MULTIPLIER 384 -#define EM28XX_DVB_BULK_PACKET_MULTIPLIER 384 +#define EM28XX_DVB_BULK_PACKET_MULTIPLIER 94 #define EM28XX_INTERLACED_DEFAULT 1