Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2500981imm; Mon, 28 May 2018 09:15:35 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq8b38a3Vqo0QmIvwEHXzJvOBZsd6Jzg20H+6jmVAD+wmsWOlDNRletUCd3U36ygZLhdcTv X-Received: by 2002:a63:9e42:: with SMTP id r2-v6mr11068220pgo.436.1527524135195; Mon, 28 May 2018 09:15:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527524135; cv=none; d=google.com; s=arc-20160816; b=t+ksgRZ9loHFGYivCGSlf+4uucK/F+peM6Ei2Qh1nO9GCnDNSGi4Q0mRe2w26xiDma qeoMCzBHUdrBvBK5lLx2SkvgBvswZqVdMjjwCCq4unBw2PvJ5lbFSvw9GvG52DVMDGEQ XUjy71bOYOuyqn9dCxTm4S//T8fZtcs57iP6XnluNH9nBt8Nw9v1OyW0iii0Hp41ArW2 fHTD/r9i8UAI44JKTQwCK0+cd3N/1PKvkXaYm8hY5gPfCYW/9JI6qbENHa5oP4LNYrk/ Dqrjfq3L2kFCJ45yZguKrqJAvdL4Xzq9MWXha8ZQSjUduVWTMowpWW/2vmu5Akuz9oRc GGIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=4czpe+jF+muIQ3TRgwr86uqybw7OOZ0kf1l1rZ5To60=; b=YtPcg1fzvA3eujnV/5XwsaOvoaPyGm8QfKvFLWh6d9GJVOVnYiigH9vN4QJV1D2k/n mlRwi4yDHrp1BFESK61i4w2+unPwko/LxTGpqx5kdS6lqJWvtwaEYhYD8Q/34QVc2Vm3 1CLtIoUrjBHaNSY3VFbKm30BiHnYozvw//PpIFdPIhBbt9zKc3zqZSS+U4uCdWc3CM4R fk8z4/a8mKwGCLs9Bq6QKHC8b6UZa+YNloqE9vF5CHmSPYi7ll19R0Hvtm0G3jB1MLth namtb7NMN2T4FSpLDgtJzcHtu3ub7wkE6zk08aZ9PDGowEUHARf0ehIdj3+ESAJ1Xe/L Byaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o33-v6si29593220plb.432.2018.05.28.09.15.20; Mon, 28 May 2018 09:15:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939838AbeE1QNx (ORCPT + 99 others); Mon, 28 May 2018 12:13:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:49678 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933474AbeE1QNs (ORCPT ); Mon, 28 May 2018 12:13:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E2C35AE40; Mon, 28 May 2018 16:13:45 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 5F629DA907; Mon, 28 May 2018 12:35:08 +0200 (CEST) Date: Mon, 28 May 2018 12:35:08 +0200 From: David Sterba To: Chengguang Xu Cc: linux-fsdevel@vger.kernel.org, dhowells@redhat.com, jlayton@redhat.com, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH] fs/affs: fix potential memory leak in option parsing Message-ID: <20180528103508.GS6649@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Chengguang Xu , linux-fsdevel@vger.kernel.org, dhowells@redhat.com, jlayton@redhat.com, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk References: <1526963065-21134-1-git-send-email-cgxu519@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526963065-21134-1-git-send-email-cgxu519@gmx.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 22, 2018 at 12:24:25PM +0800, Chengguang Xu wrote: > When specifying option 'prefix' multiple times, > current option parsing will cause memory leak. > Hence, call kfree for previous one in this case. > > Signed-off-by: Chengguang Xu Thanks, the patch and others that may queue up will be in my git tree git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git in a branch with 'affs' somewhere in the name.