Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2501302imm; Mon, 28 May 2018 09:15:56 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpPbuNQ06qDkqMq9BDVTmX1bs+uQtAOS44SD4wDG9Ow776E20sosVFh0xniL63Hiup4lYSe X-Received: by 2002:a17:902:9f84:: with SMTP id g4-v6mr14243368plq.152.1527524156057; Mon, 28 May 2018 09:15:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527524156; cv=none; d=google.com; s=arc-20160816; b=0oUNR9E5cDQLQPiq+E4ZkuLuoL0ZO2hALCara91y1JwD6od4tdx63839xsU7k6GWQo OvlIR4pkNVYsaI+Azk9HBRnAK6+aCPCmenVG1ex7fvbjm5HQlsJtIPmfXInuIPCRArCR Z5E8H2jLt5VgIXbIuw6+mTqMvmminoBvn1PAVWh55AXCCYgOxg/gjZaZyagHx3lFDUhl lUjKUZNviXGHHZGynmxljiQReDGXUtbRQYuWFvtBd05zCj+kjLU9RHmMKCecwji/x1jM xNZ/uHTF7elRKPxk5qSR16Qi9JMLOIRh0VY40boBBKrI1a7Kn+Q0x4RRymZLU96gNt9a j/MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=RM5+k0PTnygWJo6c1WctzkCM0b1tT9wohFpmPTxXAcc=; b=ijoaX0+Y3f3BL/FrZuGEMfYbrUR2Bh9gsQsyQnpgkhoB3Gh3PDwGeM5RBIYu2D4cEr pzhm/zzLFfjxcDeOVWfIRPyGR04ftsQMljs/pl9uO4IX4/zpiWiG1gx7co2YUwPzwx2g JMvR3SPWOnr3dSxFlkIcR0d+2sxZPS8N3SB4t4g2gtne7eDiT3CWjY52zbLdkH2/s3Pg HIbI/TJGOBFT9sFNE0ZQCleOZw4B0ZdmV84tRfxV4xw7wjiBfdzs6MjpEwIW21zT3ZRx bj/rMYGnFxZoQ/+ZRwhflHZpJVJGbh6NqBAmnU0Obgmr0h3sBSoP9hhApJXiQJR/0Eiq fCJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g59-v6si30709040plb.381.2018.05.28.09.15.41; Mon, 28 May 2018 09:15:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939848AbeE1QPN (ORCPT + 99 others); Mon, 28 May 2018 12:15:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:49769 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933488AbeE1QNt (ORCPT ); Mon, 28 May 2018 12:13:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 751D7ADD3; Mon, 28 May 2018 16:13:46 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 769371E0570; Mon, 28 May 2018 14:52:57 +0200 (CEST) Date: Mon, 28 May 2018 14:52:57 +0200 From: Jan Kara To: Amir Goldstein Cc: Greg Kroah-Hartman , linux-kernel , stable , Jan Kara , Sasha Levin Subject: Re: [PATCH 4.16 231/272] fanotify: Avoid lost events due to ENOMEM for unlimited queues Message-ID: <20180528125257.bppijdymfnsr3yqz@quack2.suse.cz> References: <20180528100240.256525891@linuxfoundation.org> <20180528100259.797799079@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 28-05-18 15:39:04, Amir Goldstein wrote: > On Mon, May 28, 2018 at 1:04 PM, Greg Kroah-Hartman > wrote: > > 4.16-stable review patch. If anyone has any objections, please let me know. > > > > I do not have objections for applying this patch to stable, but AFAIK > it is a correctness patch that doesn't fix any bug and it was mainly added > as a prerequisite to memcg accounting of event allocations, which is not > yet merged and not destined for stable. > > Jan? do you agree with my statements above? Yes, you are correct. The problem this patch tries to fix is theoretical in nature at this point. However my feeling is stable tree has got rather benevolent in accepting patches in last months and Greg wishes it stays that way so I'm objecting only to patches I know introduce regressions at this point. Honza -- Jan Kara SUSE Labs, CR