Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2955149imm; Mon, 28 May 2018 20:52:20 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKzgwZBMdYOIjaUUiNoW+KUbT106nwISzs35lhLZFNpYbUGJuzvWWd0axFTKcIQQ+AELLSE X-Received: by 2002:a63:7b1e:: with SMTP id w30-v6mr8875790pgc.402.1527565940347; Mon, 28 May 2018 20:52:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527565940; cv=none; d=google.com; s=arc-20160816; b=EgWx09X+Ya5y0b3CVMCxuxIjBRpUr6zJSJ3H+oxTzR44C9HAvLVbAGJGjlL4iwJ1Lv t5m84rSTxsZJlc9gqiCXmm74AWb5u6F5dO0eCkvEN7g32K8tJrBSf+dua4HMowt+518q SEI1u9xnXPoY8vUl5Smo8KaHjCTW2mhI5ApUXcx6insRmGaqAAUK0a/ZTffLI2lADz9L WL3MPbjuv28cRrrgUE2AxlMv5FvATOmLx+9fkLVnjBkAIL8s3ouQsji7Q8hrwSm8iPq+ 21tsSU5PPDcPz+oXOd0wx68t4h9X8hqqBiikqL1iynVM8Q64a4QPYHQ9qykCSGuyYhnq b0IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=fBcAvpFf4GbFfXxzXu7BzT4AAzyEiuCS6D8g0RqocdA=; b=WXcQMC1zY7ys3hj3qbn/dUNJX6kWUJmMoQaWMRfHJo1adtJh2lFGrlhqsZGPVeKp6j lAIGcFlrykBDPHyroyw/N0U0o0En+n+o6aiA0DzpJRt3E+nWqQJFSbEOnE9GLRsrcDFs +23sN7uxBiRJe66UtaYswmAjuxjgc1E1zJ0h93vX8kr89DLlSBcwQDIQ2WLQqToHtH48 /cqnfBsTghYN0oME8VFP0YeazfPdRON1nZ/adeAVx4AZBs7Z3S15putQ8wWBZS5kdqtg ApI8FuIyRKnsV3hv37Gjh7bbWAwzlGnERFBCknoibPN319PuFMdJGCF9489T4y+I2MtH rJ+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=IQLFHSsO; dkim=pass header.i=@codeaurora.org header.s=default header.b=dk9TbebV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 94-v6si28758667pla.500.2018.05.28.20.51.35; Mon, 28 May 2018 20:52:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=IQLFHSsO; dkim=pass header.i=@codeaurora.org header.s=default header.b=dk9TbebV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934238AbeE1VZq (ORCPT + 99 others); Mon, 28 May 2018 17:25:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39308 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934145AbeE1VZg (ORCPT ); Mon, 28 May 2018 17:25:36 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 99026606CF; Mon, 28 May 2018 21:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527542736; bh=Qvl1LupIehNTv3lYR9HFSPrTUeKBSaIgw5weBlR9y1Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IQLFHSsOq+jmk5tl2oKxGTPKxypK2g3kEwb1nrlq1Sft7W56Phn8VyEoWcAVQtJMq JAP6ZcMXXmEJsiTtWHFn6Qq6aUvAHmEU61bNzskJV0YnEOjtjb/a+IUblARYoZclmb a8TaKsr8BffKR+p4cwQIHoZqTMHafRDFV4rQdJyQ= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [172.17.244.17] (173-11-110-227-SFBA.hfc.comcastbusiness.net [173.11.110.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E337B6044B; Mon, 28 May 2018 21:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527542735; bh=Qvl1LupIehNTv3lYR9HFSPrTUeKBSaIgw5weBlR9y1Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=dk9TbebVOY0aawUL7Pdq9PAfkoLmVVzCuWocm4FuQvw/w8WPYKWqm7P/8ZH5RXea5 iQuMFr9hfZ73eqKrJ4ptCkOpeEFdt0OTV1tC2GWVHyfsYpU5D2b/tt0SJwTCoFcPYf lSBobS0sEMtHGjOStRVAIaWztUoi69dypU0BQL5M= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E337B6044B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown To: Don Brace , Bjorn Helgaas Cc: "linux-pci@vger.kernel.org" , "timur@codeaurora.org" , "ryan@finnie.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "stable@vger.kernel.org" , Bjorn Helgaas , "Rafael J. Wysocki" , Greg Kroah-Hartman , Thomas Gleixner , Kate Stewart , Frederick Lawler , Dongdong Liu , Mika Westerberg , open list , "esc.storagedev" , "linux-scsi@vger.kernel.org" References: <1527043490-17268-1-git-send-email-okaya@codeaurora.org> <20180523213249.GD150632@bhelgaas-glaptop.roam.corp.google.com> <61f70fd6-52fd-da07-ce73-303f95132131@codeaurora.org> <82656e20-e821-1944-3399-1667ceb27719@codeaurora.org> <20180524130727.GA85822@bhelgaas-glaptop.roam.corp.google.com> <36b790d3fb4c43349cfa560283c03ab5@microsemi.com> From: Sinan Kaya Message-ID: <667a240c-9f83-181d-9aa3-f9ee3aa66272@codeaurora.org> Date: Mon, 28 May 2018 14:25:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <36b790d3fb4c43349cfa560283c03ab5@microsemi.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/2018 6:37 AM, Don Brace wrote: >> But we really need guidance from an hpsa expert. I don't know the >> filesystem/SCSI/hpsa details. >> >> Bjorn > It's most likely OCSD traffic that will stop when bus mastering is turned off. > So, I'll run some tests on my end before ACKing your patch. Can you test V3 instead of this? I don't think adding pci_disable_device() to shutdown() is enough to put the HW into safe state. I moved clean up responsibility to remove() instead of shutdown(). -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.