Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2963745imm; Mon, 28 May 2018 21:05:43 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKg7J68nX+4tsVzjBlQzVNa8G7QZcH6okqmjGwvYWkdviLp9ifg53Eapj+FYNMMIl5adD4w X-Received: by 2002:a65:41c6:: with SMTP id b6-v6mr4144849pgq.372.1527566743181; Mon, 28 May 2018 21:05:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527566743; cv=none; d=google.com; s=arc-20160816; b=Ix0D9qwmiYw/4l1kEwmYA+Iw+xAaBJzafDdS8lwJiktQ1BDdGBJ/RrG1ctgPP970Ys qW1w0x5oJUUeLLP5A7urOYw7o0AXmI7xch1LiNmboOtGIXw3Jk/qSrpGShGMagaLMG0z wOksU6ZDiJg1b6IUIwBOTBOfWwmXFW4kJ+RN4Oi6amw62tGWoMeyzp1P8Sh0h9Toj7Io HAlEUJ7aTPhGDS7zlfbyFZUtSCGwcXkmLFdg/mscHmnMN+fx/gEkmignHYgOGGIDL5Ai cZFNTqBsy7bZxCbm4nGj9bnVU91HwAkELa5zHiiL+kA6a6u24eX9uAI8dOg5kKkVmR09 nhsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=LUMsSh5plkFOafhjeN+SZJZf4bTddW4wTBSzN+bCLfQ=; b=01awi6aJLbpW6etA94pw96cWJrrOUliczd0mLVkf0ghBjSsIZHZMG/nK7hnkl8K2r3 ENoXKEuI5KkYKJSjxyS3uRbrPYUlZSSaxjg6wnSmJvRNtvPGHv0pnKRJ4uNblyg0nkf0 y1GTRZsLsrhRXe2Na4DHAMPIch53zXnRxCODEZQ+RQuiac2klsB+utsyZNAX9/Qn3Khj mObTq+2N7LtWyAzsUKykGgRn0ZYfZRMLxbGvtaAvUSJqm4dVAkRXd20v0OFdhtwEBFlv Ue67gX/SpoZEsXIrUQI+FSreIMsHN9F2U5F+8MaVA3rmvUfZ3cNH9e0MUJ86+PvZaMA3 ZXUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e1-v6si11550181pls.579.2018.05.28.21.05.28; Mon, 28 May 2018 21:05:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033813AbeE2DDB (ORCPT + 99 others); Mon, 28 May 2018 23:03:01 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:48982 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033722AbeE2DC7 (ORCPT ); Mon, 28 May 2018 23:02:59 -0400 Received: from localhost (pool-173-77-163-54.nycmny.fios.verizon.net [173.77.163.54]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4631713D12B74; Mon, 28 May 2018 20:02:58 -0700 (PDT) Date: Mon, 28 May 2018 23:02:57 -0400 (EDT) Message-Id: <20180528.230257.843191181090212127.davem@davemloft.net> To: jmaxwell37@gmail.com Cc: dsahern@gmail.com, mschiffer@universe-factory.net, zhangshengju@cmss.chinamobile.com, ktkhai@virtuozzo.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jmaxwell@redhat.com Subject: Re: [PATCH net-next] ifb: fix packets checksum From: David Miller In-Reply-To: <20180524213829.15208-1-jmaxwell37@gmail.com> References: <20180524213829.15208-1-jmaxwell37@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 May 2018 20:02:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jon Maxwell Date: Fri, 25 May 2018 07:38:29 +1000 > Fixup the checksum for CHECKSUM_COMPLETE when pulling skbs on RX path. > Otherwise we get splats when tc mirred is used to redirect packets to ifb. > > Before fix: > > nic: hw csum failure > > Signed-off-by: Jon Maxwell Applied.