Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2963941imm; Mon, 28 May 2018 21:06:02 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKKgvHq66v4Z8aAaYQAEXpkaGFUXRPJm05qEKyw9iQvMXdglPa3I0zIU8DJoefy85+GMY/T X-Received: by 2002:a63:8c10:: with SMTP id m16-v6mr3764123pgd.120.1527566762265; Mon, 28 May 2018 21:06:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527566762; cv=none; d=google.com; s=arc-20160816; b=wtFzFoRg4R8EE63UjWNpZAeioh+qnZDWrGxlaj7cqi2ZcxPG9ckXjpSbCLVZ6Ufiyx l5t4cQgd8xLBlS2NdqqN6nEDtxN5PWWm1Yt3kdn00iTaGVpS30EUOq8T9qlSMlQINzRJ qcry4HJYu9KHoIbyR5b8eOUgXZgGjSy+iSvNS9UDD50K66hDJub/5XUF3/gsjnhd3zpF rOD7yCxK0yZTIl6NT+Ngu3u9krJwHL+Va426y+8C/aEqFPpGETkt3d7uBpY/3+oD0/Fm 6G/KE6KIaFRX7kZuVA05AykWnfRnpIeWPTlCFNhJcPDn7RNNFS5ZxaRoSgsVIwu23hqI B8pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=Fp4jYW2j3TwtAl4Z8q4jRdhNZJEbW2L+q1dzUc3FGm0=; b=oLkKdPNCTsShgXXEZgeDo/mPde/+pVC3XCb4g7dGb2njnLOUak+T1Yfa9gE7EFqESE 82/00/FgeTpyN1C2u8l66umEFQWSCL7e+ipas5W7lqd0IbjXL2TC0damXVbvDxWOi4OL 52B9L/BEelAPS9SpbQw789EsqeAqxZFtFD/pVq3vfZ3V0YeATycCOmcTbD4Mcg8FnZpL i/QtOftNKCdD5quO6Oa6MBXC3NlRdNoAYb6pqZNfYADZTazhM7YHbsXHZ6G5NkkiCnLu caI4oidhcjcIO29VXJD6AxkiJFhgfzwaU9/eYOGD/LdBm49nDQWM7M3GbWrquRbx5R0P IcQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8-v6si13529319plj.40.2018.05.28.21.05.48; Mon, 28 May 2018 21:06:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032671AbeE2Cyx (ORCPT + 99 others); Mon, 28 May 2018 22:54:53 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:48860 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030894AbeE2Cyr (ORCPT ); Mon, 28 May 2018 22:54:47 -0400 Received: from localhost (pool-173-77-163-54.nycmny.fios.verizon.net [173.77.163.54]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 640A814694790; Mon, 28 May 2018 19:54:46 -0700 (PDT) Date: Mon, 28 May 2018 22:54:45 -0400 (EDT) Message-Id: <20180528.225445.996478506804495385.davem@davemloft.net> To: thierry.reding@gmail.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, jonathanh@nvidia.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: Use mutex instead of spinlock From: David Miller In-Reply-To: <20180524140907.24197-1-thierry.reding@gmail.com> References: <20180524140907.24197-1-thierry.reding@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 May 2018 19:54:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding Date: Thu, 24 May 2018 16:09:07 +0200 > From: Thierry Reding > > Some drivers, such as DWC EQOS on Tegra, need to perform operations that > can sleep under this lock (clk_set_rate() in tegra_eqos_fix_speed()) for > proper operation. Since there is no need for this lock to be a spinlock, > convert it to a mutex instead. > > Fixes: e6ea2d16fc61 ("net: stmmac: dwc-qos: Add Tegra186 support") > Reported-by: Jon Hunter > Signed-off-by: Thierry Reding > --- > This applies on top of net-next. Applied to net-next.