Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3020847imm; Mon, 28 May 2018 22:39:49 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrV9kLWWHMD4SPcj4X0n5fwLkcftFg8MDGalDU16LIOT5kTiC/gALAzjaTEnGAAypXSmzkF X-Received: by 2002:a17:902:1029:: with SMTP id b38-v6mr16114600pla.277.1527572389166; Mon, 28 May 2018 22:39:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527572389; cv=none; d=google.com; s=arc-20160816; b=HvDmMvPgVhnA+IoIGD/bnAlOGk6/haZXMYIOwg6J1a4KjpvixLQPRZ2HLMT86ujLHf 53U3rMAmLQSMMXJPu7swW27pa4crYGp48IXmJhTMQRXDyz4+jpr2d/cVQ/BRDrX0vdmX QSThmD6xH1qeZhvLXCCmmgXRZBjsbtWAtFbj48UEwHwjMuVnGMRovDx6rNAX5U5fnfI9 O9vGGVmCmvD/H5QvIsc9axchMP6rVIv+kLHF0FCUzmoaEZ2UsrSVDk1EjUFMc1/cHIxb U6z/D6Y9RkYPbPDgXKH7jXKIfOfYaBC5cwi9VKUdbwKTpj/S/RH83X5Qp97zXdf0ofCS xrqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date:arc-authentication-results; bh=jef86Ddt+6Th2BlDsDGXGoj4cl3nPPNspofTk2BkoLs=; b=qUpS9lPI7KvOpnTdf5F6KvMS9TajfYsmfOhKDHEEza9CG3jnYZSwsG7sa/w7N11kD1 OyO2/241t92SZpBqOiGYqKnnQUVPPee+om1swelx1cJZ3i7bHC+SmanPpdBdSle7mvuh P3IrBz/qTdpTxKiPBYUyYdIZzE6438JO+Wv3wQiVuIiVLlXDQXcfL0M5nSQBLlXuOlc4 ZK5iJr6CsnvNA0GxOTdhR4FoD4gR9b2A2vmk5tJhaa+/OeC0FDKDObOel58UpDIO7EO3 BoWkuAwYlUQ1irBoejmUEwF9WKEFq9aAIhNT7/K4c+rNJKL5VLEj7Nd3dMDR9AkKcoYy BaLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q14-v6si30623509pll.277.2018.05.28.22.39.34; Mon, 28 May 2018 22:39:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754243AbeE2FiT (ORCPT + 99 others); Tue, 29 May 2018 01:38:19 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:60560 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbeE2FiR (ORCPT ); Tue, 29 May 2018 01:38:17 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 377CF252F3; Tue, 29 May 2018 01:38:15 -0400 (EDT) Date: Tue, 29 May 2018 15:38:23 +1000 (AEST) From: Finn Thain To: Michael Schmitz cc: Geert Uytterhoeven , Christoph Hellwig , Guenter Roeck , Joshua Thompson , Greg Ungerer , linux-m68k , Linux Kernel Mailing List Subject: Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet In-Reply-To: Message-ID: References: <1527378785-13326-1-git-send-email-linux@roeck-us.net> <55c1c33b-4a34-bd72-57de-577ce8d95e0b@gmail.com> <2ffd0de6-e8d6-6449-7c05-cbbfd8a99a97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 May 2018, Michael Schmitz wrote: > > > > Since an arch gets to apply limits in the dma ops it implements, why > > would arch code also have to set a limit in the form of default > > platform device masks? Powerpc seems to be the only arch that does > > this. > > One of Christoph's recent patches removed most of arches' dma ops, > replacing them by one generic implementation instead. m68k was one of > the affected arches. I concede his patch series is experimental still > and not in mainline, but may be included at some time. I found some patches here, http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/generic-dma-noncoherent.2 Looks like m68k_dma_alloc() gets renamed arch_dma_alloc() and the generic ops don't use the dma masks. Maybe I'm looking at the wrong patches? --