Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3131991imm; Tue, 29 May 2018 01:23:24 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpvaLHW5fI5j2mcVsF+uPqANcRH38m+qtYjxtVgOJZGSVjOHwYK/Ab8Ve9+CxlIy90kYX3G X-Received: by 2002:a62:f58b:: with SMTP id b11-v6mr16452427pfm.113.1527582204262; Tue, 29 May 2018 01:23:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527582204; cv=none; d=google.com; s=arc-20160816; b=pzYunbBF4l5wAwbv0h+8nf26dQttVgo/4sICqPMrpq88fDjnyoViCwMfot7p5+CnRc M4TchXwcVYCYSR0IocHNDNhD/KLBw57O0nC1p9DQQKakupnsVZByjsBZoGx03+Yc5GIG 6qbcNQqrzsCSeCRRUlXnjzrNhsfuNgs6YJvAeEl1SuVU43UjLs607bmURfb+QQBGUvSu jECIjJL0MPItYn1TWFWTXBw0LochFDTpsCnyKjJ7WAKOHjEzo7vPl9KnaibsgnDgS66Y EVcamAr0+gyalQtkzlSTmTPdkyrtc7M3m8A2MjkyMW6Md7KxAj8VcRD49rTcMGdsEr+T 26nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=7JzVndAm8/GuBvYWBPDgtUgZRMmV5JzQOf/YFD03K/o=; b=Sf1NlQOgIRtBZakDapVKi52hT4z9wyd18krbhEuGSuUifR3GacANY7i07Sma1cD1vh NJzwJK9LU1MNsimh0jw+JpwLhlCOEnKUQ5x7T1XxW0z2qf3jP8iI3rmoWTwIJDMfb9W5 3XMAGlbAgNDCTSV0BgFwFCFJ/Kp0utV2F5AsQ0o0aZbJR3pD3LDqWpSgD6wB9EG3El7f aQ9M0mRRuprZy3GLuctbfSdDIF/D1/u02ZBHPHST2EjfM+4NhnkawGpcDijNsmlfPulS WrM2DblSu+2Z4aaSOY0r+EPo+QP3DQUy7jXjM77Xckrwmf1ZucsMqPcH4C8T6TQ+37Px 1ppg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z8-v6si32037150plk.539.2018.05.29.01.23.09; Tue, 29 May 2018 01:23:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755252AbeE2IV6 (ORCPT + 99 others); Tue, 29 May 2018 04:21:58 -0400 Received: from foss.arm.com ([217.140.101.70]:34926 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755190AbeE2IVz (ORCPT ); Tue, 29 May 2018 04:21:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 012621529; Tue, 29 May 2018 01:21:55 -0700 (PDT) Received: from e108498-lin.cambridge.arm.com (e108498-lin.cambridge.arm.com [10.1.210.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 368133F25D; Tue, 29 May 2018 01:21:53 -0700 (PDT) Date: Tue, 29 May 2018 09:21:51 +0100 From: Quentin Perret To: Peter Zijlstra Cc: Vincent Guittot , mingo@kernel.org, linux-kernel@vger.kernel.org, rjw@rjwysocki.net, juri.lelli@redhat.com, dietmar.eggemann@arm.com, Morten.Rasmussen@arm.com, viresh.kumar@linaro.org, valentin.schneider@arm.com Subject: Re: [PATCH v5 01/10] sched/pelt: Move pelt related code in a dedicated file Message-ID: <20180529082151.GD15173@e108498-lin.cambridge.arm.com> References: <1527253951-22709-1-git-send-email-vincent.guittot@linaro.org> <1527253951-22709-2-git-send-email-vincent.guittot@linaro.org> <20180525142648.GC15173@e108498-lin.cambridge.arm.com> <20180525161423.GP12180@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180525161423.GP12180@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 25 May 2018 at 18:14:23 (+0200), Peter Zijlstra wrote: > On Fri, May 25, 2018 at 03:26:48PM +0100, Quentin Perret wrote: > > (both quite old TBH -- 4.9.4 for arm64, 4.8.4 for x86). > > You really should try with a more recent compiler. Right, so I just gave it a try for x86 with gcc 8.0.1 (which seem to introduce a lot of LTO-related enhancements) and I get the following: Without patch text data bss dec hex filename 17474129 4980348 995532 23450009 165d199 vmlinux With patch text data bss dec hex filename 17474049 4980348 995532 23449929 165d149 vmlinux So it is still true that this patch actually changes the code size, most likely because of new function calls. But maybe we don't care if the impact on performance isn't noticeable ... As Patrick said, a hackbench run should be more interesting here. I'll give a try later today. Thanks, Quentin