Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3181277imm; Tue, 29 May 2018 02:33:32 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpa336tSawraGvkCaQ9e3D3MK2jPNgdHA8v1BxlsmrDLkm7hKB/IPeC3uH6H4IgqsPTMLrq X-Received: by 2002:a17:902:2924:: with SMTP id g33-v6mr17060964plb.26.1527586412665; Tue, 29 May 2018 02:33:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527586412; cv=none; d=google.com; s=arc-20160816; b=PIIKBf856vxm4QgFoT5/1X63FJKg9ODJ3TKpVbbivUaN8ZpoqZLEeeNOar16Akubhn mgXs+YBtsYeunI0E0Y31kqo0MQj8lvpyil6D6eis4fjrdXE+kkYcrqY5hdvhjdYQw+gR XYFrkaGetGMbnUo9AnVGTS5IU2TL4IS04EqeHTS2MripY09kmmuLw7/yAzNN2YZRKwYQ aZfRTxgcoybSs7reMzDYhkSe2WUByTrUJd0dBGljcdkkrNbip+xK69p+vUIpI/C38Kfk 4+heIIKncYIAgDTEqzG6k+Ny5HAYbUT1BtPP32mR7gjuGM/wHJCbmiPwv7tExUo8WA1g Gtbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=xq09byC40XLW554Nz4m45lPQJMi3nYEzNVoZgOWeJk8=; b=Pt1rA/zGsytl1XMltlW6H/zi/lx4Rztl8kUZ1SBHXeBmvjRNEgCrQlUX9QPIgbLkPg frRO9hUr46kTrY2bojZ1T6CtjFxYAsSn3fd1sxECkHIcgAVYIy7a99K0Q3UhaooC7Lcz oF4S4dPWqxRbf6jq5h4RKC7/BFIHgB7kCRhoQHAhmIvOMIg2IYj6+lXeiHDtJOc1XGZd vLvu8BNRakgZZr9oKkoi0kBnyv7bOeKJWzcK3i0c5gxjPc3Xr/Cs78NP++eMEsq45cRN otNo1hIofas6zkzHjxetHCuIOXcZ2rTNw6Wmpb/GC8mgBbVpwLipR8yl8lRO64oKL8wD X8Rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a15-v6si10189442pfh.36.2018.05.29.02.33.18; Tue, 29 May 2018 02:33:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932632AbeE2Jce (ORCPT + 99 others); Tue, 29 May 2018 05:32:34 -0400 Received: from mail.bootlin.com ([62.4.15.54]:49708 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932612AbeE2JcC (ORCPT ); Tue, 29 May 2018 05:32:02 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id BB72C2076B; Tue, 29 May 2018 11:32:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [37.71.171.242]) by mail.bootlin.com (Postfix) with ESMTPSA id 91719203B7; Tue, 29 May 2018 11:32:00 +0200 (CEST) Date: Tue, 29 May 2018 11:32:00 +0200 From: Alexandre Belloni To: Andy Shevchenko Cc: Radu Pirea , Mark Brown , Nicolas Ferre , Lee Jones , Richard Genoud , Rob Herring , Mark Rutland , Greg Kroah-Hartman , linux-spi , linux-arm Mailing List , Linux Kernel Mailing List , devicetree , "open list:SERIAL DRIVERS" Subject: Re: [PATCH v4 3/6] mfd: at91-usart: added mfd driver for usart Message-ID: <20180529093200.GB4793@piout.net> References: <20180525171941.26766-1-radu.pirea@microchip.com> <20180525171941.26766-4-radu.pirea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/2018 11:00:49+0300, Andy Shevchenko wrote: > On Fri, May 25, 2018 at 8:19 PM, Radu Pirea wrote: > > This mfd driver is just a wrapper over atmel_serial driver and > > spi-at91-usart driver. Selection of one of the drivers is based on a > > property from device tree. If the property is not specified, the default > > driver is atmel_serial. > > > + depends on OF > > What makes this driver OF specific? > > > + err = of_property_read_u32(np, "atmel,usart-mode", &opmode); > > Check unified device property API. > We don't care, this makes the driver OF specific and this is the correct thing to do. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com