Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3237070imm; Tue, 29 May 2018 03:45:01 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoFd3nmXxRhLurMOC2qrAzxa7rngSRygikeRGZpT1mG0r0wtKfSuIG+XwJiVhwwVrNJcvOs X-Received: by 2002:a17:902:7442:: with SMTP id e2-v6mr16641777plt.28.1527590701734; Tue, 29 May 2018 03:45:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527590701; cv=none; d=google.com; s=arc-20160816; b=GClsHxI9Ms4rtXsIjJiJXKCVA8DoaZ4TFah0f7FxqkIPDS8LfmNFwMq3TVwYkDYCzS mh/4fPeY8jygeE8INfBfjbTulDsJmNwFvZjY25VUwd9L6i1JTab/z8Tt6AfhjIp746JK mEQuosHKeg5gDFdO/ekxq7JJkkPxtRbEUGqhyDE28i4RAyODQTUDfFcc+Oi9Tq+5LAYl NPVDYy65qZbKTc8maWuKxTtPEAzZGlwN9q75FXZvYjF0vaPWIohK0GQAxJMl2cm+t2QY 3wniT2BemrMbQh3A0g8ZwAoAnc1niOHsAXqtXPRjf3CfdAFZc5x59h4k25BGBJqyfxfb hB4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:arc-authentication-results; bh=E2SWkJvzDcZdUs0wYetUKc2VTh6zFtQMPy0+fy7H/Ng=; b=YW/hWX6Owbx0XlGxkFuAkfxzLfy4vkRRqFOREEUSkxj2MrkN7ZPPNxgCIJA23tegFR 9Y6Q/+Epu+amO3UA2bVd82i70uAZXaRp00avCvJEsiHeHGHpwltjuxlv66no/P+ip8tY g5hk14ws2PY3TQjF+7kQj4A3ppTdXZdyqu+vmdsjwxeqLXpxe/mLp5GXeu6vnXEQJ1f1 4O4szfHAzrfQQQFu9q6IgGfAz/rhlZzhHCdbViWr3V8pzHmy61k1XBUze3umpZ3STu9u wo76VzJH+omqPYDsA7PpsJSM2ovYyXGQE/jGmxclUQe1AWPWbuwtc3XwuW5pwlk1+qZj UdaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d14-v6si5268279pln.206.2018.05.29.03.44.47; Tue, 29 May 2018 03:45:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933540AbeE2KoR (ORCPT + 99 others); Tue, 29 May 2018 06:44:17 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:8159 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933596AbeE2KoN (ORCPT ); Tue, 29 May 2018 06:44:13 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 34D74B195F9EF; Tue, 29 May 2018 18:43:59 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.382.0; Tue, 29 May 2018 18:43:53 +0800 From: YueHaibing To: , CC: , , YueHaibing Subject: [PATCH net-next] net: qcom/emac: fix unused variable Date: Tue, 29 May 2018 18:43:43 +0800 Message-ID: <20180529104343.19448-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_ACPI isn't set, variable qdf2400_ops/qdf2432_ops isn't used. drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:284:25: warning: ‘qdf2400_ops’ defined but not used [-Wunused-variable] static struct sgmii_ops qdf2400_ops = { ^~~~~~~~~~~ drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:276:25: warning: ‘qdf2432_ops’ defined but not used [-Wunused-variable] static struct sgmii_ops qdf2432_ops = { ^~~~~~~~~~~ Move the declaration and functions inside the CONFIG_ACPI ifdef to fix the warning. Signed-off-by: YueHaibing --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c index 562420b..15609cb 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c +++ b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c @@ -108,6 +108,7 @@ static void emac_sgmii_link_init(struct emac_adapter *adpt) writel(val, phy->base + EMAC_SGMII_PHY_AUTONEG_CFG2); } +#ifdef CONFIG_ACPI static int emac_sgmii_irq_clear(struct emac_adapter *adpt, u8 irq_bits) { struct emac_sgmii *phy = &adpt->phy; @@ -291,7 +292,6 @@ static struct sgmii_ops qdf2400_ops = { static int emac_sgmii_acpi_match(struct device *dev, void *data) { -#ifdef CONFIG_ACPI static const struct acpi_device_id match_table[] = { { .id = "QCOM8071", @@ -327,10 +327,16 @@ static int emac_sgmii_acpi_match(struct device *dev, void *data) return 1; } } -#endif return 0; } +#else +static int emac_sgmii_acpi_match(struct device *dev, void *data) +{ + return 0; +} + +#endif static const struct of_device_id emac_sgmii_dt_match[] = { { -- 2.7.0