Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3420572imm; Tue, 29 May 2018 07:01:41 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp7cxxaLw6RLkjqtYNq2ucIIQm+u5qfXg9kFgOfI+u4XYYnfKztJ+Qv/tt+4Bl6ddBSyXSk X-Received: by 2002:a62:4b16:: with SMTP id y22-v6mr17536339pfa.29.1527602501546; Tue, 29 May 2018 07:01:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527602501; cv=none; d=google.com; s=arc-20160816; b=RvnfdBoyk264BBnbEtmUBxRD2fmLFXt8Vb/B44BMmA/22fQX43oxXsiA06B5P4Hbew cWrUQLA6vSftnULf7S3p+IMASYtwwmiZPRKcA0x+KedNCxK85WYG1U4HE6ZFsAtN9gjy 7B2QJ2n1Q0z/PlTtWL41+UHU728KQtr11LOKklYwI54Ug5MsfW61cjyZdykLgK43Ly7G 9dFYBYNy1keTzLGfkWuKKk8nGN3tkw78CnNwGnUYikmZNiAQ5hvFLFMWjUX59OEXNtFI jhOql9fKKapOXK8QtORheWq3+tqEOjdZ4CHfC7PVN7ulaWq6+DSdwB8i0E7u76p44d/4 WE6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=WXjAzHRi7+b7tLX+09UrmQS3OTC7W0/3/ZaAySqz/iA=; b=nVZQPLhw1Gh7U/WM7xQC6tTSfxH4ib+iLhEUEh9IIv0nmN5syk3NIdKe17GCQcZpYQ NHj3P/tPtuqHDMzPd8ZdyjQXr7nTprAJ31MXDaPkyevo8MADjFSolh9pz2YLJthta/fX xsHk+LjD3LXPBVwEqMYt3cZMdSc9MVG2C0Q/twhVF+k/NgWsZYH4iz3T7mGiQs6rfO+M CkmOeO7+6TF8fmtQu07/1JxYlWItmKwjNcHuEgpl1aYCOBLozMU6c/cTfZqi62XCIeSL vo9uizs5nwAtrFukDelp6aJa9p0HaUq0thv9A+u/cF+sxzVqwLojk6uvIU6p4vbUTSGQ Cd6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 73-v6si4750117pld.450.2018.05.29.07.01.27; Tue, 29 May 2018 07:01:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934960AbeE2OA0 (ORCPT + 99 others); Tue, 29 May 2018 10:00:26 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55428 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934802AbeE2OAV (ORCPT ); Tue, 29 May 2018 10:00:21 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A148414075F64; Tue, 29 May 2018 07:00:20 -0700 (PDT) Date: Tue, 29 May 2018 10:00:19 -0400 (EDT) Message-Id: <20180529.100019.342627848221840486.davem@davemloft.net> To: brnkv.i1@gmail.com Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] atm: zatm: fix memcmp casting From: David Miller In-Reply-To: <20180525174952.21965-1-brnkv.i1@gmail.com> References: <20180525174952.21965-1-brnkv.i1@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 May 2018 07:00:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ivan Bornyakov Date: Fri, 25 May 2018 20:49:52 +0300 > memcmp() returns int, but eprom_try_esi() cast it to unsigned char. One > can lose significant bits and get 0 from non-0 value returned by the > memcmp(). > > Signed-off-by: Ivan Bornyakov Applied, thanks.