From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jgarzik@pobox.com>, "David S. Miller" <davem@redhat.com>
Cc: Adrian Bunk <bunk@fs.tum.de>, Andrew Morton <akpm@osdl.org>,
       linux-kernel mailing list <linux-kernel@vger.kernel.org>,
       linux-net@vger.kernel.org
In-Reply-To: <3F5617A9.4040603@pobox.com>
References: <20030902231812.03fae13f.akpm@osdl.org>
	 <20030903161200.GC23729@fs.tum.de>  <3F5617A9.4040603@pobox.com>
Message-Id: <1062607559.1785.50.camel@gaston>
Mime-Version: 1.0
Date: Wed, 03 Sep 2003 18:46:00 +0200
Subject: Re: [PATCH] Re: 2.6.0-test4-mm5
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 913
Lines: 23


> As a tangent, gem_pcs_interrupt appears to call netif_carrier_xxx but 
> not set gem->lstate.  David/Ben, is that a bug?

Looks like it is, David, you are the one who knows the PCS stuff ...

BTW. David: Any reason why you wouldn't let me change all occurences
of spin_{lock,unlock}_irq into the ...{save,restore} versions ?

I don't like force re-enabling interrupts the way we do it now with
spin_unlock_irq() the way we do it now. Among other things, that
breaks SA_INTERRUPT semantics and that breaks some pet project of
mine which is to run the IRQ handler with interrupts off when the
kernel stack is below a given threshold (to limit interrupt depth)

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/