Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3425438imm; Tue, 29 May 2018 07:05:21 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpoKsXL3ePKrPtv5SYVv7WtR75dUFSO86aNyZ5gqHT1HctpLOXSciuFchZhnO3Ehq9BblZS X-Received: by 2002:a65:480a:: with SMTP id h10-v6mr13589394pgs.403.1527602721612; Tue, 29 May 2018 07:05:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527602721; cv=none; d=google.com; s=arc-20160816; b=sz2sDT2TkvItQCAzSgXiD5UVeBDYHla89wl20v4ZgaTFE0+FBSBZrVHLtDU7/1jsN7 SC7a4+zuABjeIGbtc3GmWL1TLPH5xZqthJ2+EmOqQncry/2e9HlejbGFA3aasQr9LVHw xHBdH5OkhxjTrrG/vLz+UI4rpcywRg6pyQiq21QgD4vnVrFZfQF9RAUBmZhf/tgM1k8u rMP42vYrQsRgN5NUxn/vJtZx9vDkW5noazZ1EhwafpgHE9zwOBZG5v5aNoTAnvq8w2Ba 0VZyES1jVTA9yO0nO+YVtZJjfwaxSqUj59OxjCSJZB8Sa3a+/okbz8++8Frfg5ZYWcdK 6+MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=F+jhmuKd2XUjuhEWpb6JwQOMne6NMO+T6Y59URZgDEk=; b=DNNwrx8QStli7yqgXx+TVsZQ8cm1t7tlVMCEqIUX+Tyl4Vfv0HqDmi068z0mvAfuSg 5M5AWu86Nq9Tqh23JxRaiFn7AvgWZjVdehosFz5zsFCg7UyFCsGgqE337Q9ZzP6MA1DH W7TThoD3OiSK2PtffZUDfw263igb8YtpgMOUXV3nDGNlmkCN44SpaMR1LUGpjkrgM3Rb AJ753PWCFPjZi5qW2RPvZjZ5XvT8g1yRL+3NcQXuhdXsXp5v7t4MPlX96fHNL7lylMYx jrZAZtIXngzqGDdnPhDpwr0PdKdlepHVNb3ZDggsS9cNO/bEuaNk7vCVw/ote/ks4Uq0 7G7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a4-v6si32511577plp.219.2018.05.29.07.05.07; Tue, 29 May 2018 07:05:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934945AbeE2OEG (ORCPT + 99 others); Tue, 29 May 2018 10:04:06 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55606 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbeE2OEE (ORCPT ); Tue, 29 May 2018 10:04:04 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4D7CE146B2771; Tue, 29 May 2018 07:04:03 -0700 (PDT) Date: Tue, 29 May 2018 10:04:02 -0400 (EDT) Message-Id: <20180529.100402.330737400285261138.davem@davemloft.net> To: arnd@arndb.de Cc: saeedm@mellanox.com, leon@kernel.org, borisp@mellanox.com, ilant@mellanox.com, ogerlitz@mellanox.com, ilyal@mellanox.com, ferasda@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH, net-next] net/mlx5e: fix TLS dependency From: David Miller In-Reply-To: <20180525213630.2119214-1-arnd@arndb.de> References: <20180525213630.2119214-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 May 2018 07:04:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Fri, 25 May 2018 23:36:06 +0200 > With CONFIG_TLS=m and MLX5_CORE_EN=y, we get a link failure: > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In function `mlx5e_tls_handle_ooo': > tls_rxtx.c:(.text+0x24c): undefined reference to `tls_get_record' > drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In function `mlx5e_tls_handle_tx_skb': > tls_rxtx.c:(.text+0x9a8): undefined reference to `tls_device_sk_destruct' > > This narrows down the dependency to only allow the configurations > that will actually work. The existing dependency on TLS_DEVICE is > not sufficient here since MLX5_EN_TLS is a 'bool' symbol. > > Fixes: c83294b9efa5 ("net/mlx5e: TLS, Add Innova TLS TX support") > Signed-off-by: Arnd Bergmann Applied, thank you.