Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3439521imm; Tue, 29 May 2018 07:18:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrXEN6d3XOBZA1mJg4muL48EdTH//r1AdoJK5K81fvV54dalhXVW6tdQFoEn6bc0KR8L9uv X-Received: by 2002:a65:628a:: with SMTP id f10-v6mr14013498pgv.6.1527603482882; Tue, 29 May 2018 07:18:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527603482; cv=none; d=google.com; s=arc-20160816; b=jUhg4XDxnJtPInX7sb0Zl+scji7Ktd6jgLam5qmJYI4KEuUZAuSHzNn+Zk0qEJrNRU EBHSJ5Y/0ob3V1couLp6p3WW62UgHarr9tEO5oC84B7d6TKyWFl2G5OW+6g7EesPfEbi hiIIXYSneIjOn1tVGO805oZDF7gvs0r8ZDl7y0BjuGP83e2WVNZTJG6pAGn3RC8QKTTt 4juvMtnrFYzE2VDaJP2xt+50VS3rj/PlYiTZodGiTmps2jaO7UNVvgQ0z/6QR+jHLgEJ Q7ZUt6mwH0kA2aC1YFnY9xuzebEOWumYb25pvveKeaoMlwB0/ECa6voHshnXxS5DZr93 up8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=iLUmnW9TpWaGTu/2UnzC1hu3kT9i6tB7I218PpdcOSk=; b=vi5qnfFSDJ1F1RMdofdOsRGMWpAmFP8Fw4CYt5X1ahRHbm38b9pSVxdoLeCDWh75of J7UsPphGUZXwi4CSLo88ALbLn350aOTKMkILgF8iiSHDDoua9fqXcKdFq+PvqyhZ0Kzb b9rzr/RAxohqVQn6bszkBM5OrLS4hmJaahCVhAo2kGFOJk+oQe4AKp+T2Z3aJP+LPRT6 PCMAvApYRVi5Avkrf7954QzNPd0MX0EwFIoAJpyxFaYzH1JlE5g5axCQYhEuM72zAXRH 7k+Hci9HAake9LKnS4IdGmzMIba2cYheomJNQ7s5BGUIiY/IyYjfSz4CU91tQ30//It/ 7JIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p27-v6si32904211pfd.76.2018.05.29.07.17.48; Tue, 29 May 2018 07:18:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934583AbeE2OP4 (ORCPT + 99 others); Tue, 29 May 2018 10:15:56 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55802 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934158AbeE2OPz (ORCPT ); Tue, 29 May 2018 10:15:55 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id ABA32146B279C; Tue, 29 May 2018 07:15:54 -0700 (PDT) Date: Tue, 29 May 2018 10:15:53 -0400 (EDT) Message-Id: <20180529.101553.694799514284747444.davem@davemloft.net> To: laoar.shao@gmail.com Cc: songliubraving@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next] tcp: use data length instead of skb->len in tcp_probe From: David Miller In-Reply-To: <1527243245-29582-1-git-send-email-laoar.shao@gmail.com> References: <1527243245-29582-1-git-send-email-laoar.shao@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 May 2018 07:15:55 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yafang Shao Date: Fri, 25 May 2018 18:14:05 +0800 > skb->len is meaningless to user. > data length could be more helpful, with which we can easily filter out > the packet without payload. > > Signed-off-by: Yafang Shao Applied, thank you.