Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3472857imm; Tue, 29 May 2018 07:51:33 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqbLrv2DPopUbhkbuHwzBKjizisBtwhvX+ibGKje5LIXPAcefOSRgGi4KICPiet4QIZm96J X-Received: by 2002:a62:8785:: with SMTP id i127-v6mr17894183pfe.201.1527605493180; Tue, 29 May 2018 07:51:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527605493; cv=none; d=google.com; s=arc-20160816; b=wmxzWVRi5zkBlinsqDawbOSKpuD5mauMQdGuV/yq7Nfc9eiuhJjcnRohM/QWVbDAZQ ky6Lx6yrbv2GNhvh78NFNeYxbDA6oJ//Qt9IZSo+NBw3J5L3x36mYn/fGjPYt9ixAB4C j9zukFqveM9B/aW2DT72048eH7FFSBfchFwofLNJnhHP+QzPyWys0pSKTB2qk/m/ZTuw 0SKGPOYvr3xybFB5ngYjmkOjAM1SPzpkqVtYpOrmjSDNZO4HsjWEzCPqgAiWMxodNIP9 WxlXrX0axY9qO4wg7OdlPyJJt6fT8zwEZmRIWykNiKAzsTe36Og2QtKs4EKLP9rK19T2 so/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=VYy1mfAqD7atIBWTDy1uPASROf3lORAnxWs5atuAUe8=; b=mK75jb3ox76uxMaw/ahqbkMPUNAp0nG4GwPpy+lWiNRfuna6LkqrGDorXByqqhJwes i81DcetpMneM8i0ajQ8iYoNA6AAigYt0By5/20KBIjqfA4k4kWZ0a2P8HeCkbIPp+nP0 iNC+fljb9x0n6fKxJOICM+kGiMfWIPYK1+3skOgD4nKAGwRWTD4W4UP+xk/UfVykQlLU 9ubc9HbVjK1a8ADUCD69O8PqWIUmuaVdhWZtctevCx1dtUb0Kt+4FLZL1N+tXtR9c2jS 3+/IprOUgmGbt5AQ3OSf5sjnMpiRSKRb0/SSppq4/J6ZCCCGJmalKY9UGZK85dvSxkez AljQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nMpn9w/O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12-v6si25696962pgp.119.2018.05.29.07.51.19; Tue, 29 May 2018 07:51:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nMpn9w/O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935194AbeE2OsX (ORCPT + 99 others); Tue, 29 May 2018 10:48:23 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:35941 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936712AbeE2Oqu (ORCPT ); Tue, 29 May 2018 10:46:50 -0400 Received: by mail-io0-f194.google.com with SMTP id d73-v6so17883475iog.3; Tue, 29 May 2018 07:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VYy1mfAqD7atIBWTDy1uPASROf3lORAnxWs5atuAUe8=; b=nMpn9w/OtpXIWx55VHcdv07Q5LnHBJb3Qv3tQDtvD8LLb7kLK0rGWwzHNX9ST8n71o A5aiEsbql71OYqGuLQHqVvowD2g6cZRGcQ+db7yETPqO10ZjTgU4lMgrQRMAFt4Wv9VZ CtEiVrokevON6tPoVFqXDsUEJadQO877WVeXNpTfcAY/JUyg+NG17HZS9hh9CI5J8CAj 5hkD3V/Ppq2ksFDaAIRAQkQMQeLRSqBRaaSdHhS+a31anI0UPkW1+M9kfDVgIPLmI5wo KY0au0XqT5XG+Jzu931gZRifdqGkPWfMMAP+11St0ps+LtgiYRRbCeVTbiTwdSme+nrZ QI1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VYy1mfAqD7atIBWTDy1uPASROf3lORAnxWs5atuAUe8=; b=HDSL7aIepLd+rmt7sN7u3K8LegjnCDXnL2nmIXwCwox4pgE6SBW2fkgX4OblitECAS v6bM0IbZ4tffKiYLg62FnX7a03BHxdgGzeZ270vYfrHEhbDK7uaBg3wFEeDVk7lczdYB QJUTbXldSXO08kYS+kyZIlOPPE99pBP/sIRqotkIu4fTRjx1RKjx6XWKW0zo3gDPTC7P OU8LWZaNnUbvG+YQ+/9v7gkCSJRbcpoUeScuvjNcUwzraFeSA17zXRqh0JtVO3NhTity C/id+4IovUU7OznlTvOIs1jMuboMk1j6LoC+korPHFE8WQGHK6ieApkkPIUvEDssGJEb frGw== X-Gm-Message-State: ALKqPwdvSqLul+0ycqf8EewYY9ZLHBKQmPywdAU+F7zKK6444SPhJoNC +XPKmkHIlsyp0M8BSFT/adtFNrlNYd7a+uDs5Ys= X-Received: by 2002:a6b:ca46:: with SMTP id a67-v6mr14404232iog.53.1527605210075; Tue, 29 May 2018 07:46:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ef03:0:0:0:0:0 with HTTP; Tue, 29 May 2018 07:46:09 -0700 (PDT) In-Reply-To: <98df6d86-f237-b2d4-9f85-ce6d11c1ac4f@gmail.com> References: <1527243245-29582-1-git-send-email-laoar.shao@gmail.com> <20180529.101553.694799514284747444.davem@davemloft.net> <98df6d86-f237-b2d4-9f85-ce6d11c1ac4f@gmail.com> From: Yafang Shao Date: Tue, 29 May 2018 22:46:09 +0800 Message-ID: Subject: Re: [PATCH v2 net-next] tcp: use data length instead of skb->len in tcp_probe To: Eric Dumazet Cc: David Miller , Song Liu , netdev , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 10:42 PM, Eric Dumazet wrote: > > > On 05/29/2018 07:36 AM, Yafang Shao wrote: >> On Tue, May 29, 2018 at 10:15 PM, David Miller wrote: >>> From: Yafang Shao >>> Date: Fri, 25 May 2018 18:14:05 +0800 >>> >>>> skb->len is meaningless to user. >>>> data length could be more helpful, with which we can easily filter out >>>> the packet without payload. >>>> >>>> Signed-off-by: Yafang Shao >>> >>> Applied, thank you. >> >> Hi Dave, >> >> There's an update on this patch. >> Pls. see V4. >> >> And I will send a V5 patch per Eric's suggestion. > > Ah, if it is merged it might be too late. > > No big deal. > Since V3, it is changed to two patches. My bad. Only the original single patch was merged this time. Will change it based on the new tree. Thanks Yafang