Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3476918imm; Tue, 29 May 2018 07:56:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq9ChWYfbzAfIG5IaW7TXfPSqj6404Ntpox6kFOk4dQmqGHI12a/sH1QP/udjPAznYgfUPX X-Received: by 2002:a17:902:6bca:: with SMTP id m10-v6mr17921827plt.6.1527605762774; Tue, 29 May 2018 07:56:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527605762; cv=none; d=google.com; s=arc-20160816; b=UOap9GKyZc9CPQbiIT4NVrmrshf1kuo76fTSYnRu39fawsVZ3t19eUKr9xUwi727Wf XNM9/B/mZSfrioF9wdF/HALeOjPlZxm1RqWXUbRPi3zO+raE7T6XHgwxf96CgYX2vRsA cipVTUtqfGOyDdexRu4fb8ysywKXWoya1j9RzFB2/aUFVm9DtOKbWRE+TbV2IxrY5sR8 vVKv6InvRlwY7mDnx385gjGG+SJgm/WfO5VYJXhQsSEzQ6XI/NjkHlyHFTGHjXfu9kcg tdVowbyTkN2nUu1H3cAUxUrfBdxMSvmsTkJL0CCbjoyoKLzixY1y0VTVzcRzx2+go74/ JYlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=/1JeSw5AweNwa9jS5tpw4CKvv/oCufD784ITo1pRE5A=; b=lL9NQN6QPho2QOyVUdAw+xR7gV60DGKFKMt/KEtSsbBPYV2EU7/KKnOuhY5H9YR2NW ccRa4uqdULYh832hkmFaL873IkRdhHJjYqsMBFcZS4uYkZOQmMgX9nd63Mxpo7/eQkdS 3ac2pjN8fwAMo9YwaX8VJM9Xf1XYGXUkAVsRDf1EF+VoW2m/qqGB9rIKf2RbPRfHhQ74 X79GdExY/DF6uLTtRw1jJjp07JOr8g0ZJMXQMb5+7LFtvQuCXNKKoXD5zwXGkn8+vSjN d9TqQ7NRmr/HTagx54bxiUn5Q19iY8IbMkojbC97V4cA4ovS3FPSaV/0TUIU2nyToEA1 lLZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 91-v6si12228065ple.308.2018.05.29.07.55.48; Tue, 29 May 2018 07:56:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964987AbeE2OzE (ORCPT + 99 others); Tue, 29 May 2018 10:55:04 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:56258 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936597AbeE2Oy7 (ORCPT ); Tue, 29 May 2018 10:54:59 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 11BCA146B9898; Tue, 29 May 2018 07:54:57 -0700 (PDT) Date: Tue, 29 May 2018 10:54:55 -0400 (EDT) Message-Id: <20180529.105455.676464019941488974.davem@davemloft.net> To: laoar.shao@gmail.com Cc: songliubraving@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next] tcp: use data length instead of skb->len in tcp_probe From: David Miller In-Reply-To: References: <1527243245-29582-1-git-send-email-laoar.shao@gmail.com> <20180529.101553.694799514284747444.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 May 2018 07:54:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yafang Shao Date: Tue, 29 May 2018 22:36:50 +0800 > On Tue, May 29, 2018 at 10:15 PM, David Miller wrote: >> From: Yafang Shao >> Date: Fri, 25 May 2018 18:14:05 +0800 >> >>> skb->len is meaningless to user. >>> data length could be more helpful, with which we can easily filter out >>> the packet without payload. >>> >>> Signed-off-by: Yafang Shao >> >> Applied, thank you. > > Hi Dave, > > There's an update on this patch. > Pls. see V4. > > And I will send a V5 patch per Eric's suggestion. Sorry, I pushed it out already. You'll need to send me relative changes.