Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3480244imm; Tue, 29 May 2018 07:59:46 -0700 (PDT) X-Google-Smtp-Source: AB8JxZooXuMM75e6u2q0RmC7qAp21/7N23Ed8a1LLgbC5AVnKWQpkIEj7zV8RsUrVeEROJltaFYg X-Received: by 2002:a17:902:1007:: with SMTP id b7-v6mr17515606pla.88.1527605986388; Tue, 29 May 2018 07:59:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527605986; cv=none; d=google.com; s=arc-20160816; b=J9f9tkQrQbiintibL2Cj08UeUVwnQMQiD4vjhhF6eDqZylx704b7A2LTzmOTuX7VTs XGUWT5Nd5CpCFtJgh4jUEkb9hO8waWVyLwPBVXjhUjqViokHFXYRb7y5jBprm7O1BccA /vWoc/eRpDvcrpHc0CI1Xo2kxz8CFAOoY6l1fJnP8+cR+Ue3ObFx1uVaXbGbyQIwZ0G8 x7+EjvPSwG+5w0dlcr2GMqEzhho9CQV2ai/Z/sVoORNjGmfOnTmuK7SPfSyN/DhwQGWv jmMDTcAH1PH5fxgennh2KARCzxiqM1PsTRdf2PpuH4yROqBkODBEQtiz4JEbpYmevekF r1ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=t5BhAMjYRk1an+ovRZ9VgWkoTK45ua/LAKAl8aO+u/Y=; b=OA9m74w80nyluerGCjMErGTd5IAoMzxT+FRKfw7xEMjE/LIYVdCVs0D2mX6fXwhbks aGJGrkBgEvFiEq9iGouEzXcgg7Yl5ROuogCFKCv9kw2BYqp0gB1KqalntaLiMuTEfowa AqyVMuT0sLb+HoSaZcY6nytOLWyXC/pp+JlFVnybyUV8gv9x54dd3Wq8f7s1fE4LQ8K9 wH9FqBH3uOlUIKwVanzDLA6Y6eVQ5aaZZvTkXyC0UB5Ew0DTz0+z4hDWQj4+VMu1bmd+ 2e6B5bEW1/MxPfCsDO/e4GvWl3DBV0zRga1e9hs/X2BvTrgrGXYJFFVh79uXfq9NUB/4 Unwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Dc6Uojh9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6-v6si26500676pgr.72.2018.05.29.07.59.32; Tue, 29 May 2018 07:59:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Dc6Uojh9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936716AbeE2O5m (ORCPT + 99 others); Tue, 29 May 2018 10:57:42 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:36258 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935746AbeE2O5N (ORCPT ); Tue, 29 May 2018 10:57:13 -0400 Received: by mail-it0-f65.google.com with SMTP id e20-v6so18932154itc.1; Tue, 29 May 2018 07:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=t5BhAMjYRk1an+ovRZ9VgWkoTK45ua/LAKAl8aO+u/Y=; b=Dc6Uojh9GO/rR5+UDS80KP2s5UxtPP9qIVvxGVhMLzcgf/2ucOgMwopcUOjfGV5k66 qT8kI7PwSFrBj7tPUEXMmIA2OyjdbK6SwTT0feFLgO+2C5ilFGX6XY9MDT6yDIzxX6BY yu8qw0ZX2G3pTUB79z/f0nT+dibZQCdIsoqf1IPZNGjevJYAUroWPv+ON6xj9ahLfx+8 +GnhCXzIAb+bMS9GaVndbVduVPhO+FS8wqwQUm9QH87E83LXR9iqjfibEMviUeysCt+P kfcWgh/5aMUFjm4qxBwK7mJbLzwQjCArWgsAmF+M0YL3fq7ZN7sMYxQVSYjb9QiEVvv4 Haew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=t5BhAMjYRk1an+ovRZ9VgWkoTK45ua/LAKAl8aO+u/Y=; b=ZnRWnX1aQIzfd17BEUiuDcqj4ZFtRW6kUkA8dS+NhLVbdUzVntr3uS0DxLFUnAnn1D 3YbXFAn6dv63uz5OW2Og+zIdDA0yWFYFPhBka8KzUt8Tm9akm5p3BDwehdQLtLC9ppCI RxQkLCaU7zTCxxYU9rgPRF9m88sxsyOXwsDzFCuI6a5Y4FAuL6H2EaJDjleoH+vM6yb8 ELu6i8aELATIRJJb7FYG0lK6MypV26LG3obRKcZC32556RNRS1pq/eq8TzdRWgPEaf+p RYJhVVxYnfjydJU3VxMuU7uBGu0BnpRlB7ekaoFaq5jmCovZ1L6H6gRs6AQfeZzwcobx HsKA== X-Gm-Message-State: ALKqPweVjo/k8c9DgEJT0Tw4AlV2q9fUel8Ku+mhE+meFunxOGICOzqV 2EXYq9uPKw5bdNwu8ypxkVD/fqsV1ql+DN+m1+E= X-Received: by 2002:a24:5c47:: with SMTP id q68-v6mr15289838itb.118.1527605832394; Tue, 29 May 2018 07:57:12 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ef03:0:0:0:0:0 with HTTP; Tue, 29 May 2018 07:56:32 -0700 (PDT) In-Reply-To: <20180529.105455.676464019941488974.davem@davemloft.net> References: <1527243245-29582-1-git-send-email-laoar.shao@gmail.com> <20180529.101553.694799514284747444.davem@davemloft.net> <20180529.105455.676464019941488974.davem@davemloft.net> From: Yafang Shao Date: Tue, 29 May 2018 22:56:32 +0800 Message-ID: Subject: Re: [PATCH v2 net-next] tcp: use data length instead of skb->len in tcp_probe To: David Miller Cc: Song Liu , netdev , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 10:54 PM, David Miller wrote: > From: Yafang Shao > Date: Tue, 29 May 2018 22:36:50 +0800 > >> On Tue, May 29, 2018 at 10:15 PM, David Miller wrote: >>> From: Yafang Shao >>> Date: Fri, 25 May 2018 18:14:05 +0800 >>> >>>> skb->len is meaningless to user. >>>> data length could be more helpful, with which we can easily filter out >>>> the packet without payload. >>>> >>>> Signed-off-by: Yafang Shao >>> >>> Applied, thank you. >> >> Hi Dave, >> >> There's an update on this patch. >> Pls. see V4. >> >> And I will send a V5 patch per Eric's suggestion. > > Sorry, I pushed it out already. You'll need to send me relative changes. OK