Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3486965imm; Tue, 29 May 2018 08:04:37 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpp9NSBVN7vhRNgOfCzoGoJC2GjwxOOHbyL+SrkzZSjSB0avotzp866V4Dd5hQL3RxVPNFP X-Received: by 2002:a17:902:6bc1:: with SMTP id m1-v6mr17960115plt.91.1527606277034; Tue, 29 May 2018 08:04:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527606277; cv=none; d=google.com; s=arc-20160816; b=RqsnV4Z9a7fuQgKUcovly4ACJOZB8fHO88AUlfDkY4V/8+8Q4vK2pM7l30CFJvKhrX KH0GJiRkNJf6R5WT6AKHEoIKxRAWzxgmLb8vHrxFYSx9RwmkkUkD/m2lbt6in+Z+SD3N sEla+TeTiwGCFE4MqWzbQ7U5BFFEGuqf/bb4njR2UqRAFZMqaG2U36gBSc92pdOEWtZt VDQuKbrFjl+BV0eP4281BXClk1Jj52sFkOlw6ebdbt8Jur45TOVsH3YSv9Md8NoaB9LG YSTmSZsovBPhbMQys7IG4RcSiVbezYlMglndHl7bD/6+decbF6W/rGyC3rhaDYMMw/Z9 YZkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=XAqtlJKk0KFtCftADSZIIfBbqS7mvtSTKiWscehsItY=; b=yD+Vy4MQgo603O07Z2de+yH76k/Jwpw1V4D9LRBywuBc+Wklmja5lCIBnRQm0sSXiJ cMKcaQIHyvJztSNJA8Yb37e94mKJgX0kD3OVPatpbIBHBZKzLLgTSj7jgFi9xvZxHs4M p/+vx7T6QFWifYQJwKI2GBcmQM8cYoYJETuAGZB6NQ7tHQekRxc0Ms+j2hVS9vhpaGcg G8uuuVfFXVAPWItdm53A/zylqxE/pHJk4iq8vL5xSiJ2pnNKx7wothrj3P/6DO5ADPc2 ++VqNSsfkel5PIlYBypbYdqIX0x5TyqCY8cZK7zcjbV/9pw/rJ8lnrS1+RvfD2xmW0rD kK1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12-v6si15196029plm.461.2018.05.29.08.04.22; Tue, 29 May 2018 08:04:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935327AbeE2Oot (ORCPT + 99 others); Tue, 29 May 2018 10:44:49 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:39812 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935804AbeE2OoT (ORCPT ); Tue, 29 May 2018 10:44:19 -0400 Received: by mail-wm0-f67.google.com with SMTP id f8-v6so41442602wmc.4 for ; Tue, 29 May 2018 07:44:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XAqtlJKk0KFtCftADSZIIfBbqS7mvtSTKiWscehsItY=; b=oYMBmV0DPotesxTXs7OktTJmOpQPn/eD6mu69cVLH7qJUXV+ETnwW8c+HP+GRrsstw VLkthFsvcSv8A55MYkg1gbyMg25R82iVPwrRbHJ6JKYoS41MSpVRi4rUQT6qul6y3cao Pbx/2yVIbMl0ljnV26XB1gQ8x13dJgfFGiI1u2Li/nmNIadT5NBPYehGZYOG7H7Y1bF1 2qMG6icChNNRKZ/RL5fNgAYK4CS8OorS88CaZchRTBCe99ktAFJuzL72KJ9X52pVW5uh 8T6fhaTGAZVgbfTXQTSwJ1Xe3XqNcryxo/sj/AlwtAiUBvkxuoMunu5KPxyXYJqLBgo6 24UA== X-Gm-Message-State: ALKqPwfrBHpCq5+kjov6yb5jcAiDKPKu7RAuGpHJXrkp4THUIs0UxI4I J6H1M/n5PNz8HmWmZdtkUS449g== X-Received: by 2002:a1c:ea1a:: with SMTP id i26-v6mr12858872wmh.11.1527605058545; Tue, 29 May 2018 07:44:18 -0700 (PDT) Received: from veci.piliscsaba.redhat.com (catv-176-63-54-97.catv.broadband.hu. [176.63.54.97]) by smtp.gmail.com with ESMTPSA id t198-v6sm18834422wmt.23.2018.05.29.07.44.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 07:44:17 -0700 (PDT) From: Miklos Szeredi To: linux-unionfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 30/39] Revert "ovl: fix may_write_real() for overlayfs directories" Date: Tue, 29 May 2018 16:43:30 +0200 Message-Id: <20180529144339.16538-31-mszeredi@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180529144339.16538-1-mszeredi@redhat.com> References: <20180529144339.16538-1-mszeredi@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 954c736f865d6c0c68ae4263a2f3502ee7c447a3. Overlayfs no longer relies on the vfs for checking writability of files. Signed-off-by: Miklos Szeredi --- fs/namespace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 5f75969adff1..c3f7152a8419 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -468,9 +468,7 @@ static inline int may_write_real(struct file *file) /* File refers to upper, writable layer? */ upperdentry = d_real(dentry, NULL, 0, D_REAL_UPPER); - if (upperdentry && - (file_inode(file) == d_inode(upperdentry) || - file_inode(file) == d_inode(dentry))) + if (upperdentry && file_inode(file) == d_inode(upperdentry)) return 0; /* Lower layer: can't write to real file, sorry... */ -- 2.14.3