Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3494608imm; Tue, 29 May 2018 08:11:10 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIfoC6X4j4l5n7+C9KJ8UTWI3GUZWbwEuAuP+RQUPKsD1xw1+fIQsdIYfZaEToMJU23Anpn X-Received: by 2002:a17:902:8bc6:: with SMTP id r6-v6mr13521836plo.257.1527606670673; Tue, 29 May 2018 08:11:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527606670; cv=none; d=google.com; s=arc-20160816; b=iQ6BZpTTWqUMAoJppjRuVqmK8DX2WCz3Ip/8FTvSBjAqL7TaOuNI33orr+WiHADaGg LSczBIdud8FEJHDnw7T/6Ivo0J78b1824XBn60j6cDzBsSp9cMgpS/OKiePqerIoEj97 z6xMl460b80vuI1LNSKqc/S1DR9bT58lsFIkSgbBaAoI4G+11K2sNWyNDuWmiA8jqjr5 SLocc33B8/cTm51aY+s7I+2yfi/04XUJSnHYi6o8Es99C2rcde2hz1QHeEh4n613/EOy qtv+31tTn3nq5zamfAq84Q3T520gnoRfqomX4Z9rfTBIEmm5e/OEUeKPsQmrDAwy6qfJ AQOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=V2OmmVFBuUSgQckE8B0XrGIAQg/4IsUcPqZSEaSvA5o=; b=yPXiMZ01r6O5QWSmWOKcHhZr6Az+Kkw1eSGRCUei/NWgGjhFonhY1KvtUPxRE1VbAS NssTAai2oq+oTJiTDr0Qoy0XmCzs5cU3rQkVmrGwSQbUpmH7LS3R6Gfof6DMuSDolSy5 u4L0gOWUn2h02Nm1ACt5NPTn7izwRJBVGXQuqzctSPVya0r9W2g1N1d0Q0LKEK061gxE Ot0GPRjerfibwtLpiK8AU2Rlt0yZi8NhxqYcdCrl5d6zJM/S0+tLGSNe7txnARd4xwbd KMn5qo8wFmcuZi8YZ7FS4DwoZzTwnQtNLYX9rUp8j0IIhA3NqZCdAASNNAUtnHheeV9Z pbEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b63-v6si32895748plb.566.2018.05.29.08.10.56; Tue, 29 May 2018 08:11:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965043AbeE2PJU (ORCPT + 99 others); Tue, 29 May 2018 11:09:20 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:53910 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935733AbeE2OoM (ORCPT ); Tue, 29 May 2018 10:44:12 -0400 Received: by mail-wm0-f68.google.com with SMTP id a67-v6so41193889wmf.3 for ; Tue, 29 May 2018 07:44:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=V2OmmVFBuUSgQckE8B0XrGIAQg/4IsUcPqZSEaSvA5o=; b=NKBfHh2cEDeJL2Hq6EyDNV2xbD6d3+ljDe9ovY1JgFdmvbEtYWgYaszs7jhBIvnfuR qA52TMyoktxAXTyOIM5m1OdBbomMLZqCES9idHvVQaqLEgodT1dhnhp8G8WRHdwEdjzl AevSdzh5anYChlsnGs2yEgPtRnBvP9I1Y2lw2dAB1adNHF51ToLRJ4ZPngVvgxipP1f2 NlS/E/adtqHl7GoUuGwEClORB0c1+6F76l6oFnTIV7OssvUaAxYVyQx7VxE3TdZ9GwK7 Ypi9MI8fMADS3SHj15dL4c6wxtFwS+YbFRfpvINBOHaJUO0UpU+xnmF9SAKxRLi3lwIL P7lQ== X-Gm-Message-State: ALKqPwdjx1v4cB1DDI/EgaDvgOixT5x4o21OZeEQfVAETqX6qIlM73I+ PoNMrhV9TWQCZuyj5Du+mVlmlQ2mwjQ= X-Received: by 2002:a1c:aac3:: with SMTP id t186-v6mr4528800wme.14.1527605051094; Tue, 29 May 2018 07:44:11 -0700 (PDT) Received: from veci.piliscsaba.redhat.com (catv-176-63-54-97.catv.broadband.hu. [176.63.54.97]) by smtp.gmail.com with ESMTPSA id t198-v6sm18834422wmt.23.2018.05.29.07.44.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 07:44:10 -0700 (PDT) From: Miklos Szeredi To: linux-unionfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 25/39] vfs: don't open real Date: Tue, 29 May 2018 16:43:25 +0200 Message-Id: <20180529144339.16538-26-mszeredi@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180529144339.16538-1-mszeredi@redhat.com> References: <20180529144339.16538-1-mszeredi@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let overlayfs do its thing when opening a file. This enables stacking and fixes the corner case when a file is opened for read, modified through a writable open, and data is read from the read-only file. After this patch the read-only open will not return stale data even in this case. Signed-off-by: Miklos Szeredi --- fs/open.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/open.c b/fs/open.c index 6e52fd6fea7c..244cd2ecfefd 100644 --- a/fs/open.c +++ b/fs/open.c @@ -897,13 +897,8 @@ EXPORT_SYMBOL(file_path); int vfs_open(const struct path *path, struct file *file, const struct cred *cred) { - struct dentry *dentry = d_real(path->dentry, NULL, file->f_flags, 0); - - if (IS_ERR(dentry)) - return PTR_ERR(dentry); - file->f_path = *path; - return do_dentry_open(file, d_backing_inode(dentry), NULL, cred); + return do_dentry_open(file, d_backing_inode(path->dentry), NULL, cred); } /** -- 2.14.3