Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3500515imm; Tue, 29 May 2018 08:16:26 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp95OMevcAst31ehxk2jfJyNw/XXzHhKN+t23N34LzOb2IBAbp3hNcN/XJNwYMcUSrHyHgH X-Received: by 2002:a17:902:8486:: with SMTP id c6-v6mr18036737plo.23.1527606986319; Tue, 29 May 2018 08:16:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527606986; cv=none; d=google.com; s=arc-20160816; b=qMFOaXn2MTYWb81Fsj6velJqnjTU2XP0gTX0O8kjHozJr6xMhSRTglMRa2WjoYypFx /rUhbMbhMhMziK2xlYdSKo6LOL2Ow8Q81vgJkeR0fVrsVBzmOyjA5AqM1GwsvGdxKxLc mPuPgQM9a32suWDU0nhngSFDYGAM2AVhtqUm2u2xtJ0FKhfqzujox4iuXjBUWn6tLq7f rn6KlmQwLWil2EG759ZWYe+OTu1/WUThPYd3ASn2TNmI5ERlU5Pnqhvm1LC2qtTrDjWu Tb8zwmwKiqS/nVD5yE8jB7FcXI4bR/ygs9w/p7dH2Q6YTxou4YO/cg+yyTnGk1A1QkDl IM2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=D4FN1IAxjRcwqX1r17vbILmbwA6FKO6T4I5kNi9dsq4=; b=EInSKplSqKXUXYYAaIhQL8Piguj9/8P0KHYuafRTQJvVEzs/MxpLR3yiMvf2/L4JVb mE+BAZawJOAeYbSEbW76cQH055r/aYccuBv7952Sm+CDNxsvs/LfUnyZUT3LA7lOXVoE ybDDbFkAT8lKzuogbrY5CvWTgH2n4a0C5Ux4z3Z3clARA3PU/H1cP4FU8oiABAuYR8SE q8BE8FGuq6luq0yqW/mfs5Uh4tr2qO/Nijs1ykOCT37FmBx/iLj/aK7JIfzR21F7KaJU OhPUVC87p7JMWWfurhwY1l+224QgZBOryeD7PZNz6AD18jPmfb7dat9orJllkok7Ofxt MaNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7-v6si2121998pgo.81.2018.05.29.08.16.12; Tue, 29 May 2018 08:16:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935543AbeE2Ont (ORCPT + 99 others); Tue, 29 May 2018 10:43:49 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:46507 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934981AbeE2Onm (ORCPT ); Tue, 29 May 2018 10:43:42 -0400 Received: by mail-wr0-f195.google.com with SMTP id v13-v6so14286479wrp.13 for ; Tue, 29 May 2018 07:43:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=D4FN1IAxjRcwqX1r17vbILmbwA6FKO6T4I5kNi9dsq4=; b=heb+1n2n9V9g049GJx9DxSZymyLV47rLpfJt73uS+urdo8g7PoZBMI+XyghlbEnJsD jaRFLzP1O0F+tSNT3xeUNBGlSWtEfhPOzefv7wX8a2oHWcUzVrYPTdb6yxL+AvLzUV7n /vNp9dyYHrQ9YZ6iKFbarXaBmGByOtAA8A4VUEcbb3USB3NHxyUh/OXDdGFBNkaoQvJW JLrf95sWqf6XfAEAnbo4gQXYmIxNaC/3A0S4pSPhGRiWnuP0ufbE+0nmuay7Vs/YO+l+ 4qahF3/vwmRnjtS5/D6UPpeG98q1Fgx99+AK8tJoJiwWZHKzhA/hlI0/2XciAICg6tJw ywSg== X-Gm-Message-State: ALKqPwfXQCM6RsrSEocHhaHFDgXfFq642d8YB9uU40X8uatvAsArbwj+ mJPA1H4EBKYVw9MwclgQrFjxgA== X-Received: by 2002:adf:e20b:: with SMTP id j11-v6mr14676051wri.205.1527605021267; Tue, 29 May 2018 07:43:41 -0700 (PDT) Received: from veci.piliscsaba.redhat.com (catv-176-63-54-97.catv.broadband.hu. [176.63.54.97]) by smtp.gmail.com with ESMTPSA id t198-v6sm18834422wmt.23.2018.05.29.07.43.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 07:43:40 -0700 (PDT) From: Miklos Szeredi To: linux-unionfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 00/39] overlayfs: stack file operations Date: Tue, 29 May 2018 16:43:00 +0200 Message-Id: <20180529144339.16538-1-mszeredi@redhat.com> X-Mailer: git-send-email 2.14.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Up till now overlayfs didn't stack regular file operations. Instead, when a file was opened on an overlay, the file from one of the underlying layers would be opened and any file operations performed would directly go to the underlying file on a real filesystem. This works well mostly, but various hacks were added to the VFS to work around issues with this: - d_path() and friends - relatime handling - file locking - fsnotify - writecount handling There are also issues that are unresolved before this patchset: - ioctl's that need write access but can be performed on a O_RDONLY fd - ro/rw inconsistency: file on lower layer opened for read-only will return stale data on read after copy-up and modification - ro/rw inconsistency for mmap: file on lower layer mapped shared will contain stale data after copy-up and modification This patch series reverts the VFS hacks (with the exception of d_path) and fixes the unresoved issues. We need to keep d_path related hacks, because memory maps are still not stacked, yet d_path() should keep working on vma->vm_file->f_path. No regressions were observed after running various test suites (xfstests, ltp, unionmount-testsuite, pjd-fstest). Performance impact of stacking was found to be minimal. Memory use for open overlay files increases by about 256bytes or 12%. Git tree is here: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-rorw --- Miklos Szeredi (39): vfs: dedpue: return loff_t vfs: dedupe: rationalize args vfs: dedupe: extract helper for a single dedup vfs: add path_open() vfs: optionally don't account file in nr_files vfs: add f_op->pre_mmap() vfs: export vfs_ioctl() to modules vfs: export vfs_dedupe_file_range_one() to modules ovl: copy up times ovl: copy up inode flags Revert "Revert "ovl: get_write_access() in truncate"" ovl: copy up file size as well ovl: deal with overlay files in ovl_d_real() ovl: stack file ops ovl: add helper to return real file ovl: add ovl_read_iter() ovl: add ovl_write_iter() ovl: add ovl_fsync() ovl: add ovl_mmap() ovl: add ovl_fallocate() ovl: add lsattr/chattr support ovl: add ovl_fiemap() ovl: add O_DIRECT support ovl: add reflink/copyfile/dedup support vfs: don't open real ovl: copy-up on MAP_SHARED ovl: obsolete "check_copy_up" module option ovl: fix documentation of non-standard behavior vfs: simplify dentry_open() Revert "ovl: fix may_write_real() for overlayfs directories" Revert "ovl: don't allow writing ioctl on lower layer" vfs: fix freeze protection in mnt_want_write_file() for overlayfs Revert "ovl: fix relatime for directories" Revert "vfs: update ovl inode before relatime check" Revert "vfs: add flags to d_real()" Revert "vfs: do get_write_access() on upper layer of overlayfs" Partially revert "locks: fix file locking on overlayfs" Revert "fsnotify: support overlayfs" vfs: remove open_flags from d_real() Documentation/filesystems/Locking | 4 +- Documentation/filesystems/overlayfs.txt | 60 ++-- Documentation/filesystems/vfs.txt | 19 +- fs/btrfs/ctree.h | 5 +- fs/btrfs/ioctl.c | 7 +- fs/file_table.c | 13 +- fs/inode.c | 46 +-- fs/internal.h | 17 +- fs/ioctl.c | 1 + fs/locks.c | 20 +- fs/namei.c | 2 +- fs/namespace.c | 69 +---- fs/ocfs2/file.c | 10 +- fs/open.c | 74 ++--- fs/overlayfs/Kconfig | 21 ++ fs/overlayfs/Makefile | 4 +- fs/overlayfs/copy_up.c | 30 +- fs/overlayfs/dir.c | 31 +- fs/overlayfs/file.c | 509 ++++++++++++++++++++++++++++++++ fs/overlayfs/inode.c | 63 +++- fs/overlayfs/overlayfs.h | 21 +- fs/overlayfs/ovl_entry.h | 1 + fs/overlayfs/super.c | 65 ++-- fs/overlayfs/util.c | 11 +- fs/read_write.c | 91 +++--- fs/xattr.c | 9 +- fs/xfs/xfs_file.c | 8 +- include/linux/dcache.h | 15 +- include/linux/fs.h | 32 +- include/linux/fsnotify.h | 14 +- include/uapi/linux/fs.h | 1 - mm/util.c | 5 + 32 files changed, 898 insertions(+), 380 deletions(-) create mode 100644 fs/overlayfs/file.c -- 2.14.3