Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3529077imm; Tue, 29 May 2018 08:45:43 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJLuLHvaVpIgSuFNA2v08X2MeXM4Oq3bJwTBLIkGl7lWqwSaUCicriGsn4tdXZUHGRuZ9Ws X-Received: by 2002:a62:50d6:: with SMTP id g83-v6mr12649905pfj.31.1527608742982; Tue, 29 May 2018 08:45:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527608742; cv=none; d=google.com; s=arc-20160816; b=w3Jt/iL4ra+Xk6queXn+ZI7xalT9dvv+Bcri4jYk3lvhua+2zxTN8UMEOZhrmSUYq6 7nscMuXLjY/q/CsnSvcRK4InVy0ieITdlpig9RUCxWZOKYCIkNXPsnkUUa38Xsc10sJg 8HSHktRjNVZl6hlEsocOGZZyYhDTAAdhYee0dqJ7g29N9EJcsEMeO/6U+bjpbR1jbNZK u1Eke3H+GO5dPp+s7oqG1fWe15Kow/cOuDTVTpzqj1t9XYG4LSDA0JRFKux5IEfnKqi9 kD1rwo/xc5F4ZSMK6FbURNlsCVq782bd1nJ/NozUNbSJg9I0pEgQsk9HFchELmkrK6SP uuYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=wvx8YXcO2DFMQsBhPc/d2DW5+aRNNTNcSZ7An/ejkxo=; b=PofwKNwzxtw+S+KulMV87KDYLJOE4t/dkd7xNGnKw4sAnmTQh79xC/dCANkMZQapG+ 3UlGvajQEyEfQ7QctajQoQoYo7hsFgqYB+Y9X0HQdyhYH46miTILtIWYstS88CjAxk3p 4r+ksXgEuKFEatpPKYxF/VAyB3Km6gYML6lG/LVdxBQKNYhkjSg467JoB5wyPagTYZhk cx01O3mh9CErZ98xF6oJhdopq4xJ3PFRjjAVL6K/hXdAiY7+oP994FqoKleNIzYVqMyP 7CiOfES7jI94s9+2B3OdYamWlQXBLGtnL7a8GkSX5ic7uoS6fVQDyc9/8IrguqfTZNuL fGPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8-v6si21178704pgr.39.2018.05.29.08.45.29; Tue, 29 May 2018 08:45:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936939AbeE2PpB (ORCPT + 99 others); Tue, 29 May 2018 11:45:01 -0400 Received: from foss.arm.com ([217.140.101.70]:43566 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935434AbeE2Poz (ORCPT ); Tue, 29 May 2018 11:44:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 15EA580D; Tue, 29 May 2018 08:44:55 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DADA13F25D; Tue, 29 May 2018 08:44:54 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 6B47E1AE4DC6; Tue, 29 May 2018 16:45:24 +0100 (BST) Date: Tue, 29 May 2018 16:45:24 +0100 From: Will Deacon To: nixiaoming Cc: catalin.marinas@arm.com, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, james.morse@arm.com, kristina.martsenko@arm.com, steve.capper@arm.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, dan.j.williams@intel.com, kirill.shutemov@linux.intel.com, zhang.jia@linux.alibaba.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 1/3] arm64:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro Message-ID: <20180529154523.GK17159@arm.com> References: <20180529133615.26889-1-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180529133615.26889-1-nixiaoming@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 09:36:15PM +0800, nixiaoming wrote: > mark_rodata_ro is only called by the function mark_readonly when > CONFIG_STRICT_KERNEL_RWX=y, > if CONFIG_STRICT_KERNEL_RWX is not set > a compile warning may be triggered: unused function How are you achieving this configuration? In our Kconfig we select this unconditionally. Will