Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Javier Gonzalez <javier@cnexlabs.com>
To:     "Konopko, Igor J" <igor.j.konopko@intel.com>
CC:     =?iso-8859-1?Q?Matias_Bj=F8rling?= <mb@lightnvm.io>,
        Jens Axboe <axboe@fb.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Dziegielewski, Marcin" <marcin.dziegielewski@intel.com>
Subject: Re: [GIT PULL 16/20] lightnvm: error handling when whole line is bad
Thread-Topic: [GIT PULL 16/20] lightnvm: error handling when whole line is bad
Thread-Index: AQHT9nLk+7vqiSCzNkOz9kbNSFk2TqRGsWQAgABXlQA=
Date:   Tue, 29 May 2018 18:29:19 +0000
Message-ID: <19F83A5D-1449-4F9F-B8E3-0B2B104DA1D2@cnexlabs.com>
References: <20180528085841.26684-1-mb@lightnvm.io>
 <20180528085841.26684-17-mb@lightnvm.io>
 <C161E678-ADEE-4E05-AC19-B54358005532@cnexlabs.com>
 <76C92B909A93A84C99173B331AB578DAC7AB5252@irsmsx111.ger.corp.intel.com>
In-Reply-To: <76C92B909A93A84C99173B331AB578DAC7AB5252@irsmsx111.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cnexlabs.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/signed;
        boundary="Apple-Mail=_5664C234-7830-41B5-92D4-BC7BC63B8AD1";
        protocol="application/pgp-signature"; micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ddf8775b-e4d8-4727-f457-08d5c59217e8
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2018 18:29:19.9208
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e40dfc2e-c6c1-463a-a598-38602b2c3cff
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR06MB906
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--Apple-Mail=_5664C234-7830-41B5-92D4-BC7BC63B8AD1
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

> On 29 May 2018, at 15.15, Konopko, Igor J <igor.j.konopko@intel.com> wrote:
> 
>> From: Javier Gonzalez [mailto:javier@cnexlabs.com]
>> This case cannot occur on the only user of the function
>> (pblk_recov_l2p()). On the previous check (pblk_line_was_written()), we
>> verify the state of the line and the position of the first good chunk. In
>> the case of a bad line (less chunks than a given threshold to allow
>> emeta), the recovery will not be carried out in the line.
> You are right. It looks that during my testing there was some
> inconsistency between chunks state table which is verified inside
> pblk_line_was_written() and blk_bitmap which was read from emeta and
> is verified in pblk_line_smeta_start(). I'm living decision to
> maintainers whether we should keep this sanity check or not - it
> really just pass gracefully the result from pblk_line_smeta_start()
> where similar sanity check is present.
> 

Let's avoid an extra check now that there is no users for it in the
current flow. If we have a new use for pblk_line_smeta_start() on a flow
that does cannot offer the same guarantees, we can add it at that point.

Javier

--Apple-Mail=_5664C234-7830-41B5-92D4-BC7BC63B8AD1
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE+ws7Qq+qZPG1bJoyIX4xUKFRnnQFAlsNm/cACgkQIX4xUKFR
nnRZ6A/8D5UCV2VtrlxE60KDd+UJYs1q/Ltj8xlZe1MXmexaFRYEAUb4Li6UABo6
Zv0cN7u8gIGX61UVvFmNu4fk9++WurBLjdptqMDYk2CFynG4nOx4KfYjZNzYjuEf
F5oqZczCDlqJmVXsJW3qZLq2qU/Tq1BYD58Mhh7yZ2G3Ph0ThK2l0Wgo9Jcx7hgi
G0CY+Oa79yjS5YBvn1ENywf6L6y4FzjPr1ah3l3mdkFiMIfw7kB+fE5eNvD1Kt0d
eHMwi+H9T/EUKJGAHOyEKwCEC/cEKIMHQNzromeNHRN6xdGzOY+VcTThKBMpmuEU
o7GYEX+d+5lEH/PkNtHWq/1KrAbrvR0qdYcGTFlJXE8YQkF77mNJoRtx6O2XXFed
A5kU8pRnDNI5Um60gxu1dWBCWAjz+8L/GPg89YT9PA2WPI6zDJrBS1RRrVTAGIWr
YG3DWtdO5+jhD6KuGSFijhyT/Diteq65eV9eTByqxJr8Cwdsz2atoLDrm84Rsmwh
/59HDL0f9g9xIPTf8BD7FyUMR8auPL18ODbWoR8BGFgPqiq1AgnE8T60irv0KhLz
kk5iQhleuNH3+AiqL+aFPYHWUZO2xFuDJOxh0eliacZp+OjhZNur1rczgH3FCWwV
z5s2MRx9fH/WKvZp01b5d51SQ1XZpt7r4D24Amo7svgj21sH+kk=
=hwe1
-----END PGP SIGNATURE-----

--Apple-Mail=_5664C234-7830-41B5-92D4-BC7BC63B8AD1--