Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3727665imm; Tue, 29 May 2018 12:27:45 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpKd7YVhlPgf3HUmwHvB3MTiIeIfTg4crbp02QvTRzj3pRzvfZEvyg7XeID4MSfnHC6H/6d X-Received: by 2002:a63:b943:: with SMTP id v3-v6mr14899560pgo.438.1527622065664; Tue, 29 May 2018 12:27:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527622065; cv=none; d=google.com; s=arc-20160816; b=tyS2jMVvWG3m551lQGaDYojVrmk2gzsb8PsY/2xrouaoIi4jcAG4EigWTf3gwYQ82f ij/0UVfGviRh5DjoBlgot9nFeSUsCcMm9PXGJW48cTK4dNJUbK0HI/2F5WolDG0TQhVa YkeedECYRXbzXHwR6v+wVTi/ouu9sPNv2kkhCYoWIs4t3Ei03BvmxRT3eaHfetvlKGQb ijFry5gHhGGqa38LMZm/WGxAGuYbVaWPkR0acCNC7utQXxDZM66wSeGJxu1LCx1Yk9D5 mZgN5+oJkE+/AwFrZ3vfxsu2ireuJOAoB694HOdzJ/+aSG/4l67suy64ViHLAqVv/zEe BTEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=QOn3gzJsfall2Wg/r4XUYS1UcZK0SGW8IJLE+pKjhTE=; b=MOSVQcsIVwZvdRuSAcxRa6WyCFWQlapXdQJuctqiBy6s1MAfxlcuKrFZ2rIFewhoJX KVeeOfyHKek2btqh8vAqzsPE62vb5nhHl92P2bSZRHRvbfMpAcfYe8uNnVOPE96MMQKd lT6vdaoMe4r7ksNarUXLduKb0TayvGeannCehLP8WlQxHBeD4cgqG2gSwdd9w4V71htN yOkZRlRDrZf13h/lWBiVrgq7RrbDbQIE1wBv0Y60ChvqtlI3/tBGmhW2/KbpFikl7wng V4iPI3xL4Z8U1XWJ0xQLqb4x1nol4HJ5nhWKUcwFlAd9/9tzoxqNAvv12q469LePZxIl sOyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZLCLS0vW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5-v6si32340408plp.108.2018.05.29.12.27.30; Tue, 29 May 2018 12:27:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZLCLS0vW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966191AbeE2T0v (ORCPT + 99 others); Tue, 29 May 2018 15:26:51 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:42599 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965759AbeE2T0s (ORCPT ); Tue, 29 May 2018 15:26:48 -0400 Received: by mail-qk0-f194.google.com with SMTP id j80-v6so10711696qke.9; Tue, 29 May 2018 12:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QOn3gzJsfall2Wg/r4XUYS1UcZK0SGW8IJLE+pKjhTE=; b=ZLCLS0vWO3IeSDAIsTY3FPvSuX1K9EQ6sVcK0DrtCgmS1F7qGrl0nnQBrRye8J03U8 mPPggJqP5dbOrmD2RJGCDtOydA7kgWgofVH3XDE/C96UPbjcemny4/4uiTUDzXrCxFu1 LCcT9dHFLfWFKqnBQFiEBPNs/Sjub7W0psBn3P1ttbQd7q1I00f3wweV7MB1AQ24X/Vz dgUp1wzsETECAswZap82cMpbcK3XRT1cll3iDEelhDO+4VvjvRnFeemYNfFbAQADFn+O IZwMSpR24QiEgGQFfCqYdQ82Tf9PprDWeR91B420uZ4G54QwQ6mLwsOtnGybmUPMUO+q mkjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QOn3gzJsfall2Wg/r4XUYS1UcZK0SGW8IJLE+pKjhTE=; b=SaTWxP51grOsBQRkJAiRaBqN+mk9t4y/p68T1QQOPV6szX9agh/TU0suPGRIBLpEmM byl1TI6hN3CrPm31WPKzdRYCc0vIGBgOQiOUqlet8lWEI/pIhHuQ9EWFAeeCPnPMuePV 6wAm506JXVz7/wzh0AjY96IIESepy5NncOw83D9YYFufl0Dd6hNfYr8zm8m1730sCEDZ 5qmXSxmSH1Y3ZfvfcnLL6/0YCgXzYI28Kt2qszcmKTGadz1xo6wwwHRK3WSaEHPK6R6H dj2dRIsFoqwmFM6sBmTtPbLwory87osTf1y8aqXZP+kOIYAstLDpQZRMoK4cOPDSc7DM WsBw== X-Gm-Message-State: ALKqPwdLliOoaHR+TspiPh7+MGV1i8stRYZe3BiLsCnbOCHEVrYpOux8 YUL9i1OfQ4fxEAhUzRBf1A== X-Received: by 2002:a37:7645:: with SMTP id r66-v6mr17229651qkc.394.1527622007386; Tue, 29 May 2018 12:26:47 -0700 (PDT) Received: from kmo-pixel (c-71-234-172-214.hsd1.vt.comcast.net. [71.234.172.214]) by smtp.gmail.com with ESMTPSA id i52-v6sm12046248qtc.26.2018.05.29.12.26.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 12:26:45 -0700 (PDT) Date: Tue, 29 May 2018 15:26:43 -0400 From: Kent Overstreet To: "Luis R. Rodriguez" Cc: Coly Li , Ciaran Farrell , One Thousand Gnomes , linux-bcache@vger.kernel.org, "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Tso Ted , Linus Torvalds , Thomas Gleixner , Philippe Ombredanne , Kate Stewart , Jonas Oberg Subject: Re: PostgreSQL licensed code on Linux Message-ID: <20180529192643.GA3487@kmo-pixel> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 12:14:01PM -0700, Luis R. Rodriguez wrote: > The question over future possible PostgreSQL licensed code on Linux came up > to me recently. While doing some quick of digging around I found code > already under such license it seems: > > The file drivers/md/bcache/util.c has: > > cafe563591446 (Kent Overstreet 2013-03-23 16:11:31 -0700 318) /* > cafe563591446 (Kent Overstreet 2013-03-23 16:11:31 -0700 319) * Portions > Copyright (c) 1996-2001, PostgreSQL Global Development Group (Any > cafe563591446 (Kent Overstreet 2013-03-23 16:11:31 -0700 320) * use > permitted, subject to terms of PostgreSQL license; see.) > > That seems to indicate that we've had already PostgreSQL licensed code on > Linux since Kent's addition of bcache to Linux in 2013. The portion of code > is rather small though, to me it seems to cover only crc_table[], > bch_crc64_update(), and bch_crc64(). Four things: Yep, it's just that code. > > a) This is the only code on Linux which seems to use PostgreSQL > b) The language for license seem to be cut off, 'see.' seems incomplete, > whereas typically it would point to a file with the full language text. > c) We can only infer what portions of the file are under this license > d) Even though some licenses claim to be GPL-Compatible, if possible we > should dual license such with the GPL if possible (*) > > If some folks are considering adding yet more code to Linux which is > currently under a PostgreSQL license I figured reviewing the existing > PostgreSQL code's use may be a good start to set precedent for future work. > Since we already have at least one file with a PostgreSQL-sort-of boiler > plate it at least sets the precedent we have already sort of dealt with > PostgreSQL. > > My recommendations: > > As silly as it may be we should split out the PostgreSQL licensed code from > drivers/md/bcache/util.c into its own file and while at it clarify the > license. > > If possible, if we can dual license this code with GPL it would be good as > it would do two things: > > 1) Removes any ambiguity in case of questions over GPL Compatibility in the > future about the PostgreSQL license > > 2) Other folks considering using PostgreSQL licensed code on Linux have a > template they can use Sounds good to me, I'll defer to your judgement since you have more experience with these things than me :) Let me know if there's anything you need from me. I never modified that code besides renaming the functions, but dual licensing would be fine by me.