Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3881865imm; Tue, 29 May 2018 16:01:53 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKSpva8l5PAGDhZ3/fVvZz2WEIGFEYAqkoHUx4LmPxfZyZ4b4FPmux8O3ZPw4RNFocM32rg X-Received: by 2002:a63:3548:: with SMTP id c69-v6mr248810pga.217.1527634913039; Tue, 29 May 2018 16:01:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527634913; cv=none; d=google.com; s=arc-20160816; b=lL1SzzWhhS7UEHtkPyCeQ82bCBoDPbSr0I14tAx+z1eEYPzRwYFNQtFgjj+IkLrpVL hwkHdN6XEU+1sLVQqEl2W0TMCmSl4FLT7LGDsaysZLB74ivsTqJhkMUC8HZD2mXSXScn 8jlTAi9wWfcMbIyoLxjyqKgBep/x+5QVUOgMycAbuz6Ydp0T/h870fVNQbTQys7hoe/J z0eoU2BpzYqYpV+niIWUiNsQ4BadKrZUmr/OX2AiEcaw9L/wkOQgEotb7zQQcZ0CUXfs V0ujnTzASxajqxlzvqtJ9FVo4QDE1SAIjbURC1vzW5xU1ynUzb8lE71BnMTbB8RVQk8J 1u+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=4pUxigK0y72r6p540aFaZoBsICv1prhzuGM7FiTAQuU=; b=IBZYotDM5odH9dgA2VjU3PmiK8+LxX8mvYPm0aGmA45atIOzcZfY9GM1YDWbX7Zjd5 5rgWbbFcRXXXOXlHQEGSP4B7vrkTLf8wtqiuLn8Zak3qs30SXUhSHCy0+CKh69IV/NVc JGFPs5roodaC7skhubJRFzo9DZtNs14QkfRakcpWD+K79nVnd7q6GXk88D44JO8+1PGX XN/QN3cBCfw3Uz97zBUEK8E4QfIFLHu6vQOfB3/+OTXPBMf2c5mBEVKvr9fssA50RP5i d3MBCl4X812IaYFRijS5m3M4egJXOoE/KdQKJ6K/zmbjFEEhhfBPu8bOobuhxX+6FnTb 0r7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r28-v6si7687014pgu.408.2018.05.29.16.01.38; Tue, 29 May 2018 16:01:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967906AbeE2W7i (ORCPT + 99 others); Tue, 29 May 2018 18:59:38 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:35484 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967991AbeE2W7d (ORCPT ); Tue, 29 May 2018 18:59:33 -0400 Received: by mail-pl0-f68.google.com with SMTP id i5-v6so9825608plt.2; Tue, 29 May 2018 15:59:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4pUxigK0y72r6p540aFaZoBsICv1prhzuGM7FiTAQuU=; b=kDpgcuWnP5o8pKEkdYOAkQwmn3aG96LstMIhxsrw3q6iKXSyfmcY5D0QvuO3cA/yZH TrS1jfClOjZAYNcLOyMt5SLYxXy3GHH7V+Jli1YnP+Dpwu7kOmQbW653cLoEFswtGjMC IX7dAIYkRBpOuqi8Q3MKgnKkZFXXvFp5AmZPjofxysFKbbqez/YMtTR148AbGZmjZ36k Y1N2DkZAyGCkP4HP1EbPuoIRqrAu1AhJW8XwwE4DubboDGmW4vT/3hDRqHB7qKToddpT FLeXvdaa+EbMR78VxRwTpHQDYg3gCrT3rldTcSXg9RjLjQ4cx1mlryYKtiCYj9atZDX6 Ajmw== X-Gm-Message-State: ALKqPwdgYUrauz3R9o6YBY3leFx8/oiY+xw/pXhU9+YiB/rFGTtHiQgQ 9RC8IdDiBeX4QuobTTjOx04= X-Received: by 2002:a17:902:a5:: with SMTP id a34-v6mr355761pla.58.1527634772365; Tue, 29 May 2018 15:59:32 -0700 (PDT) Received: from garbanzo.do-not-panic.com (c-73-15-241-2.hsd1.ca.comcast.net. [73.15.241.2]) by smtp.gmail.com with ESMTPSA id a195-v6sm75858440pfa.143.2018.05.29.15.59.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 15:59:31 -0700 (PDT) Received: by garbanzo.do-not-panic.com (sSMTP sendmail emulation); Tue, 29 May 2018 15:59:28 -0700 Date: Tue, 29 May 2018 15:59:28 -0700 From: "Luis R. Rodriguez" To: Kent Overstreet Cc: "Theodore Y. Ts'o" , Coly Li , Ciaran Farrell , One Thousand Gnomes , linux-bcache@vger.kernel.org, "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Linus Torvalds , Thomas Gleixner , Philippe Ombredanne , Kate Stewart , Jonas Oberg Subject: Re: PostgreSQL licensed code on Linux Message-ID: <20180529225928.GI31712@garbanzo.do-not-panic.com> References: <20180529192643.GA3487@kmo-pixel> <20180529205143.GB7381@thunk.org> <20180529210025.GB3487@kmo-pixel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180529210025.GB3487@kmo-pixel> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 05:00:25PM -0400, Kent Overstreet wrote: > On Tue, May 29, 2018 at 04:51:44PM -0400, Theodore Y. Ts'o wrote: > > On Tue, May 29, 2018 at 03:26:43PM -0400, Kent Overstreet wrote: > > > > That seems to indicate that we've had already PostgreSQL licensed code on > > > > Linux since Kent's addition of bcache to Linux in 2013. The portion of code > > > > is rather small though, to me it seems to cover only crc_table[], > > > > bch_crc64_update(), and bch_crc64(). > > > > > > > As silly as it may be we should split out the PostgreSQL licensed code from > > > > drivers/md/bcache/util.c into its own file and while at it clarify the > > > > license. > > > > While we're at it maybe we should move the crc-64 code to lib and/or > > crypto, alongside our support for crc-8, crc-16, and crc-32 > > algorithms? That way if there are other potential users for crc-64, > > they will be less likely to re-invent the wheel.... > > Yeah, this came up because Coly wanted to do that, but needed to know what to > put in MODULE_LICENSE(). At run time its GPL, so MODULE_LICENSE("GPL") would make sense. I had sent a patch to help clarify this in 2012, I'll resend now [0]. [0] https://lkml.org/lkml/2012/4/8/75 Luis