Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4044050imm; Tue, 29 May 2018 20:33:32 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJRJ/5GvHuj6vwTvm+iPGo+KyHLuOR/m90GgWu3JjzTrJfNaYc2CVAstYK01nFCnQHxESrO X-Received: by 2002:a62:f24a:: with SMTP id y10-v6mr1081496pfl.75.1527651212739; Tue, 29 May 2018 20:33:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527651212; cv=none; d=google.com; s=arc-20160816; b=ZKCongPZt3QNfhgi+2caXfSdX0yzzEVZ6ofLjFDlZe8vNfN0HJZyPkz4DuTOPEfPsL ob4GbVfo8foJjHC0Dr4FtlXL47fb+lRDBqLVMhYFTwA9ob1yr6eepTbidHW/3B+YCB8K SMJWWzXxx2zfSVs3ISVJ/ofQWfvgtL1iB/UBF2aLg+KR/3AKux0qqAtuvCRxdI3YEQov 07m4FXVucfUmPT1DON0BzGfgXF7iaT1XEgfdttQVh7/ZI3lgofp8tS9rSDZr3sJ9XNRl ZCnHCkqINWjXCfWTo5wEi46J7Me3ecbZy+ytmhUnFuJv5/FL2/unf62PZuJKwCVYYVGU WbeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from :arc-authentication-results; bh=jUj8WcGjOUrcr1ZVfT+hvA6zHVQKRQ3/elYDGavM6vE=; b=gC4FvHozMMIVS+YZTtGOU9m+Rr4k4O3X3prI/PmuWK6oVzcK1PK90ERYfhCOFMAMLX T3bMg++i9c2k6LhBoLQIj6WM/irQLM49xifApBiV3qSyXeA5mHnOXsj4S5inQEfXiZBR iSHegGkI8ORULusReleGEMePv0XGd9V+3bJgdjq2DuSwOc7jkTuPc1eTzHqzoyDwLZEJ NpQdWipvAKpmFRrhYMCuhlV8O5BcNR1GHaKJ/j31WhiybX+CZVvlpHA1e/uuHlZGwcUG XMhhNXqZGg65yJDlZsdCQaSD1c7jnNbR1t/fHYJ1dOQ4OGOOFMuJdcRwtXWCBCL+hXP1 iaqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i69-v6si8429585pge.674.2018.05.29.20.33.18; Tue, 29 May 2018 20:33:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935889AbeE3Dbs convert rfc822-to-8bit (ORCPT + 99 others); Tue, 29 May 2018 23:31:48 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:5976 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754765AbeE3Dbp (ORCPT ); Tue, 29 May 2018 23:31:45 -0400 Received: from DGGEMM401-HUB.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id 1BFE296B6B16E; Wed, 30 May 2018 11:31:40 +0800 (CST) Received: from DGGEMM423-HUB.china.huawei.com (10.1.198.40) by DGGEMM401-HUB.china.huawei.com (10.3.20.209) with Microsoft SMTP Server (TLS) id 14.3.382.0; Wed, 30 May 2018 11:31:42 +0800 Received: from DGGEMM507-MBX.china.huawei.com ([169.254.1.166]) by dggemm423-hub.china.huawei.com ([10.1.198.40]) with mapi id 14.03.0382.000; Wed, 30 May 2018 11:31:39 +0800 From: Nixiaoming To: Will Deacon CC: "catalin.marinas@arm.com" , "ard.biesheuvel@linaro.org" , "marc.zyngier@arm.com" , "james.morse@arm.com" , "kristina.martsenko@arm.com" , "steve.capper@arm.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" , "mhocko@suse.com" , "dave.hansen@linux.intel.com" , "dan.j.williams@intel.com" , "kirill.shutemov@linux.intel.com" , "zhang.jia@linux.alibaba.com" , "schwidefsky@de.ibm.com" , "heiko.carstens@de.ibm.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "x86@kernel.org" , "linux-s390@vger.kernel.org" Subject: RE: [PATCH 1/3] arm64:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro Thread-Topic: [PATCH 1/3] arm64:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro Thread-Index: AQHT91VOSqz8jbk29Ua9aMsejfLmPaRGU1YAgAFJszA= Date: Wed, 30 May 2018 03:31:38 +0000 Message-ID: References: <20180529133615.26889-1-nixiaoming@huawei.com> <20180529154523.GK17159@arm.com> In-Reply-To: <20180529154523.GK17159@arm.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.57.88.168] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unable to set CONFIG_STRICT_KERNEL_RWX=n by make menuconfig ARCH=arm64 When reading the code, I feel it is more appropriate to add macro control here. -----Original Message----- From: Will Deacon [mailto:will.deacon@arm.com] Sent: Tuesday, May 29, 2018 11:45 PM To: Nixiaoming Cc: catalin.marinas@arm.com; ard.biesheuvel@linaro.org; marc.zyngier@arm.com; james.morse@arm.com; kristina.martsenko@arm.com; steve.capper@arm.com; tglx@linutronix.de; mingo@redhat.com; hpa@zytor.com; akpm@linux-foundation.org; vbabka@suse.cz; mhocko@suse.com; dave.hansen@linux.intel.com; dan.j.williams@intel.com; kirill.shutemov@linux.intel.com; zhang.jia@linux.alibaba.com; schwidefsky@de.ibm.com; heiko.carstens@de.ibm.com; gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; x86@kernel.org; linux-s390@vger.kernel.org Subject: Re: [PATCH 1/3] arm64:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro On Tue, May 29, 2018 at 09:36:15PM +0800, nixiaoming wrote: > mark_rodata_ro is only called by the function mark_readonly when > CONFIG_STRICT_KERNEL_RWX=y, > if CONFIG_STRICT_KERNEL_RWX is not set > a compile warning may be triggered: unused function How are you achieving this configuration? In our Kconfig we select this unconditionally. Will