Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To:     Zeng Tao <prime.zeng@hisilicon.com>,
        "Minas.Harutyunyan@synopsys.com" <Minas.Harutyunyan@synopsys.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc2: gadget: fix missing process for isoc
 descriptor dma mode
Thread-Topic: [PATCH] usb: dwc2: gadget: fix missing process for isoc
 descriptor dma mode
Thread-Index: AQHT99RV+ygzxPGq9EKuFvTgIUAiiA==
Date:   Wed, 30 May 2018 07:16:36 +0000
Message-ID: <410670D7E743164D87FA6160E7907A56013A59784A@am04wembxa.internal.synopsys.com>
References: <1527681676-44003-1-git-send-email-prime.zeng@hisilicon.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Zeng Tao,=0A=
=0A=
On 5/30/2018 9:09 AM, Zeng Tao wrote:=0A=
> If it's the first request to queue, and we are using descriptor dma mode=
=0A=
> for isoc transfer, we only need to add the request to the queue, and it=
=0A=
> will be processed in the future nak interrupt handler.=0A=
> =0A=
> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>=0A=
> ---=0A=
>   drivers/usb/dwc2/gadget.c | 3 +++=0A=
>   1 file changed, 3 insertions(+)=0A=
> =0A=
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c=0A=
> index f0d9ccf..48e3a48c 100644=0A=
> --- a/drivers/usb/dwc2/gadget.c=0A=
> +++ b/drivers/usb/dwc2/gadget.c=0A=
> @@ -1365,6 +1365,9 @@ static int dwc2_hsotg_ep_queue(struct usb_ep *ep, s=
truct usb_request *req,=0A=
>   			return 0;=0A=
>   		}=0A=
>   =0A=
> +		if (using_desc_dma(hs))=0A=
> +			return 0;=0A=
> +=0A=
>   		/* Update current frame number value. */=0A=
>   		hs->frame_number =3D dwc2_hsotg_read_frameno(hs);=0A=
>   		while (dwc2_gadget_target_frame_elapsed(hs_ep)) {=0A=
> =0A=
=0A=
Actually it considered in "[PATCH] usb: dwc2: Change ISOC DDMA flow" =0A=
before checking is this request first or no:=0A=
=0A=
+	if (using_desc_dma(hs) && hs_ep->isochronous) {=0A=
+		if (hs_ep->target_frame !=3D TARGET_FRAME_INITIAL) {=0A=
+			dwc2_gadget_fill_isoc_desc(hs_ep, hs_req->req.dma,=0A=
+						   hs_req->req.length);=0A=
+		}=0A=
  		return 0;=0A=
  	}=0A=
=0A=
=0A=
Thanks,=0A=
Minas=0A=