Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4235279imm; Wed, 30 May 2018 01:31:02 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIDTLYnlWaHwl1ygbm7Eyj2+W0Cz4UyIwHdcYgSskXvT6I2LWhhyh7pmFJV8IYdhn8RmGhq X-Received: by 2002:a17:902:1e3:: with SMTP id b90-v6mr1863145plb.273.1527669062765; Wed, 30 May 2018 01:31:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527669062; cv=none; d=google.com; s=arc-20160816; b=IvnF5hokpoCNuYwrzkDjjs8LKoqTyvBd8JQibEXRMe9C8bxskaBLGd3b+EhAV5cbAw Q5/Fl1sc6/D8JLOJIhxpnMAeWmOxzqXZInH53+7vcnAfi/NZe47Lyhw+CF4Qj2PjEUSd EQ7+noDh9MVR4DJuEcaawTxK25/qgY41JCSQ1axEwjWskIu5OdAzD7wsWVgS1RdP+g2W PrsjrdSDo/me+JTUi6a5zuWFfk82Bg6NC87cd9yjbmrcDGFLU2Y02Zj22e08l3CE34kb 5iqjNkYFLeQOZuV4R7ninFxPzYz783P3++pU4J3SdyPN0obpjY54nuCqI5K8Fzvi+yV/ lslg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=ZXLBoztKZfE/QVO+C2zD5JVR2qYYBJ/BABPHFBl+8Zg=; b=nu9rZEnpAFgAR4/gkW26bIbwdPeic8iZAU1Ad6pVBe28UXFYZs0FlR8S9hZJG4KZAg IDbeHENw6F3tnffHoKHIjgODVMJnTvk8OpTxQWjn9oidyafw/ouennlhPqZmsGKqfhak HZMFSs6kugXZRyMlN5K8eaOSVqZIRG5RA7sqYwRJqo6tL6+lPPQ0eMW9kH0wWftjuyrK u678k4t7/QGoLUSKJ3SbImaZvMU2BPGvDVQCI3LcuqUTnuH33F7DqZZzKdyOb6SP4eyA uAKD4+UqACsqa+on5stDy2OT4NoNDP/XtqQ9Ap3vSlCBTeSaeSmFH5Tg1TItzHA1TZCK jVqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=Jj36XSsq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f66-v6si26937277pgc.391.2018.05.30.01.30.48; Wed, 30 May 2018 01:31:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=Jj36XSsq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937350AbeE3I26 (ORCPT + 99 others); Wed, 30 May 2018 04:28:58 -0400 Received: from mail-ot0-f196.google.com ([74.125.82.196]:34975 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935999AbeE3I2z (ORCPT ); Wed, 30 May 2018 04:28:55 -0400 Received: by mail-ot0-f196.google.com with SMTP id q17-v6so9607390otg.2 for ; Wed, 30 May 2018 01:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZXLBoztKZfE/QVO+C2zD5JVR2qYYBJ/BABPHFBl+8Zg=; b=Jj36XSsq1q+Kq7mvygoD1Ls3RqmMiWA2TVYwAncwU+9iJJLpG2dzbSccRUtiBbxzu0 yyqzy/37fGSWPRXepcOlkIUncgM05VNU4swOlDr9jkK+MbflCJTv4M+Cmbhn6sWP2bS7 xKY4SaAAEVihVzRt3eDjo1OZUiz2EbB2smRTY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZXLBoztKZfE/QVO+C2zD5JVR2qYYBJ/BABPHFBl+8Zg=; b=kRJppcKoh0inAYyZ+T30oclWNNqsWUhFHktccK9h5VbV2kjz/5lQLEA/6m5NyXO8s6 B+RI/0/8A/HO8WJNRNa4ZwKMFUYX/WFcGMWPU5NrQHpr6AaYRhUrGYZw+/gaCB7ArgF9 5PBhSI7ztHMA6Uzg8PDoyesDIetqXdOGcQqljj+YkmE5w/8qbvItd4YMulZgbtWbBXp0 TGWc7AoFjvUN+f99jbmmITDCKelQcpLAXFAKXb+aNe3zsS9+6QkmEVlG8hyVeCrxPwU0 ZAh+Qv9kRWjm35IHEbGjHTtxF2DfKpcS8yAHnAVWZqkUJYM/VciSeoTnKXDQyecq/TfS CHsA== X-Gm-Message-State: ALKqPwfG2yCu40Mi2Y8dXj47hjeOiiX47WPMacj0m6h60eGldY5QEAYB qmE7P6McVc5/zFzQWXAJAzvaO02EiQm6EGSN9OnuHw== X-Received: by 2002:a9d:1531:: with SMTP id u46-v6mr1161807otf.197.1527668934718; Wed, 30 May 2018 01:28:54 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:116f:0:0:0:0:0 with HTTP; Wed, 30 May 2018 01:28:54 -0700 (PDT) X-Originating-IP: [194.176.227.33] In-Reply-To: References: <20180529144143.16378-1-mszeredi@redhat.com> <20180529144143.16378-6-mszeredi@redhat.com> From: Miklos Szeredi Date: Wed, 30 May 2018 10:28:54 +0200 Message-ID: Subject: Re: [PATCH 05/11] ovl: return dentry from ovl_create_real() To: Amir Goldstein Cc: Miklos Szeredi , overlayfs , linux-fsdevel , linux-kernel , Al Viro Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 5:24 PM, Amir Goldstein wrote: > On Tue, May 29, 2018 at 5:41 PM, Miklos Szeredi wrote: >> From: Amir Goldstein >> >> Al Viro suggested to simplify callers of ovl_create_real() by >> returning the created dentry (or ERR_PTR) from ovl_create_real(). >> This prep patch makes Al's patch change less callers. >> >> Also used ovl_create_temp() in ovl_create_index() instead of calling >> ovl_do_mkdir() directly, so now all callers of ovl_do_mkdir() are routed >> through ovl_create_real(), which paves the way for Al's fix for non-hashed >> result from vfs_mkdir(). >> > > It's good that you split this patch from ovl_create_temp() patch, but > the commit message it utterly not related to the patch anymore and > possibly should retain Al's authorship cause there is no relic of my > work in this patch. Fixed headers and authorship assignments. Thanks, Miklos