Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4270216imm; Wed, 30 May 2018 02:21:05 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL8aFPGXuHFadG6e9FHUWb3kGIAV83Et4+7hNGl0lirlYl9LX1lbjjdXMpbmqMd2ODSzrys X-Received: by 2002:a62:578e:: with SMTP id i14-v6mr2030266pfj.119.1527672065443; Wed, 30 May 2018 02:21:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527672065; cv=none; d=google.com; s=arc-20160816; b=WgctnO6QMJ4KuilSYZ6LQGxFmjRCxxFQGGmXwPC9e1Q/iswVlIKKP1FUtFDRtbPxdo qKZGY3TYNmUtt4T2MygYiC+3bOSDx5dozYfifcSjwWXz6uXeBHNI0mcu0YBVamxCa5nr 76N4AlfHJ+oBIVQieUifWalNtQcwegje8Av05TaQMmHkicJQomXgRbeC0dtd9GER+FHm BQEz7w3tvs42IPJWfJRH3t7kGwswWsqKr4PX+9Te7yhlEknzJ4+QQyBwEAWUPyLOa46b iQT6o6LwT6nQTprGce8/GlUreyw7Axkirsfg3nssVNhmXoqMEcmQuSJ3qqnkbvtStd1i lCPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=+mvuYPeuK/drqT4mS+4QcMVOKqsXzYRd2kcDbx8k0AY=; b=LoXsmtUfY+rmOBB4mgs9F90m59ezPeFJu+h/AsLzNB4ySQLVmE9TE00RfQjLy/y9zU R2VgibKlL34QZoFlvfSoan6PMWEeAgUgXpfPmHMQkqypTlelYo6HrzeUxRg1wZqSXDh3 /o6BhFAqbFGxHob0LzKYaESuN3j6fPNRj2ZpFEgKZkWB3pXazx9V9uin5bgemBCSjngx IIxqWrg1k6HEd2TL6mmpCujzOZxDn4+rM5qOC8h5di1ODmdUmkCOO8TN9RC5FoypavrK OjtK4aZcLDjt2FEph36PRaGYWnx0rIlQPuNOb0knZlbZBQ3mByl2l+J4AMzOkmsf6jAe o2YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=dFPpQ3Wc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o87-v6si9957294pfi.295.2018.05.30.02.20.51; Wed, 30 May 2018 02:21:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=dFPpQ3Wc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968807AbeE3JUG (ORCPT + 99 others); Wed, 30 May 2018 05:20:06 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:55994 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965167AbeE3JUD (ORCPT ); Wed, 30 May 2018 05:20:03 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4U9GB68150194; Wed, 30 May 2018 09:19:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=+mvuYPeuK/drqT4mS+4QcMVOKqsXzYRd2kcDbx8k0AY=; b=dFPpQ3WcRmFBUk15NHuLsC6D9BA1SbCxzZmjuuvBJ7FwDq5hF62snMNS3crHtBUxZhU0 uzguxLKuGkAs2MzvRgjUrIYcbdVdy3eixr+/4I7N8OAr9ACI2SDDfNsZK+o5AJy0Gn6n gXjyrNkdxKfJLISjLUczcUin+PxVDsMsGAJjqlDN7iwV4pyoY+K/Yrt5wHOBTgjt7idm cA0qqCoJL1s0VKMrJ+7vavKlPCcKGh3MOy+SzoH1IffqVdR38WMQ6xCQaQp62XvYwGrf JSAMagwToB+SyS0agbGJjOqUcrdGzkNyvP9xmS8EzCMvAPlrgEdf7fXvowisngXIZV5F qA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2j9ev81jd5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 May 2018 09:19:58 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4U9Jv72009706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 May 2018 09:19:57 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w4U9JvUu015056; Wed, 30 May 2018 09:19:57 GMT Received: from [10.182.70.180] (/10.182.70.180) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 May 2018 02:19:57 -0700 Subject: Re: [PATCH] block: kyber: make kyber more friendly with merging To: Ming Lei Cc: Omar Sandoval , Jens Axboe , linux-block , Linux Kernel Mailing List References: <1527000509-2619-1-git-send-email-jianchao.w.wang@oracle.com> <20180522200214.GF9536@vader> From: "jianchao.wang" Message-ID: <08921b9d-0f31-f31d-096f-6c4f3a1e4d4f@oracle.com> Date: Wed, 30 May 2018 17:20:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8908 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=502 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1805300108 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi ming On 05/30/2018 05:13 PM, Ming Lei wrote: >> Yes, it maybe good for merging of 'none', because the rq_list is split into 3 >> lists, and not need to iterate the whole rq_list any more. >> But what's about the dispatch when there is no io scheduler. > blk_mq_flush_busy_ctxs() and blk_mq_dequeue_from_ctx() should work > fine in case of 'none' if per-domain list is added to ctx. Then we can make > none to be a bit fair on READ/WRITE. > But how to determine when to dispatch READ, WRITE or other more, when there is no io scheduler ? Thanks Jianchao