Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4302305imm; Wed, 30 May 2018 03:06:48 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJMZClhLEMN0Zsa2BLI0YM5vS9qc/2OOO2YaTquitXEUYX+d7Pekf/jpYFT/7WQn0sxDB0p X-Received: by 2002:a17:902:622:: with SMTP id 31-v6mr2215908plg.135.1527674808801; Wed, 30 May 2018 03:06:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527674808; cv=none; d=google.com; s=arc-20160816; b=KDjx3D4+L7hReWoGgx2KygpD1uNjZqqsdKCFi2XE5mQwrpzTM5Bhzs3SPXMh+QwLAs 107TKMwmTURGfMqvOwVDVmVHqwjWUpGCIAEXUqNTKCRQaNz7i2pTgGWoZ7qSyyigSq6P ZIEc3B15Y/4mN410woBKd/PwSfkmoJJ6QWBlfvKRXYo9zPD1wt+b8FJSiPyygAKTsXB4 H6PJO7q8WlKLPB9WSNHoyrt1glTUSNzTtIRvygi95FdnfwGO8M1y+34NmVhYxD7AzKYL 4rHwNpXTXifIitsBJCg/wwsJ05opfxghd3KyGbEF/LjsWUgjI5srEps7d7qM8XzTZIJR WgFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=6eEpV8P3G9g/8LrUlsg1Tf+jzI6MexBRObmQMxBRZSQ=; b=OFX921fTq7My2dYoVPgtijwqdn01d3QcecDSyx6zQqUFhby8g1oaVO5zJ2l5X3XMyJ +7/Hzo6OfEkt3bQaAkWcAg4zkhYR/E0GcapEOXhTGU7XI2w50wyVjGm8esCA1Dj2bRJs ssTzgrlXeK3PXrQ+c3s0BGWKLK9PHF7ndvJuRdX7qEkIG53riFdBlVu5ZASiXDOfgEWN BEacOLfubmlatv+Abl3mBeYVtT43ZnnxwYtOxraTjfZaT3QbjtmpbKhu2eO1gDsJj3OD Sr1sgRDypP4S1UJ/pe+dzStAXZ0ZDbAR0OUTowInor+K+mGxuUs6+LL5GW2lZblbEbCZ QsSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=ca+6rlaM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w23-v6si18490831ply.563.2018.05.30.03.06.34; Wed, 30 May 2018 03:06:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=ca+6rlaM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751348AbeE3KGK (ORCPT + 99 others); Wed, 30 May 2018 06:06:10 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:55686 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbeE3KGI (ORCPT ); Wed, 30 May 2018 06:06:08 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4UA1DR9167968; Wed, 30 May 2018 10:05:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=6eEpV8P3G9g/8LrUlsg1Tf+jzI6MexBRObmQMxBRZSQ=; b=ca+6rlaMnUXyTDIUMl7hz9kXqiUK90RYG4/DJxRTfIvxCjLwrU/tgTUrHo36PrtHSv4g rUFxQQ0WTCpULlxNXRIBMgx0Uu1lGYs8eobWTEFynyirAY6Wh10PtzjnBBGzbcc9kg6q jzMJvi2dlSjVO1WZ+Mr6cljxCXQPlw/awSwc0A/5xCMB0+6Rx++RVrAZMrFIZ10oyVF0 IX20DDKQ3+d/3S0KvZB1DczShgAtiMXsBp5JpQK6tNord/5lJNMs7cfxEmyAJ2gqQ0SR wm3QyByEqwfCC44sZURhB1Z4na69Z/UoCCy9GJ2EuMMK2TVk2ZBbocJZMmz8fIZEY7+r Tw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2j9ev89qap-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 May 2018 10:05:43 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4UA5grg003674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 May 2018 10:05:42 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4UA5eLj006796; Wed, 30 May 2018 10:05:40 GMT Received: from mwanda (/197.157.0.20) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 May 2018 03:05:39 -0700 Date: Wed, 30 May 2018 13:05:29 +0300 From: Dan Carpenter To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , NeilBrown , Amir Shehata , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling Message-ID: <20180530100529.54jlkfx2q52d7o2a@mwanda> References: <1527603725-30560-1-git-send-email-jsimmons@infradead.org> <1527603725-30560-2-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527603725-30560-2-git-send-email-jsimmons@infradead.org> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8908 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=748 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1805300117 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 10:21:41AM -0400, James Simmons wrote: > @@ -208,20 +222,52 @@ void cfs_cpt_unset_nodemask(struct cfs_cpt_table *cptab, > void cfs_cpu_fini(void); > > #else /* !CONFIG_SMP */ > -struct cfs_cpt_table; > -#define cfs_cpt_tab ((struct cfs_cpt_table *)NULL) > > -static inline cpumask_var_t * > -cfs_cpt_cpumask(struct cfs_cpt_table *cptab, int cpt) > +static inline void cfs_cpt_table_free(struct cfs_cpt_table *cptab) > { > - return NULL; > + kfree(cptab); > } This should free cptab->ctb_cpumask? regards, dan carpenter