Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4343433imm;
        Wed, 30 May 2018 04:00:51 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKLpk+xZ5HLYN0Asm5rtIbFM/9PO3i9VphgbqIQ3Zb4ltIvJViSbliFJxgHaTNVKslDWCXjt
X-Received: by 2002:a63:7a11:: with SMTP id v17-v6mr1836393pgc.97.1527678051179;
        Wed, 30 May 2018 04:00:51 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1527678051; cv=none;
        d=google.com; s=arc-20160816;
        b=eGayhhsJKJ8megXC0sJgTtOkNyJi4+j9lgDUvVb4I+W0HAYB5h2olKwgyNSABU5fKu
         R6KCh8fKZPXPun5yyzWoc4v6IY1BFX9EhFj0A0j+f9/oDbI/jANgMRTpg2m0OgW62WOw
         yIRiGDL5lA5pDvrKDN79aBfQ48sJiRNoK/G1+YuqKwA2Orua0VPJdIcK/iSGjX43oYLW
         oFnIIi9xz53icpECzskulfdrBh6gUotFaIO3lbvuOnkg2gtOeugGCmcVGrpFE+yS2FfN
         g4JCf1qfyZR5QkNJ04x7PJ/QfF/c73GGMqM6xAV02QMDEAsTpsyngfuW+iIBTxKvul/L
         TD4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:in-reply-to
         :mime-version:user-agent:date:message-id:from:cc:references:to
         :subject:arc-authentication-results;
        bh=xyB0jvDa5H2bGHaAdCz8rzU0zOA7+mPfVIUfIpwGUEE=;
        b=iz8ue24nYtl903CiEr204TnG5EN0Ad5N/MR0UTqjx1fA2Tch2tmdAPdqc+m3zl8rAn
         f2WJH0Gxe6MbRfkZRIrGsOWx6V8+2m1Xk0rzKwXuvfE66b58BOSF+n1S6jQKnJGPgG2q
         YAGJwDgWXiDJ3w4pAfJvGDnUlsYe4rvIPKm6c4aLY+nN5+WxBnaO9UjTPjiQwxWpGoLh
         E/9RP8Z0bvM19OSM7wW9zurdYf+2ZPKqQD5qousaYVJq3/kXUG0+aF266Ge11Jl8rfIX
         CST6i3rFbt2UbF5DTwrwwYfLze73PCkx4zT05x9kiCNedvY0FdT5VugvFUb+uWhRqxe8
         5xMg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 1-v6si33617509plr.483.2018.05.30.04.00.36;
        Wed, 30 May 2018 04:00:51 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751967AbeE3LAA (ORCPT <rfc822;fezhang.suse@gmail.com>
        + 99 others); Wed, 30 May 2018 07:00:00 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:11800 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751479AbeE3K75 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 May 2018 06:59:57 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b0e842b0000>; Wed, 30 May 2018 03:59:55 -0700
Received: from HQMAIL104.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 30 May 2018 04:00:00 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 30 May 2018 04:00:00 -0700
Received: from BGMAIL102.nvidia.com (10.25.59.11) by HQMAIL104.nvidia.com
 (172.18.146.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 30 May
 2018 10:59:54 +0000
Received: from [10.19.64.176] (10.19.64.176) by bgmail102.nvidia.com
 (10.25.59.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 30 May
 2018 10:59:49 +0000
Subject: Re: [PATCH v1] i2c: tegra: Remove suspend-resume
To:     Wolfram Sang <wsa@the-dreams.de>,
        Dmitry Osipenko <digetx@gmail.com>
References: <20180513211347.7187-1-digetx@gmail.com>
 <20180514115933.GH18312@ulmo>
 <d83fc1f7-d5e5-4211-1cd8-babcabdd9c4b@nvidia.com>
 <5949e650-8ab5-b4bb-196d-5a0705383141@gmail.com>
 <20180529180659.f5s56nstykztvykr@ninjato>
CC:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Shardar Shariff Md <smohammed@nvidia.com>,
        <linux-tegra@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
From:   Laxman Dewangan <ldewangan@nvidia.com>
Message-ID: <7b93f6b0-0e09-d8e0-b48e-4ef518c3bd9f@nvidia.com>
Date:   Wed, 30 May 2018 16:29:45 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20180529180659.f5s56nstykztvykr@ninjato>
X-Originating-IP: [10.19.64.176]
X-ClientProxiedBy: DRBGMAIL102.nvidia.com (10.18.16.21) To
 bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Tuesday 29 May 2018 11:36 PM, Wolfram Sang wrote:
>>> Our I2C driver is based on the interrupt. So we have converted the
>>> suspend/resume to suspend_noirq and reseume_noirq so that we will not allow the
>>> transfer when system interrupt disabled in downstream.
>>>            SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(tegra_i2c_suspend, tegra_i2c_resume)
>>>
>>> In shutdown path, where interrupt disabled and still need i2c, we use the
>>> bit-bang method via GPIO for i2c transfer.
>> In the current upstream kernel suspend/resume can't be simply moved to the
>> 'noirq' stage because resume invokes tegra_i2c_init() which uses runtime PM and
>> that doesn't work with the IRQ's being disabled. But things do not work even
>> with the tegra_i2c_init() changed to work with the disabled IRQ's, like I wrote
>> above the I2C transfer fails (due to timeout) and a "fix" for that failure was
>> to remove reset_control_assert/deassert from the tegra_i2c_init(). So I'd go for
>> a complete suspend/resume removal for now as it is causes problem.
> Laxman, are you convinced or do you have still objections?
Fine with me. Please add my Ack

Acked-by: Laxman Dewangan <ldewangan@nvidia.com>