Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4365637imm; Wed, 30 May 2018 04:25:23 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKhc9t5x76NpvjVCp8nsfYL1GEX3+wH76D2/Udyy4dfajef9dTVSdg2vnKiGvInT+URG52i X-Received: by 2002:a17:902:8a81:: with SMTP id p1-v6mr2521718plo.33.1527679523001; Wed, 30 May 2018 04:25:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527679522; cv=none; d=google.com; s=arc-20160816; b=Gfjo75fwQhw+1qHPLeEvKSQdTmmzwHDic9fcq0MPCTWrSKI4RR3jZGQn6jN2ufaUl8 ysM7timUUylmQxYf9qDU4WXwuEnUmUN6yIyT5MtG/3XNnH0W0oUouCFcKc2gmge+gI01 zsx98IHO3qICXOCfWU9qOaTzEOXmkiA81UEos1OWOHk2Hlsjrf1gziGchxSZjNqhy+iN CVn0Ovk9pDdGLjpbPoQGu4j8wJUsRo1O86ESti3VpnDPmnFvfm8Jdh7geLCKJNVqx/Kl RnmPRBE6ZfqZOGFixws/5vT0c+rWI1433aNinL2soDjkAId4k8xJxRGDZp5mEBaFLTv4 uE1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=oYA8UcXQEsmb60erm6F0OsIHiu9vl8KEKxJgqYoKoZk=; b=kISp6CDPh4HE5oIwNBbhOZFTeW06uQuK7ST6tFtLM8N+XwbQCZRF6Vt1DUIpMmPxbN 5eNb+JK922jBKsQVGAUhsjrTBSWPaj5ONOqVHfrDdAa/o+sDBV9mqTAXuYrGYkbwzShz Ko1t2r6cqiKFjyj5gKZ2n2AglWN4My5RomzUQMSFnArqUvmoCTLS0LGYjYjN9rUNo80h qOfyDlgOAkOnb73XzAnEmdJF8tP9odQuZerOLAzgEZjzF/41OxDtwscmKQvuKumgVV0i rYVYSJKMpH1cOX11zShuiiKkQftbZn8+zxwVxjCtajRH8bU9pKhs5rk3Ej3IaH0b2tmc ZfPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HuiGinML; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k24-v6si7782746pls.330.2018.05.30.04.25.08; Wed, 30 May 2018 04:25:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HuiGinML; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752839AbeE3LTy (ORCPT + 99 others); Wed, 30 May 2018 07:19:54 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37340 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752572AbeE3LQr (ORCPT ); Wed, 30 May 2018 07:16:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oYA8UcXQEsmb60erm6F0OsIHiu9vl8KEKxJgqYoKoZk=; b=HuiGinMLiOlUPThGbIAUZOg/r E0zxojnFWxu25V1U1Z9BbLpmM4mK0kwbITnoY1QxnfNm0Pa3CCOWC1YW+fPc3e3I4mvGhXTNXiRlw y3C8iCN2l4/wqi8e4YLAtOntaiZKFdUl8tlKJIukZ2Kuu/sNpfUGDWDwqusOKbr7JladtfswsC/Wz feP4QWoKevTCfwcvwBINXRUd47CR87RPGWAMTg/WVFztoaBjxR9W2PNf8x5oONLZcfQuhdU8t8Qt2 q+Q2fhcvXhj0fJ3RdmiD59omj4hfguzAWnMDd8zQsZEKCN5cMA9HDcxIFnMrZ3GvDMi84G3dN6Z1D TWP5rMSpg==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNz5G-0008CD-Fc; Wed, 30 May 2018 11:16:02 +0000 Date: Wed, 30 May 2018 04:16:02 -0700 From: Matthew Wilcox To: Souptick Joarder Cc: Al Viro , Hugh Dickins , Andrew Morton , Michal Hocko , Ross Zwisler , zi.yan@cs.rutgers.edu, "Kirill A. Shutemov" , Dan Williams , Greg KH , Mark Rutland , riel@redhat.com, pasha.tatashin@oracle.com, jschoenh@amazon.de, Kate Stewart , David Rientjes , tglx@linutronix.de, Peter Zijlstra , Mel Gorman , yang.s@alibaba-inc.com, Minchan Kim , linux-fsdevel , linux-kernel@vger.kernel.org, Linux-MM Subject: Re: [PATCH] mm: Change return type to vm_fault_t Message-ID: <20180530111602.GB17450@bombadil.infradead.org> References: <20180529143126.GA19698@jordon-HP-15-Notebook-PC> <20180529145055.GA15148@bombadil.infradead.org> <20180529173445.GD15148@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 09:10:47AM +0530, Souptick Joarder wrote: > On Tue, May 29, 2018 at 11:04 PM, Matthew Wilcox wrote: > > I see: > > > > mm/gup.c:817:15: warning: invalid assignment: |= > > mm/gup.c:817:15: left side has type int > > mm/gup.c:817:15: right side has type restricted vm_fault_t > > > > are you building with 'c=2' or 'C=2'? > > Building with C=2. > Do I need to enable any separate FLAG ? Nope. Here's what I have: willy@bobo:~/kernel/souptick$ make C=2 mm/gup.o CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CHECK arch/x86/purgatory/purgatory.c CHECK arch/x86/purgatory/sha256.c CHECK arch/x86/purgatory/string.c arch/x86/purgatory/../boot/string.c:134:6: warning: symbol 'simple_strtol' was not declared. Should it be static? CHK include/generated/bounds.h CHK include/generated/timeconst.h CHK include/generated/asm-offsets.h CALL scripts/checksyscalls.sh DESCEND objtool CHECK scripts/mod/empty.c CHK scripts/mod/devicetable-offsets.h CHECK mm/gup.c mm/gup.c:817:15: warning: invalid assignment: |= mm/gup.c:817:15: left side has type int mm/gup.c:817:15: right side has type restricted vm_fault_t CC mm/gup.o