Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4407519imm; Wed, 30 May 2018 05:13:51 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKbiZlHqrlXqFa3oITx8OMGvhPVLj6ScIzFuRosiLUHjsdI2Aw/ZMVKsYuTiGmT4gOpNFaH X-Received: by 2002:aa7:8551:: with SMTP id y17-v6mr2500247pfn.163.1527682431141; Wed, 30 May 2018 05:13:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527682431; cv=none; d=google.com; s=arc-20160816; b=yDQSzhOwppjzi3JsFg43aJj2d+oUOvB1plFpIPRakyCujvMcJzS2UsGU8XcVrgbviN WiPe3mRXscRH7TVsm2/Xu3qXXsGeWM5/Qr/kxksC/CI/irADWBjSRNBECuFUvzuuYkS9 kVykDTpbkbLbH1JSWfwlPaml4X34bBrLgJzrUdiNkCD+KlIPMykNWer3LGkLPvxlEkKu +eAt0C/Vui6rud3BI6mHjVaoskln+tPyr/uCRZgfZyiU7z5wFJNT5lcFFJ64ufsS5JCe QMhGcgX17nIyMkOSU2RUMoptt/zHd0dNuXrASoeGKpvC+zXjXp8nBD+BwuotDOVDkGdq AGBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=hgj6acVmPzLSZEujLy4My2hEwGg+bma8qrLe6EHmPVU=; b=w4xIDgMiDbGnrg0YpkWJOXR6obsOja0B/+SKGhUYQsOBFVMR2k5Bbj7V/5mrotW9qE /4on+AnyRSzImnPupqhfXPqrfMzuIhJOrK0GxBOrQ5BmbwGBiRz3Npa72VERiILiH3YA jIKImeaLHYeoXBVh5WkVAZOsC9OBuq6KZV9bHzAJiqgjeH9wBTtVgjOxBKj4O1w11VPv SCjsxamslNKSbkelttt7tAToXOygL4Ew7MS7gqT8i4zQ3aCUs6uHVH9JR2SbzOS5wx3O 1g1r75nkicZORgzryaj2IpEOvpfeJ2sh2eY2Lc6cIl1SvRs/K1C8L9bPyXTEmldvs2od 9UXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ms5cqDg/; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ms5cqDg/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p84-v6si34516393pfa.180.2018.05.30.05.13.35; Wed, 30 May 2018 05:13:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ms5cqDg/; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ms5cqDg/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbeE3MKo (ORCPT + 99 others); Wed, 30 May 2018 08:10:44 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52354 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbeE3MKn (ORCPT ); Wed, 30 May 2018 08:10:43 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B2B2A6060A; Wed, 30 May 2018 12:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527682242; bh=VbIQjn6VYnhOuPHypXU6OISf0Xjd/qod9Obi2gUlFm0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Ms5cqDg/MYNKK26EhJok5L6Va6l9dPI1ADaGjt7pQsfPN9sVG5GTieI0q4OXvo8DW 2mLu49o2hPSnJGCD74GDaheKO7iHxsz+s68YK/sh8UyBPlR76tYJP87DCBkrnGCfUW WyBCFGRZP5PDn+DwrQo4cKDNpUCKVuvivTcxF4zQ= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.1.125] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: timur@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DC0F260251; Wed, 30 May 2018 12:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527682242; bh=VbIQjn6VYnhOuPHypXU6OISf0Xjd/qod9Obi2gUlFm0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Ms5cqDg/MYNKK26EhJok5L6Va6l9dPI1ADaGjt7pQsfPN9sVG5GTieI0q4OXvo8DW 2mLu49o2hPSnJGCD74GDaheKO7iHxsz+s68YK/sh8UyBPlR76tYJP87DCBkrnGCfUW WyBCFGRZP5PDn+DwrQo4cKDNpUCKVuvivTcxF4zQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DC0F260251 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH net-next] net: qcom/emac: fix unused variable To: YueHaibing , davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180529104343.19448-1-yuehaibing@huawei.com> From: Timur Tabi Message-ID: <0db547d4-27c1-a9f7-f443-86bebd831cb2@codeaurora.org> Date: Wed, 30 May 2018 07:10:40 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180529104343.19448-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/29/18 5:43 AM, YueHaibing wrote: > When CONFIG_ACPI isn't set, variable qdf2400_ops/qdf2432_ops isn't used. > drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:284:25: warning: ‘qdf2400_ops’ defined but not used [-Wunused-variable] > static struct sgmii_ops qdf2400_ops = { > ^~~~~~~~~~~ > drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:276:25: warning: ‘qdf2432_ops’ defined but not used [-Wunused-variable] > static struct sgmii_ops qdf2432_ops = { > ^~~~~~~~~~~ > > Move the declaration and functions inside the CONFIG_ACPI ifdef > to fix the warning. > Signed-off-by: YueHaibing I already fixed this with: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=d377df784178bf5b0a39e75dc8b1ee86e1abb3f6 -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.