Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 30 May 2018 10:40:40 -0400
From:   Sean Paul <seanpaul@chromium.org>
To:     Lowry Li <lowry.li@arm.com>
Cc:     liviu.dudau@arm.com, gustavo@padovan.org,
        maarten.lankhorst@linux.intel.com, daniel.vetter@intel.com,
        jani.nikula@linux.intel.com, seanpaul@chromium.org,
        airlied@linux.ie, ville.syrjala@linux.intel.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        brian.starkey@arm.com, malidp@foss.arm.com, nd@arm.com
Subject: Re: [PATCH v2 0/2] drm/blend: Add per-plane pixel blend mode property
Message-ID: <20180530144040.GM3373@art_vandelay>
References: <1527679434-13228-1-git-send-email-lowry.li@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1527679434-13228-1-git-send-email-lowry.li@arm.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 30, 2018 at 07:23:52PM +0800, Lowry Li wrote:
> Hi,
> 
> This serie aims at adding the support for pixel blend modes represent the
> alpha blending equation selection in the driver. It also introduces to use
> it in the malidp driver.
> 
> Let me know what you think,

Hi Lowry,
Thank you for doing this work. I know this is something that is missing for
proper Android support, so it's most welcome.

Do you have userspace patches using this property?

Sean


> Lowry
> 
> Changes for v2:
>  - Moves the blending equation into the DOC comment
>  - Refines the comments of drm_plane_create_blend_mode_property to not
>    enumerate the #defines, but instead the string values
>  - Uses fg.* instead of pixel.* and plane_alpha instead of plane.alpha
>  - Introduces to use it in the malidp driver, which depends on the plane
>    alpha patch
> 
> Changes from v1:
>  - v1 is just the core changes to request for commments
>  - Adds a pixel_blend_mode to drm_plane_state and a blend_mode_property to
>    drm_plane, and related support functions
>  - Defines three blend modes in drm_blend.h
>  - Rebased on current drm-next
> 
> Lowry Li (2):
>   drm/blend: Add per-plane pixel blend mode property
>   drm/mali-dp: Implement plane alpha and pixel blend on malidp
> 
>  drivers/gpu/drm/arm/malidp_planes.c |  76 ++++++++++++++-----------
>  drivers/gpu/drm/drm_atomic.c        |   4 ++
>  drivers/gpu/drm/drm_atomic_helper.c |   1 +
>  drivers/gpu/drm/drm_blend.c         | 110 ++++++++++++++++++++++++++++++++++++
>  include/drm/drm_blend.h             |   6 ++
>  include/drm/drm_plane.h             |   6 ++
>  6 files changed, 171 insertions(+), 32 deletions(-)
> 
> -- 
> 1.9.1
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS