Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4581695imm; Wed, 30 May 2018 08:11:21 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIMA+fLxI3mP0UXkjerGH5Ql9/o4xKEy3lNwqXwam0RAoXpkCnqQ+t73NmR4u5xlM+VAQ5J X-Received: by 2002:a17:902:7244:: with SMTP id c4-v6mr3211457pll.265.1527693081578; Wed, 30 May 2018 08:11:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527693081; cv=none; d=google.com; s=arc-20160816; b=cAWkuhsVaf48WF50XoTVUNn4k3gfghnecBmDOPMmpshOd+ee84N4Dc4QmOsdtv+ItD bJgLiois21b8mR6/kascuD53U8bFJtfvs64BG228GGgft6GUkRUA38ACAPHAW/sUE+Yr jVCpbVpQo+khh77mv2Ohq0zUGZth89C8X0cY6NGvQe+eguMiNeRN9668sXFt5TZE1WzR CyD6rZZCXLZK6X2Caty3VenzvCwJ6+2smOUb6dI4z5EGecdOcJ9k7f6pIveH6iF4Ghwz pG3y18eR4sCZJOnYFlTOTtHxkusW7oh7IMusuMasw0VK9ti8WEr/wUkkOMej6cozGf3+ lLTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=mOguLMT9cKzpdezygqNcCuM/e6daSq7JlUKWOm3KZhE=; b=a8Uy1FQosazZuODltEdl2SVKUi+xODTD/NCyxdW3rMeIEIaLUARj+9NoHD/n+798jr FVZuWpDDIoQucEAL7R1FSqM+sSXNfc7M+7hckx6/EEaGjXlCtBb04G/KlZD6e+mGZEtO X8AOcu1R+p1/Tw/doetEoKDVYL1h7XQcgbzy4iLX8iNydmFmCfxCPd6x2QiDA/OZ2QKR RpnZ/9Mj2Pvllo5/dn1/FkvM7b0uEnRV4x0cK48oz/k6CJA087D8QWG/IDSKUbegYzCb 1hcwj8Sng0am8XPEkadeHfDyuJ/JDisxO1OqMQQbS43aAjP4G84OQ7ni3TsIvyMMfiam rIag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=J0ZMPXju; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t9-v6si15797716pgf.359.2018.05.30.08.11.04; Wed, 30 May 2018 08:11:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=J0ZMPXju; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753808AbeE3PKm (ORCPT + 99 others); Wed, 30 May 2018 11:10:42 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:35655 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753632AbeE3PK0 (ORCPT ); Wed, 30 May 2018 11:10:26 -0400 Received: by mail-pl0-f67.google.com with SMTP id i5-v6so11269879plt.2 for ; Wed, 30 May 2018 08:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mOguLMT9cKzpdezygqNcCuM/e6daSq7JlUKWOm3KZhE=; b=J0ZMPXjuY89QVU28OJtoP1dUUViLDXMU8i1YixO36WSMmoQc0kxMxJ1zbK37kvLtSX WRFtwFwEtEmS2Qf3q13I5FYUXauaJXfmhjYg0hehhNhAEV1gYjemr8hxLs3bbV+kmBox 1vEP5Tc++zBj9Ecu2CbD1a+DEYIItDpGArPf6arAwSQGflsqjSjlmkv1EbcCHZWlze8Q P1e8YusXSp1+b0JQuPLJiOaf+K6McDGmkroRrPTlgqeQsibvA7ayp9P/gQhVLnvVWscL 8wbgd2fQzx+l4rIAwmNrEu3V7X/2vgeX/YlF6pzkPJTDlYQfIMaa/coe1CBOMYqJNWSb 9fyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mOguLMT9cKzpdezygqNcCuM/e6daSq7JlUKWOm3KZhE=; b=iCGDp9KqOVQwvvfq2Zu+jVEGVNiHnWKfxv8UKj3NfRqU2uJ5Pa+L4q2Kx3pkPa/+rC JK0gcxVK7dsVvusYUZJjFunEwGeE4XDvsmJUwnWkh4p1SuT+7GINt/M4Rsth2YcPPqCo 88OII8COplergcCB/iHd2eGaQ8nhuliMOb+5bf6wW91wEv6WLwa8/A4SFktu8YZ0yoc5 Wz4cxZV08/rXnoDXnziRIZyFhqolfxBkB30VBwls+W8IKGTJNGZLlKHJRCnLA5t4f6h+ uGQVTRBbOucls3IsRigp6TyDgQdWeBUdQ7aIjoB+N3Q2x6Pk7C1Fl5hxijFkGJ9inCWh MOdg== X-Gm-Message-State: ALKqPwcNAR15p8LxYhJ46DzNPZvarHVQlR0mqPSl/TCgpglv1VBezdcH 5DKTbmTw/x+7YOTc6c1lvp7+8g== X-Received: by 2002:a17:902:265:: with SMTP id 92-v6mr3148825plc.368.1527693025048; Wed, 30 May 2018 08:10:25 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id p16-v6sm17474982pfd.47.2018.05.30.08.10.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 May 2018 08:10:24 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1fO2k3-0008B1-PQ; Wed, 30 May 2018 09:10:23 -0600 Date: Wed, 30 May 2018 09:10:23 -0600 From: Jason Gunthorpe To: Hans Westgaard Ry Cc: jackm , =?utf-8?B?SMOla29u?= Bugge , Doug Ledford , Daniel Jurgens , Parav Pandit , Pravin Shedge , OFED mailing list , linux-kernel@vger.kernel.org, Leon Romanovsky Subject: Re: [PATCH] IB/mad: Use ID allocator routines to allocate agent number Message-ID: <20180530151023.GB30754@ziepe.ca> References: <20180529073808.27735-1-hans.westgaard.ry@oracle.com> <20180529154922.GA18457@ziepe.ca> <20180529164032.GB18457@ziepe.ca> <20180530110216.00000913@dev.mellanox.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 02:22:56PM +0200, Hans Westgaard Ry wrote: > We came up with this code snippet which we think handles both preventing > immediate re-use and too big/wrapping... Isn't this basically the same as idr_alloc_cyclic ? Jason