Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4623774imm; Wed, 30 May 2018 08:55:08 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIs19u2iVPNM6CxYjZdrAvQwehiJkMVuYin4ZwqIB/DaUcRGViq6hMCzxbFbZgHxU6X5lry X-Received: by 2002:a62:f80c:: with SMTP id d12-v6mr3299653pfh.159.1527695708947; Wed, 30 May 2018 08:55:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527695708; cv=none; d=google.com; s=arc-20160816; b=RFxmzQxBapZuQ3ZxBPZbOz1ubxLSeB+DppBrIRmW7zvYOwjUWFWbnmu44du288hcLd a5b1CokqL6nsbteAlYozGuWSvdF7FMLRLyxlUgQSvK5lJl5J/vawR5lky8kZA6tYTkPM c+xdk0cU7327/lkEro0xtjdGY2C/MOZ19AZ4qtJtnpX50M+LZSY2QAgpdV83ReuBkUzH WupS2EalhczxkuaX+h+s70yKKIMsWucrPBSx79gyeB2PeIPCXSkxjGLJbGRjRJoQXGRa mBM0O9kuI80F1SjbGKpxqnrjWavjrkjhdGeGey2OoN6eLBOc0D+ZxaF/gPYu45ommE3G d9OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=nTtFo7Ey6iTFDFnCQKapfNWThuL3kGTF17ttTeec0O0=; b=y2AEdBOMQttGt+IQlNfvayW4iXsn7ZzIMQoNIwK8T3knfRYSo3dJgOk+AfSJWfLHf/ hGuaYPUDJFrG3mY9GCUxxZpD6G0QlwLchwQbf1LjaCmA6nez8zPU9RnzbHUoZWyV0sdh c9aBITco6/a6a8L6HkxFo+99xCQR9MmPllyDusYFtX0adTzF6eFXOdzSTThwu3gIsGZh DxCVzxuIGSDqv/ci+ADaZojWoNh31BI+yFBCMxoCQpgA4tXj2xwAOIslmxd8cqd6xcNz gunnbbxXa19xGOOc161X6p9sdK5QBpiDTHx0jh/MexjlH480H7ychBhtM9fNE4+A0jiG q6bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ikIoTV7r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3-v6si34359314pld.116.2018.05.30.08.54.54; Wed, 30 May 2018 08:55:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ikIoTV7r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbeE3PxY (ORCPT + 99 others); Wed, 30 May 2018 11:53:24 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:46446 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbeE3PxW (ORCPT ); Wed, 30 May 2018 11:53:22 -0400 Received: by mail-yb0-f195.google.com with SMTP id p22-v6so6517535yba.13; Wed, 30 May 2018 08:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nTtFo7Ey6iTFDFnCQKapfNWThuL3kGTF17ttTeec0O0=; b=ikIoTV7r1NJp/C/2isNvJFD3tKa/WvIAxB++ZmfDkKDYSPBsIgE/MzpEPmyyDntD/8 ZnkEekYdanzNNza7TmqJuID2+h88F40EIcAByBpFJx0lC+y2pFQxg4lAjZT9XJTVxJxA e6eeM56uYN0s3wWHCL7NL0WBN0CRRPjSqWTbbFS6pZdNBCKjHDexw3qhDur2Xl/KsSO4 KlTgUazWXC8esrKoGnF/LJtQmUVlK/KsRpM3t1/BUUVyuBKkKwKopby4Nzo9Obo/3nnF qyraYatIcOq+m9uCnGewZwtkzz617wZJoTcp9omE7ma5PHmxwxaRj+PQlvVwZolAuuT0 rq4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=nTtFo7Ey6iTFDFnCQKapfNWThuL3kGTF17ttTeec0O0=; b=oQS/pcNLbTveLqcME2+em6aCDxoYghfYYfYrgKKHIsc8hUtl8/2dLNubd7Wycp7L6A 7JUCIEo2yO7ZTydkfgcjd54gEf5l2y+lqmV+QopLSPD/1tItW5Y85vwUpSXUP7pozerE CDCWNBbuE/8aC/lcua/DFjqaJ8MbGNv0V3cWLmVCcTw3zdr+sKt4e9ZFIiSayQRRumAd yCYG+UPLBpYcjwfSLdNGSgydOOf5k8IxpdwHZ53rQmUD1Gac5bmWJAsE27gRq4bDrQOR v86qeMWAO41IlCq2DwxTTlveRW3IVst2nVHN6HXYOilKKPFa9ozEqE1RE6Aib4FQflM4 oVdw== X-Gm-Message-State: ALKqPwc1Kep5BP6CLKGRoAOouwzt/VtRpfbNyzxlOyRtLuCKiEFsVfdp brox5KFTVDs9IWIJ32IGOhY= X-Received: by 2002:a25:244b:: with SMTP id k72-v6mr1854824ybk.80.1527695601745; Wed, 30 May 2018 08:53:21 -0700 (PDT) Received: from localhost ([2620:10d:c091:180::1:6002]) by smtp.gmail.com with ESMTPSA id s4-v6sm5036896ywa.9.2018.05.30.08.53.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 May 2018 08:53:20 -0700 (PDT) Date: Wed, 30 May 2018 08:53:19 -0700 From: Tejun Heo To: Josef Bacik Cc: axboe@kernel.dk, kernel-team@fb.com, linux-block@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Josef Bacik Subject: Re: [PATCH 02/13] block: introduce bio_issue_as_root_blkg Message-ID: <20180530155319.GJ1351649@devbig577.frc2.facebook.com> References: <20180529211724.4531-1-josef@toxicpanda.com> <20180529211724.4531-3-josef@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180529211724.4531-3-josef@toxicpanda.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 05:17:13PM -0400, Josef Bacik wrote: > From: Josef Bacik > > Instead of forcing all file systems to get the right context on their > bio's, simply check for REQ_META to see if we need to issue as the root > blkg. We don't want to force all bio's to have the root blkg associated > with them if REQ_META is set, as some controllers (blk-iolatency) need > to know who the originating cgroup is so it can backcharge them for the > work they are doing. This helper will make sure that the controllers do > the proper thing wrt the IO priority and backcharging. > > Signed-off-by: Josef Bacik Acked-by: Tejun Heo Thanks. -- tejun