Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263868AbTICWO6 (ORCPT ); Wed, 3 Sep 2003 18:14:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263939AbTICWO6 (ORCPT ); Wed, 3 Sep 2003 18:14:58 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:41134 "EHLO atrey.karlin.mff.cuni.cz") by vger.kernel.org with ESMTP id S263868AbTICWO4 (ORCPT ); Wed, 3 Sep 2003 18:14:56 -0400 Date: Thu, 4 Sep 2003 00:14:55 +0200 From: Pavel Machek To: Bill Davidsen Cc: Patrick Mochel , Linus Torvalds , kernel list Subject: Re: Fix up power managment in 2.6 Message-ID: <20030903221455.GB4199@atrey.karlin.mff.cuni.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 38 Hi! > > > #include "power.h" > > > > > > -extern long sys_sync(void); > > > - > > > -unsigned char software_suspend_enabled = 0; > > > +unsigned char software_suspend_enabled = 1; > > > > > > #define __ADDRESS(x) ((unsigned long) phys_to_virt(x)) > > > > > > ...by this you enable suspend even before system is booted. That's bad > > > idea. It could hurt in the past (when we had sysrq-D so swsusp), and > > > it may hurt again in future when battery goes low during boot. > > > > Does it or does it not cause a problem? Look at the old software_suspend() > > function - The handling of this flag was weird and non-standard. This is > > cleaner. > > I don't want to get in the middle of this, but having a laptop decide > that it doesn't have enough battery to finish a boot is something which > happens now and again. If this change could cause data corruption where > the old code didn't, perhaps we could stand the overhead of moving the > enable to the end of the boot, or wherever would be safe. We do not yet do suspend-to-disk on battery low, so Patrick's code is actually safe. Still I do not think that's good change. Pavel -- Horseback riding is like software... ...vgf orggre jura vgf serr. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/