Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4807978imm; Wed, 30 May 2018 12:24:13 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL881YRQaatjXHo6zp8hEtcHdMGLvBc/kRhjFJ7XujTbULALrJepA0T+891+WAfgA591+1p X-Received: by 2002:a65:6031:: with SMTP id p17-v6mr3209234pgu.311.1527708253458; Wed, 30 May 2018 12:24:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527708253; cv=none; d=google.com; s=arc-20160816; b=rnJwuYQBXXVl/nIRh8wfZ0p2fi3AxXwsrmRqMUzfjTm/fyxH1yEJR3rlsRh/WYe4FR bUR80UnvN+8o1mTPMjlNuswSzeKFg0UwhSD3b8AWCNWJ5RjAwy5GaiAjGajwy0DDKcWL 93Fh7W+QSr7nFEVhfQT0pDFnzWGKwx3w60MG4JGu47PQXBEy5a4W+JCBod1KdsZUX0C+ v2XHC3qFxXOAv3NDyRUbIZD4IDq3NmOP5v3QCOLnxFSf6SwLzmhM486g6HW1hM6rQS7n P3+BGMtKvGDyzwT/I27S6XbMbxJZ1WCYO2l90ppJsi8ncj+URXLmN4rBYnpCirKCJ58T EmCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=4P8s27MY4cXzfMp40HaT5sXMiPeXdQTmjZIOHgCouXM=; b=WFJLPl/Mw8r4U3QQl+zWhD4PWhDIbCt5/pc+UuwdywP3QCb6qArNk6wyQIgPDWsNQX YDm2XCKvfxpiepl1QAzELZDQ28tlsSPHxR6e9Xc/OOH+YOLPsyCNAjf2kcReCaYMhA7v BMHxBlmg2RKGAVrakzoYf4tboROgbTM/iQaj1sKr/HyVNJua1JlKln2zwCmnEJw29JzY dHcSi8k8t5fORby1MDvEF7wN5WT1ICnYFX1MB1N/4HsLKwQ5XVg2JH3j/J1ZIpWATfz0 RYpv9AqxaXFIX2RIbW+iJzseRy5glheS1stZfc02iD/wqD8pAYs1lrlTKUIoLGwx88BF rHmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=JrlGcXZH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s88-v6si34915641pfa.339.2018.05.30.12.23.59; Wed, 30 May 2018 12:24:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=JrlGcXZH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932171AbeE3TVx (ORCPT + 99 others); Wed, 30 May 2018 15:21:53 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:48130 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753812AbeE3TVt (ORCPT ); Wed, 30 May 2018 15:21:49 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4UJL7bU175248; Wed, 30 May 2018 19:21:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=4P8s27MY4cXzfMp40HaT5sXMiPeXdQTmjZIOHgCouXM=; b=JrlGcXZHbpfp0iif+78A6IoY8jKTbl+kpSRU7GRwrdBTdTwpkINhCUStwQlrB1X4vFNr Y+BeO1MLsHmWjSNUfPtqEy08aJRqcJGntyt1KBGnaeHCqasMCb/6MMasGhxpNiADJzty SsJGDdtp02c6kB8BQAUSAXVvir4fjS2521v+kY56+SSy33Xjs/7FDEkiUQJrBehVe9d5 A4J1vhglPO7fFNAN7G0elzqBYwh+duSBEAJBf2FPTwwHc3mhJ6+eh503i1jJjmiP/9KB lvPSTNkrkG69PYY9b1kRg6F5q9VZ/KN4nebsOX5WvwGbu9UD13wD6otYdyvrY47uJhsi ow== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2j9x4h9240-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 May 2018 19:21:33 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4UJLW2x032150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 May 2018 19:21:32 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w4UJLVGZ025451; Wed, 30 May 2018 19:21:31 GMT Received: from mwanda (/197.157.0.20) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 May 2018 12:21:31 -0700 Date: Wed, 30 May 2018 22:21:19 +0300 From: Dan Carpenter To: Colin King Cc: Jassi Brar , Al Stone , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] mailbox: PCC: check for negative count for parse failure checking Message-ID: <20180530192119.eexpge4nke4uovlz@mwanda> References: <20180530171429.3172-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180530171429.3172-1-colin.king@canonical.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8909 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=620 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1805300206 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 06:14:29PM +0100, Colin King wrote: > From: Colin Ian King > > The function acpi_table_parse_enties_array can potentially return a > negative value if parsing fails. Currently the check on the return > is not checking for errors, so fix this by adding a -ve check too. > The impact is that kmallocs would immediately fail and give you a big stack trace. regards, dan carpenter