Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4887041imm; Wed, 30 May 2018 14:08:50 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJf7WLp5XpdggCotOpMkn0dfNM8OZP1LoAr1f/qxD/Dj2/0eKNd1HuiZFCIVbwPM1OlkA9r X-Received: by 2002:a65:61a5:: with SMTP id i5-v6mr3253720pgv.405.1527714530117; Wed, 30 May 2018 14:08:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527714530; cv=none; d=google.com; s=arc-20160816; b=ocpujPeacuKVPZ//dkFxHT326/GaajiDuvw5NciCclJrtngqz28VoDLGsoyR5dUzQG T7qM2YC4QSyZ+wLXsyRpiMJuN9dQn92/oFMcsRF6Nq8ZNCsZRASe664D8nhBIeBZFeft g7UmeSK4OylUuiPg6kiQ2R31vX9DYwfLvsQr1/mdlrfH80qNcXfp8EjbfD35o+JSj4X/ wY6Cr7UupoVO8P7iXpStk9wLk/PLT+E8JbHu5CfW9zRXNWXqowL0vVgOyWnkwckYzxHs lH82Y7gkvpfqlvEUGNlCIYXI/VZzosGS6Nt6aYCsCTpwVFY3QYTBpDmIvnmzd8LndZ7A 9k9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=Ow7nGct9/DAOJThV2XcFWudYmoe0q/8IvrQSaoBomys=; b=xeEfz+3s56mqshQgUPTTlVY6OuC03OR8dFefUVdIlaK0ACZ7v5v3DTfld++Gl1v5yk cAEEp73aNW2cBMVrBtjWoLLB8DUia3AV+hzeaLHKeba5cB2LSIJAzIU1cVYT5GnFFa5Z DzsC7aWhwehN+ny60vOItYVVbVUyTBoZSMwJrBvvgzsnSSYslUtHl+tezkWsdP2aZphk kCWzmv5waJmCz4ZelMt7phRA32REEe6lI53riQjPQkF1Fizb/FC4N8Cq0iQr0TkA8ujF uzABkyCYzC8dZHnMaJwSstOvcIx8qh6n1Scb2hXAe1U8yjCFL8ucpYME6mOLlSP6TBrE /GJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PSxN4SBe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 4-v6si35444202pfb.204.2018.05.30.14.08.36; Wed, 30 May 2018 14:08:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PSxN4SBe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932454AbeE3VHY (ORCPT + 99 others); Wed, 30 May 2018 17:07:24 -0400 Received: from mail-yb0-f194.google.com ([209.85.213.194]:43950 "EHLO mail-yb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234AbeE3VHS (ORCPT ); Wed, 30 May 2018 17:07:18 -0400 Received: by mail-yb0-f194.google.com with SMTP id w3-v6so4275072ybq.10; Wed, 30 May 2018 14:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ow7nGct9/DAOJThV2XcFWudYmoe0q/8IvrQSaoBomys=; b=PSxN4SBeIZdtm3UgJua0akLCOj6SxLTT9zOJMWx/gD5gFjaH+aZ7sWOPnuRs3ctzxx ZF/IlPhkzLvd3PkLDOgfwTDxeBKAj3kMxdobAAFmj+MJidGfEFQ4+4n0PRKL3Lo3veBh HQFMGXR7qXHnS/Y5GEkHHDD3yZwdws+J/9ZEQMFHTZEkDmohRpQQp+MGx4U4nvKydJhF DEJOREvlshK0VpbORjB/RcQhJQHcPzI8cd4QXaXZ5najLrd2edsFqNR6LQH2QCJ6pvd0 nVqZA24z6G01KQ9HZkPtXF5GrZfDbDtaQHCxh9wLHKxn/UNuNcaH4n9v+1zFEo+/nmBZ QYRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ow7nGct9/DAOJThV2XcFWudYmoe0q/8IvrQSaoBomys=; b=dJgb5or5IpMMhxJO3dsm5jlrSJCN6KsmP6kDIjC8IudAEIZPAoBmPen5Bq8PJcYtwg 7n89adVCStM2O2tpfxFJGuofXsVZhQalPI1/+pwNbP9s3dtZ3QrYuFgI1L/cmESXmVAL HHVFsyqicE1WJu+mC3r8gjQYSkw/WgYk9PtpzKumaoHqsQvyjlC/DblxrzWmosbYEgUD PDQMupOrx2idoXwtloFHDjoOIs4K4uL3tHwkYkGwTvq1HPgodN2jeOdaX3kFHeJvSyV9 BtDSN7sXH+9RU236XJHFQ6CvcrxXP85bk5oI6JLuCKjGg+5XMR6BITR7zQcOYB3ECS86 fdDg== X-Gm-Message-State: ALKqPweeGmGv5mhYt4nIlNiQG1UOXlYtnzMwW+b2bNFCxNLSz0iuJNxU yB5qTScOVoQbeGpUnDYpl6+34oiW X-Received: by 2002:a25:1004:: with SMTP id 4-v6mr2552504ybq.336.1527714437956; Wed, 30 May 2018 14:07:17 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c091:200::2:48e]) by smtp.gmail.com with ESMTPSA id u38-v6sm16376343ywh.46.2018.05.30.14.07.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 May 2018 14:07:16 -0700 (PDT) Date: Wed, 30 May 2018 17:07:15 -0400 From: Alexei Starovoitov To: Colin King Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev Message-ID: <20180530210713.v4cf4wjniwyobfmm@ast-mbp.dhcp.thefacebook.com> References: <20180530150916.16808-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180530150916.16808-1-colin.king@canonical.com> User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote: > From: Colin Ian King > > The assignment dev = dev is redundant and should be removed. > > Detected by CoverityScan, CID#1469486 ("Evaluation order violation") > > Signed-off-by: Colin Ian King Applied, Thanks. Please use [PATCH bpf-next] in the subject next time. See Documentation/bpf/bpf_devel_QA.rst