Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264318AbTICXcT (ORCPT ); Wed, 3 Sep 2003 19:32:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264292AbTICXcK (ORCPT ); Wed, 3 Sep 2003 19:32:10 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:53995 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S264266AbTICXcC (ORCPT ); Wed, 3 Sep 2003 19:32:02 -0400 Message-ID: <3F5679E1.8090604@pobox.com> Date: Wed, 03 Sep 2003 19:31:45 -0400 From: Jeff Garzik Organization: none User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk X-Accept-Language: en MIME-Version: 1.0 To: Benjamin Herrenschmidt CC: "David S. Miller" , Adrian Bunk , Andrew Morton , linux-kernel mailing list , linux-net@vger.kernel.org Subject: Re: [PATCH] Re: 2.6.0-test4-mm5 References: <20030902231812.03fae13f.akpm@osdl.org> <20030903161200.GC23729@fs.tum.de> <3F5617A9.4040603@pobox.com> <1062607559.1785.50.camel@gaston> In-Reply-To: <1062607559.1785.50.camel@gaston> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 23 Benjamin Herrenschmidt wrote: > BTW. David: Any reason why you wouldn't let me change all occurences > of spin_{lock,unlock}_irq into the ...{save,restore} versions ? IMO... even though you do lose a tiny bit of performance, I definitely prefer the save/restore versions. It allows the arch a lot more flexibility, so I even have a [weak] argument that {save,restore} variants increase portability. And it's safer, as I like to avoid code which winds up doing (as it passes through layers) spin_unlock_irq() followed by spin_unlock_irqrestore(). Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/