Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4932141imm; Wed, 30 May 2018 15:11:29 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK4kede6YRjiQYv72JzAPhkd+1WOkxb3uovhrQU0fDNmxXVKHwbPNa2Smw5dfStCaqNfIxh X-Received: by 2002:a17:902:4545:: with SMTP id m63-v6mr4573979pld.268.1527718289249; Wed, 30 May 2018 15:11:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527718289; cv=none; d=google.com; s=arc-20160816; b=iJ/URXFvEsyEdJTKDwJwdWWDNXJxGRwNslZoFvPTvjx0mHl2MGisSosXkq2OZOf4SC qcSXpwbny0qdRdjc0DIMcuhCYKUx1cHl09zNXSY1LFeFwGGJqMYC+nJ653P4sRIc509T L9/EKsw3c4YRRkVW2SwzyIjorQFuKAg8EIq/OSPTTpZpWaU3wt9IjojGgrd9PUFgJS4F t4I6hiG3qiyjlwJiYAk9mYmuYJfQSolayWTuEmZJgauSMCfIRDBRsAd9DBjkZCFM/fup +q+q2ITumtOnn3MUFJLJtFgjMmtLS//WOGp3DMZXnorSWQLDaIZ7dhlU/p4JOpPhhEw0 TANg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=FM7PWv/gL21/J1+0tzhYimQp/bDr84pMZZFlpEPUs0Q=; b=FgdlFlIvUf06sC0+8pNK531M5oAPT+VjUMEDF0A4DejeY6rwqMZkhUG0RNZnPCMFxe mxcPlM8GAAsAcnRoGpJgoyDJsm6O58rRuJKef7J6oiIKQ4TgoiLf9sTG1OQ6ACv8IcdS qFKWHCnEv5HBHB8bvUMdQHl0m36fTEXNNlN4XTsrJ6ZGZ/nsdFPT2XyDojpE2vrDH51M wDKvLZ15CIAbUNbxUX8+gJhwaogvWkK1nRkZ7oB7b1zqiOKOfLsNa2+XF3XducZ64pC+ WNDHabGbgqon7vbugM+p5lx2v69mTu60jgnXhDzqdV16wk9edhP3vGM0pVkU88P5Qr9M ymVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a23-v6si34848219pfe.364.2018.05.30.15.11.15; Wed, 30 May 2018 15:11:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932567AbeE3WKc (ORCPT + 99 others); Wed, 30 May 2018 18:10:32 -0400 Received: from 72-48-214-68.dyn.grandenetworks.net ([72.48.214.68]:55147 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932431AbeE3WKb (ORCPT ); Wed, 30 May 2018 18:10:31 -0400 Received: from [10.10.0.239] (cody.ogc.int [10.10.0.239]) by smtp.opengridcomputing.com (Postfix) with ESMTPSA id BB6FA29E9E; Wed, 30 May 2018 17:10:30 -0500 (CDT) Subject: Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency To: Jason Gunthorpe , Arnd Bergmann Cc: Steve Wise , Doug Ledford , Yuval Shaia , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180530215826.1343234-1-arnd@arndb.de> <20180530220405.GH30754@ziepe.ca> From: Steve Wise Openpgp: preference=signencrypt Autocrypt: addr=swise@opengridcomputing.com; prefer-encrypt=mutual; keydata= xsFNBFqwI58BEADHLbww9YiREKDrxddx0Wm5VyIodSAyNM1VrLcTbatWuSySXzj3uqrRXenG ECGt2jd/r45HPn4xtj9bhnlz/4ZsWCMQ/nYnAQ1+oNfLGBsWv5x3EhBjEaOHUpz+HFTNrggP HBEqCU7z491Oailww10EAWg8DMa/YQqNxvjStikI1ct32HJWTI/aDLcE2HMgKEoWp8uupL91 75/ZxWHkImyLZ9Gj3gTeUQtx6Kd0wafER14WsNETNzJaHZ1MBfEb+92n+CyiGGYecy8LUFOR rsbuWyPV9/28q6wAtF75yAwWiyRI7Vyb/onUWlY/MZ2ctC/I2Qu6cRkOQin5iI4aW996Ugnu 0e+05UGfmRLpnDTMTRsMzj8d7EauKzeRaOzxjWuGDkyfhMln6lBNTyrsVXUj2s0zrtsuBHNH EbftQYOnOkhtRkKBmw2yW7m/pD2/6qwJrASI+kahUW44KCouGq6937owNTJSnQulvAouu8I5 oI5cAonEUdTQXec2Y4TzecUaHYMu6av+3alhQ4tlIltiwfvJPirER4z1P3RBJQ54dclNxTuF iRB7xrSmTvud2Bl70s4JyLIoHaGx1NqBdNzME1d6OiMxlyxyhGo2WpT2rCb5lHdv+YY2r6+S EF7fKiMjTfIRMTliVqr8Epw1obPIVD5kYCPzVslZa8DuaIUyzQARAQABzShTdGV2ZSBXaXNl IDxzd2lzZUBvcGVuZ3JpZGNvbXB1dGluZy5jb20+wsGOBBMBCAA4FiEECzM+1ksA8NDnoscP eJ7qsPaUaqgFAlqwI58CGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQeJ7qsPaUaqgi 7hAArVQV0B1D1fSxaHYv7PIfSSbtje0/gSAGruwuZXiC0LkgPxix3mebmheYrwcl7EfZ2R5a GOP0p0UdMZjteAURZtHblVzAGJdaHqFw7nHV72cnspz14IUOMU+Lz6jfGsAa5A+L/fGQCAhC Gtv5h56z3zWtMc+IMYV/UtSKUsg1AKWpzVtDw8a7BLPm80D4OGIbbNpWfD4c/jCkqIEPVMWr P7UYlGJQ908RYFe/RFZYKDqpAAJtoNf1zo685Y7FwD4CvQ+ExvRiEbErqPtfJ5WTU61eG3um s2gWHDEbNkRl1gXXbv+xAY6+5h3jQnhrtyhbIE5uLgNpznPakJx4Ce8d1e5Z2N97vpk61lsY TOrWaxmNfK7swD2+qxeO4Y7wXU+3DfhaLX/3s3c0OpfwoSNQiOoSllS2RdzXbmdNzr1jusm1 6x+h1OSeF/IuxdrxIteXuJt1iQitILpRclLdcGMaHnhgvuDyBFtH0AOo7VLsGDO/Qdvb1LsM htT5nvYi0ZkED+NYkLt5FHJ2wqZgZUgtU4TnyXiOcO0jhuKF1Vwtf6CSpdwXF9oPrZVtCMB7 o2hcKZhHwtdtQsTsV0U0BqNxyVprVWv3Z0RxLjq0z2uHZO28VwsVLzWiYo6A2b1ydGNXUoHZ xsn4qfGsnPyRuo1Zx4y9J/cWCbQys+368nIkbVzOwU0EWrAjnwEQAKY+Ndo/WmYHLbWBQdG3 Saoaz0Xjhx1oUCMvmGwlf2Fn9Buv+HnoOmls6g3l8zgNV8MSwtZB4UZATNp/GdRd805ESABK hG+aIPcXoTnlwL3PXaAsqJrmRETqmGWL46Q2k8QXrR71WrDt1HVME0axeubDG9o4QL+OZGMG Ahefc0K0N2u1Pq3LeUhucX0tR0prSSp8kH5uAOxa/RH6D5n9zXUigcFAIgrvsZDkWvIgdgy5 9qNCEvmoRsYPaDYMRrqFFLUy43cGjOQJsAAbVuBig4/XO4VwYiVXgsjOZS+OZcDKjyOngown uXnhu8ri2x8mUhDUvRVgEeUY/DuvjLYq0zpDbgrOT9vdutH95UBGlK3AMFXDLKiqoZv2INV0 30OBnfarJLy0+mXOlV3CG1gGKIrA3kBVu8vc+g/3X91dApdeUprPloOI4FoAN3deIGZqhMi+ EunSCBC6e86TeKcRD+SGhiPwStdtbPS88Rh64b2Iz4ojR/Lv1x5/w7kfpEhYLu2QpGzLcb4e DPfcVCIP1Lmn/IiI4c7+rabPBlasXtAYbnAwOt10bQirD7okz9/btfkEfoUUusFZxHaXExcs vM1vhmy/gmdqzooCTNB2qRwha6LbyC89buA9EERHKq6VyQTKNI5C6ztizua5r1BFNi992kZq 9A/CsIBRtmSc9PG5ABEBAAHCwXYEGAEIACAWIQQLMz7WSwDw0Oeixw94nuqw9pRqqAUCWrAj nwIbDAAKCRB4nuqw9pRqqJ0XD/9QCNEEdPJne40SD9a7XioQrTVov2mbanTMyIymLrq7kCuO KqnZpOqv7eDW2qP7YtgL83/uqUuKGuY7w4smvqRhnqU+PMKXpHq69LUhRzZPL1PgF5fropwA RixoEV6jTk1zaAMvYI/IY8+sway6+JDCGmNGtLql3u36xx4oFiQ27KFu2KonN/JxUWFlKW6h z40ymu53H4KHDnhSkgnGRmABbn3BuJGhCwBBBLN2/iTcrOQcDf1O/TLSN8J5PuC7ZVhQWZII R5CRszQKmMQillR4Cx+aChCNuVc2LvoF+X9P4VCJKRE5jKf5lyR7ySnZ8sZuO41yNKDWPu49 gwOgI4x+dHDZcICaqFHgBjtXlAyNrQmvI+/5dX/xAUUA7IKPT/snZpcvImPfoqb7ApLVmIBS +CWRfj/sIOsCUszIcoek6E10wRTxWbXgM7hIJb4PTuDYhlQtiR/ecV0AmnTPQkUlyBVZc6Qf /gxq/PLmShEbY5nqcRWCarAIOjdtnJ8BausDT1IWUg3cFabbl4fGtRUrfuPRWMw6Ur6I4ngv w9ErvpbMovkuuQC0LTsUD8y0SiZybmQT9P0RCEmg1lwsDbwskUB3fxZXKt7nOxcaN6CO8LqJ eonY661xReorhk+iPjXCt3/Pg8FKJH3Cjnz3RQ3kvQgYXz7CGhqGPLcdoRpjeA== Message-ID: <0be4e0fb-8d8e-b337-fc8d-550c90829d8c@opengridcomputing.com> Date: Wed, 30 May 2018 17:10:35 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180530220405.GH30754@ziepe.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Antivirus: AVG (VPS 180523-2, 05/23/2018), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: > On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: >> The newly added fill_res_ep_entry function fails to link if >> CONFIG_INFINIBAND_ADDR_TRANS is not set: >> >> drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry': >> restrack.c:(.text+0x3cc): undefined reference to `rdma_res_to_id' >> restrack.c:(.text+0x3d0): undefined reference to `rdma_iw_cm_id' >> >> This adds a Kconfig dependency for the driver. >> >> Fixes: 116aeb887371 ("iw_cxgb4: provide detailed provider-specific CM_ID information") >> Signed-off-by: Arnd Bergmann >> --- >> drivers/infiniband/hw/cxgb4/Kconfig | 1 + >> 1 file changed, 1 insertion(+) > Oh, I think we need to solve this with maybe a header fill null stub > instead.. > > We don't want to disable drivers just because a user interface is > disabled. > Why does CONFIG_INFINIBAND_ADDR_TRANS disable building rdma_cm.ko?  That is not correct. Steve.