Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     Arnd Bergmann <arnd@arndb.de>, Steve Wise <swise@chelsio.com>,
        Doug Ledford <dledford@redhat.com>,
        Yuval Shaia <yuval.shaia@oracle.com>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20180530215826.1343234-1-arnd@arndb.de>
 <20180530220405.GH30754@ziepe.ca>
 <0be4e0fb-8d8e-b337-fc8d-550c90829d8c@opengridcomputing.com>
 <20180530222520.GJ30754@ziepe.ca>
From:   Steve Wise <swise@opengridcomputing.com>
Openpgp: preference=signencrypt
Autocrypt: addr=swise@opengridcomputing.com; prefer-encrypt=mutual; keydata=
 xsFNBFqwI58BEADHLbww9YiREKDrxddx0Wm5VyIodSAyNM1VrLcTbatWuSySXzj3uqrRXenG
 ECGt2jd/r45HPn4xtj9bhnlz/4ZsWCMQ/nYnAQ1+oNfLGBsWv5x3EhBjEaOHUpz+HFTNrggP
 HBEqCU7z491Oailww10EAWg8DMa/YQqNxvjStikI1ct32HJWTI/aDLcE2HMgKEoWp8uupL91
 75/ZxWHkImyLZ9Gj3gTeUQtx6Kd0wafER14WsNETNzJaHZ1MBfEb+92n+CyiGGYecy8LUFOR
 rsbuWyPV9/28q6wAtF75yAwWiyRI7Vyb/onUWlY/MZ2ctC/I2Qu6cRkOQin5iI4aW996Ugnu
 0e+05UGfmRLpnDTMTRsMzj8d7EauKzeRaOzxjWuGDkyfhMln6lBNTyrsVXUj2s0zrtsuBHNH
 EbftQYOnOkhtRkKBmw2yW7m/pD2/6qwJrASI+kahUW44KCouGq6937owNTJSnQulvAouu8I5
 oI5cAonEUdTQXec2Y4TzecUaHYMu6av+3alhQ4tlIltiwfvJPirER4z1P3RBJQ54dclNxTuF
 iRB7xrSmTvud2Bl70s4JyLIoHaGx1NqBdNzME1d6OiMxlyxyhGo2WpT2rCb5lHdv+YY2r6+S
 EF7fKiMjTfIRMTliVqr8Epw1obPIVD5kYCPzVslZa8DuaIUyzQARAQABzShTdGV2ZSBXaXNl
 IDxzd2lzZUBvcGVuZ3JpZGNvbXB1dGluZy5jb20+wsGOBBMBCAA4FiEECzM+1ksA8NDnoscP
 eJ7qsPaUaqgFAlqwI58CGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQeJ7qsPaUaqgi
 7hAArVQV0B1D1fSxaHYv7PIfSSbtje0/gSAGruwuZXiC0LkgPxix3mebmheYrwcl7EfZ2R5a
 GOP0p0UdMZjteAURZtHblVzAGJdaHqFw7nHV72cnspz14IUOMU+Lz6jfGsAa5A+L/fGQCAhC
 Gtv5h56z3zWtMc+IMYV/UtSKUsg1AKWpzVtDw8a7BLPm80D4OGIbbNpWfD4c/jCkqIEPVMWr
 P7UYlGJQ908RYFe/RFZYKDqpAAJtoNf1zo685Y7FwD4CvQ+ExvRiEbErqPtfJ5WTU61eG3um
 s2gWHDEbNkRl1gXXbv+xAY6+5h3jQnhrtyhbIE5uLgNpznPakJx4Ce8d1e5Z2N97vpk61lsY
 TOrWaxmNfK7swD2+qxeO4Y7wXU+3DfhaLX/3s3c0OpfwoSNQiOoSllS2RdzXbmdNzr1jusm1
 6x+h1OSeF/IuxdrxIteXuJt1iQitILpRclLdcGMaHnhgvuDyBFtH0AOo7VLsGDO/Qdvb1LsM
 htT5nvYi0ZkED+NYkLt5FHJ2wqZgZUgtU4TnyXiOcO0jhuKF1Vwtf6CSpdwXF9oPrZVtCMB7
 o2hcKZhHwtdtQsTsV0U0BqNxyVprVWv3Z0RxLjq0z2uHZO28VwsVLzWiYo6A2b1ydGNXUoHZ
 xsn4qfGsnPyRuo1Zx4y9J/cWCbQys+368nIkbVzOwU0EWrAjnwEQAKY+Ndo/WmYHLbWBQdG3
 Saoaz0Xjhx1oUCMvmGwlf2Fn9Buv+HnoOmls6g3l8zgNV8MSwtZB4UZATNp/GdRd805ESABK
 hG+aIPcXoTnlwL3PXaAsqJrmRETqmGWL46Q2k8QXrR71WrDt1HVME0axeubDG9o4QL+OZGMG
 Ahefc0K0N2u1Pq3LeUhucX0tR0prSSp8kH5uAOxa/RH6D5n9zXUigcFAIgrvsZDkWvIgdgy5
 9qNCEvmoRsYPaDYMRrqFFLUy43cGjOQJsAAbVuBig4/XO4VwYiVXgsjOZS+OZcDKjyOngown
 uXnhu8ri2x8mUhDUvRVgEeUY/DuvjLYq0zpDbgrOT9vdutH95UBGlK3AMFXDLKiqoZv2INV0
 30OBnfarJLy0+mXOlV3CG1gGKIrA3kBVu8vc+g/3X91dApdeUprPloOI4FoAN3deIGZqhMi+
 EunSCBC6e86TeKcRD+SGhiPwStdtbPS88Rh64b2Iz4ojR/Lv1x5/w7kfpEhYLu2QpGzLcb4e
 DPfcVCIP1Lmn/IiI4c7+rabPBlasXtAYbnAwOt10bQirD7okz9/btfkEfoUUusFZxHaXExcs
 vM1vhmy/gmdqzooCTNB2qRwha6LbyC89buA9EERHKq6VyQTKNI5C6ztizua5r1BFNi992kZq
 9A/CsIBRtmSc9PG5ABEBAAHCwXYEGAEIACAWIQQLMz7WSwDw0Oeixw94nuqw9pRqqAUCWrAj
 nwIbDAAKCRB4nuqw9pRqqJ0XD/9QCNEEdPJne40SD9a7XioQrTVov2mbanTMyIymLrq7kCuO
 KqnZpOqv7eDW2qP7YtgL83/uqUuKGuY7w4smvqRhnqU+PMKXpHq69LUhRzZPL1PgF5fropwA
 RixoEV6jTk1zaAMvYI/IY8+sway6+JDCGmNGtLql3u36xx4oFiQ27KFu2KonN/JxUWFlKW6h
 z40ymu53H4KHDnhSkgnGRmABbn3BuJGhCwBBBLN2/iTcrOQcDf1O/TLSN8J5PuC7ZVhQWZII
 R5CRszQKmMQillR4Cx+aChCNuVc2LvoF+X9P4VCJKRE5jKf5lyR7ySnZ8sZuO41yNKDWPu49
 gwOgI4x+dHDZcICaqFHgBjtXlAyNrQmvI+/5dX/xAUUA7IKPT/snZpcvImPfoqb7ApLVmIBS
 +CWRfj/sIOsCUszIcoek6E10wRTxWbXgM7hIJb4PTuDYhlQtiR/ecV0AmnTPQkUlyBVZc6Qf
 /gxq/PLmShEbY5nqcRWCarAIOjdtnJ8BausDT1IWUg3cFabbl4fGtRUrfuPRWMw6Ur6I4ngv
 w9ErvpbMovkuuQC0LTsUD8y0SiZybmQT9P0RCEmg1lwsDbwskUB3fxZXKt7nOxcaN6CO8LqJ
 eonY661xReorhk+iPjXCt3/Pg8FKJH3Cjnz3RQ3kvQgYXz7CGhqGPLcdoRpjeA==
Message-ID: <d2472443-3ae6-63f4-59ad-d6367b837038@opengridcomputing.com>
Date:   Wed, 30 May 2018 17:29:32 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180530222520.GJ30754@ziepe.ca>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 5/30/2018 5:25 PM, Jason Gunthorpe wrote:
> On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote:
>>
>> On 5/30/2018 5:04 PM, Jason Gunthorpe wrote:
>>> On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote:
>>>> The newly added fill_res_ep_entry function fails to link if
>>>> CONFIG_INFINIBAND_ADDR_TRANS is not set:
>>>>
>>>> drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry':
>>>> restrack.c:(.text+0x3cc): undefined reference to `rdma_res_to_id'
>>>> restrack.c:(.text+0x3d0): undefined reference to `rdma_iw_cm_id'
>>>>
>>>> This adds a Kconfig dependency for the driver.
>>>>
>>>> Fixes: 116aeb887371 ("iw_cxgb4: provide detailed provider-specific CM_ID information")
>>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>>>  drivers/infiniband/hw/cxgb4/Kconfig | 1 +
>>>>  1 file changed, 1 insertion(+)
>>> Oh, I think we need to solve this with maybe a header fill null stub
>>> instead..
>>>
>>> We don't want to disable drivers just because a user interface is
>>> disabled.
>>>
>> Why does CONFIG_INFINIBAND_ADDR_TRANS disable building rdma_cm.ko? That
>> is not correct.
> That seems like a reasonable thing to do..
rdma_ucm.ko is for usermode users, rdma_cm.ko is for kernel users, and
is required for iwarp drivers.  It seems rdma_cm.ko is not being
compiled if ADDR_TRANS is not set.


> But why does it break the compile? Those functions are in cma.c...
>
> Jason

Indeed, why. :)

Perhaps this line is wrong in drivers/infiniband/core/Makefile:

infiniband-$(CONFIG_INFINIBAND_ADDR_TRANS)      := rdma_cm.o

I don't understand the rules in that Makefile. 

Steve.