Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp263394imm; Wed, 30 May 2018 23:14:26 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK3FQJdTiD0jQsuhaIhxxUmc949u9B0lE7OeuFqXJ8npUh8UGeejIRVfG6qJCDfoh1OsJLB X-Received: by 2002:a17:902:d711:: with SMTP id w17-v6mr5675409ply.200.1527747266760; Wed, 30 May 2018 23:14:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527747266; cv=none; d=google.com; s=arc-20160816; b=jcOMS1TuEnSgS3Qcy+3AlEZgUANLFBG/b++VaagEzFamOKDopfH1AVLbLo8mHKLtW+ i5ieU4bU20EPg/7pPcpOQ4EnbV3SpN6ERjxv5X/yhS7aS1wuLXlfi0L37sCBQXS/AhHG GO8/jgJjpAm6UcIxntRPC7pU/P6i/6Bv7lSTjjjkjGLcUTiHqsu7gteP/3hzQsnrB9h1 uVK/ZgLCBuFkYuB5ooV3ajtf6mwhxOEZep9SDqxd1n5oIdIB9PgT9QKr+ecs+EZtdBz7 Cak79SIHHqs/5R5flfuwGS2m9aiMjCEhQFXo2MwHcSFayrw4upBreFMNEjm9IpgVW8ZE pQIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=4HVhDS3pCc1xwPohZddwdKRW3Ramu3IR50oU1UE6dVM=; b=N6fmUPs4QTtu7pIc0faT34EbTEIemO+a81bvu00m1kucJ07Dx29hUM0ns8I46T3ias v4P/gRUmXGCsGnVsxmr3w8h2rDyoF/qX72fNReggeEY7BKR7dXRpw3VL2SycG5Zn/0Kq CSAh1lBzyl9muucY5Ax6rGdcKAp7YvZDRKY0JKDikIBp0v/jCzktbTxHgEg2FWZeLv1l B2Z4Xvcmb7NNgdrhW9PMLjOYpjaJi05JdsmWs0WeG6/N6TeQ7FV7m+QaLONaWSs529jx sdlXl8tdsOwmDYqwKTl91HVsCtb5/qVeiS09YrJFH35pN6OhZDFEQrGXoa7EW/ZxvtMV uWmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KA70Exjl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bi10-v6si33734639plb.399.2018.05.30.23.14.10; Wed, 30 May 2018 23:14:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KA70Exjl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753925AbeEaGMe (ORCPT + 99 others); Thu, 31 May 2018 02:12:34 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35511 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753772AbeEaGMa (ORCPT ); Thu, 31 May 2018 02:12:30 -0400 Received: by mail-pf0-f196.google.com with SMTP id x9-v6so10237021pfm.2 for ; Wed, 30 May 2018 23:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4HVhDS3pCc1xwPohZddwdKRW3Ramu3IR50oU1UE6dVM=; b=KA70Exjlm9oyrRh533yfi9xoNXYJc/H6vCQy3zu4S38gbSWD9/nQZ3B3Qwn1xXqupM Q0M8HEMDIbTHI4ItMByNrnsuEDbbLYts7V+u7dCtevj2eDWEgUqjP50g+Qkat8yLuWtU +0+U+1qX695ez6Hbq16w+vr+q3DEYgoK6Pikc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4HVhDS3pCc1xwPohZddwdKRW3Ramu3IR50oU1UE6dVM=; b=jeG/QRWOB850/ASFzq/to9c6wvYcfTepcfj2DaMZCqHzH9UjKJk96lFUTXKTrD2W/3 y2YtCUri6H45pHVr82il7n846rQUHig7aZ2zzXJS/covD/wK/m2Vj+96B2iigfICoHEu Ear/Yr32PsS+QgYwTplj14bITwmCjl9y41UXSmdqsARfb5KVsz9qFqm1PNb7rsO+qgWQ +Gmyg4F5sHXld97FgN1893GWNK6orX6qxrC3egHsUL/7DTr56uOngc6OnhDjAtE9UljQ H07bUzabvQA81JlSjmkqpjmBPxIESiuMKiT5UMb602h3BOkSrY1V9pobezOUt5QbZ5Gp bOlw== X-Gm-Message-State: ALKqPweWkN3FXCG60ztoI73MMg+TXwsXb7Mz2L5xwemcWSP4tB5tawaQ IVdALqJY4DEZyM09380VUi9r+w== X-Received: by 2002:a62:6642:: with SMTP id a63-v6mr5550989pfc.162.1527747149460; Wed, 30 May 2018 23:12:29 -0700 (PDT) Received: from localhost ([122.172.63.23]) by smtp.gmail.com with ESMTPSA id a28-v6sm77563958pfl.86.2018.05.30.23.12.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 May 2018 23:12:28 -0700 (PDT) Date: Thu, 31 May 2018 11:42:26 +0530 From: Viresh Kumar To: Ulf Hansson Cc: "Rafael J . Wysocki" , linux-pm@vger.kernel.org, Greg Kroah-Hartman , Jon Hunter , Geert Uytterhoeven , Todor Tomov , Rajendra Nayak , Vincent Guittot , Kevin Hilman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v2 1/9] PM / Domains: Drop extern declarations of functions in pm_domain.h Message-ID: <20180531061226.r3zrwypmiud2ksef@vireshk-i7> References: <20180529100421.31022-1-ulf.hansson@linaro.org> <20180529100421.31022-2-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180529100421.31022-2-ulf.hansson@linaro.org> User-Agent: NeoMutt/20180323-120-3dd1ac Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-05-18, 12:04, Ulf Hansson wrote: > Using "extern" to declare a function in a public header file is somewhat > pointless, but also doesn't hurt. However, to make all the function > declarations in pm_domain.h to be consistent, let's drop the use of > "extern". > > Signed-off-by: Ulf Hansson > --- > include/linux/pm_domain.h | 51 ++++++++++++++++++--------------------- > 1 file changed, 23 insertions(+), 28 deletions(-) Finally. I wanted to do that earlier as checkpatch complained non stop about such declarations :) Acked-by: Viresh Kumar -- viresh