Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp298472imm; Thu, 31 May 2018 00:06:51 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIEpvb0c59G5LNSctadpU8ln5nYioRdoGtvggnaxmEWlIN8c+RhV17EVHDspHS5nQ6F7CH8 X-Received: by 2002:a62:32c6:: with SMTP id y189-v6mr5702121pfy.241.1527750411523; Thu, 31 May 2018 00:06:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527750411; cv=none; d=google.com; s=arc-20160816; b=h//b4CLAlAUbGRMHSC5HzrQ3oDHehTL0kdzIl33phH22z2562Pqyl1LpTSU3cB1koP fFdF7f6OC0GAGGZonLcZlXbwQl8V0gsjpoqe7ux3X0yyJd5ZKTtCCGxuARbflATMqrcv 0vmhmx5d6iz41eytdu0m7SA6nP9/oJqJb8hl8xzF/X9TxjlTeTD9gRSDSkUE03MwrAVq TJB1SGIgvEDMZgDhrcFKXMVliRuCnhdaQ1H5cafVmAs++Ir2EEJuBuAtRwXsZJabrCg2 1UeC2rUgvOIjfrOOL05l9RPhUS8PLzsrqYAPpGxDxb2BjRIrkPs7Su3xjJVov++Krt0f LAlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=7aSNwcp585roq57rsnttakFbeLKB1szRMcvwTB8Xhz8=; b=ZBrpff8xFJE7P/quc+Ogbh1Jkx8Iv+EGe51uzZF+F6etzPWhoKXRM74m2yTHDIuJX3 D6BpDx9QYaCmD6E+z+UgWYEEZLWFEM6FbNUHZOujrGq9y5yH48ruq8ikHYAxrp7/nXR1 beEVJ7Sf2oQPfAdKV2YPtI2pSvID/nQDlpwBV4AnHXLOfeBAFxWYXRS9c4qVdmOKbEPt R6qSySMAc1wwjMBvCH0EkO5E7kEFRck6+BnVgUov/B0ayDd1jIy9WFi4zC1xtHLQj5fG fsxgzZ4QBFF1IN1FQkiPT95fgOPL/p/6rl4fd9fq09kYUu20p+rTYWSS57b6XJEQxvcL ySjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=XtXTdHKy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r12-v6si36751242pfk.83.2018.05.31.00.06.37; Thu, 31 May 2018 00:06:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=XtXTdHKy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754001AbeEaHF4 (ORCPT + 99 others); Thu, 31 May 2018 03:05:56 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:60308 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753825AbeEaHFx (ORCPT ); Thu, 31 May 2018 03:05:53 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4V71QGU093627; Thu, 31 May 2018 07:05:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=7aSNwcp585roq57rsnttakFbeLKB1szRMcvwTB8Xhz8=; b=XtXTdHKysLYBTwHDtozN3OHP47uIUHM4qbcnKJiNqMLS+Mxx76XEcFQ9gGPS3MCRrM7r XKDPlBcpRR+syF3zl3KlunASsIwwUkNp+nYhF+6Id/aN6Pt0Gs3JOsWqGq6jmmQ/xujL xYhQM8a1h7iv00APb0EXbv822ozMcr4a5fAe86vUiDfeTiatcjRzQJT3G0LqvKIht7Gb KEb2vhrkQLorr8mcatB34ReJA3lF59x37DbuQHeyQBaoOfqGkVyT+4X7mvjL2blXuO/i OGYq8j5XruKhsGxf17nb4TLzStOw8Aq+nMneC2SPLMKIKlXhT//c9mLuQnvS7GbQDCXs SQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2120.oracle.com with ESMTP id 2j9ev8dged-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 May 2018 07:05:27 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4V75RHV028822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 May 2018 07:05:27 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4V75QAF001038; Thu, 31 May 2018 07:05:26 GMT Received: from mwanda (/197.157.0.20) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 31 May 2018 00:05:25 -0700 Date: Thu, 31 May 2018 10:05:18 +0300 From: Dan Carpenter To: Alexei Starovoitov Cc: Colin King , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev Message-ID: <20180531070518.obnfw5tv23sbpfys@mwanda> References: <20180530150916.16808-1-colin.king@canonical.com> <20180530210713.v4cf4wjniwyobfmm@ast-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180530210713.v4cf4wjniwyobfmm@ast-mbp.dhcp.thefacebook.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8909 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1805310079 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 05:07:15PM -0400, Alexei Starovoitov wrote: > On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The assignment dev = dev is redundant and should be removed. > > > > Detected by CoverityScan, CID#1469486 ("Evaluation order violation") > > > > Signed-off-by: Colin Ian King > > Applied, Thanks. > > Please use [PATCH bpf-next] in the subject next time. > See Documentation/bpf/bpf_devel_QA.rst Guys, be reasonable... git log --author=Carpenter | \ grep -A1 "Signed-off-by: Dan Carpenter " | \ grep -v Carpenter | grep Signed | cut -d '<' -f 1 | sort -u | wc -l I have sent patches to 206 maintainers. It doesn't scale for everyone to have their own special document for sending patches. I asked this last time, and I even skimmed your document, but how are people supposed to go from linux-next to the correct bpf-next git tree? It's a pain for me to do this for net, but net is way larger and busier than any other tree. I know it's a bit rude for me to say that you guys are not as important as net, but that's how I feel. I'm only going to report bugs instead of writing patches if you guys are going to insist on all sorts of new rules. regards, dan carpenter