Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp408418imm; Thu, 31 May 2018 02:42:31 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJqcshmRjU9M+izYjlw8fe9YurmyqRrM0E4VlrJ9d1jqSamDTJuclJ7QHITKkfafkjUjtMb X-Received: by 2002:a17:902:8b85:: with SMTP id ay5-v6mr6111755plb.30.1527759751571; Thu, 31 May 2018 02:42:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527759751; cv=none; d=google.com; s=arc-20160816; b=HIWS07zxNNq21QSoe9DoaysEsSih/dN14WNLdG4zUAvAK4iOQ0rMsP2P7nBCk8zErB WjjUojUMHg6RHLKCUqBjLlrhlOZDAMwaTobUcY6p3eFqhMIoHdAPY2M5HhPD7GEQ2t9i 4efkAoLOWxIXrwkZTf0qkbLPFeA1FOlroMY8Mnyh2dICvfn9tJ/9r4/HNwpDWwEBwAKd HUkczpKCGpJmdgAu4mZ2sMYKY5txdJNjF76XEOS7m2p0WfLZpYzOcxvHR0/NG0CSoZNg BHL8+b4onWnLSlWcJkGMl93Dlc8Hi2vmJiCGz092PEhvku4qyN1wmw2NEGgNHocI2Yt/ CSHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=M94OiFnIJIwdoBKE/p7RtuVSiPYAiqDwQQlFdrreqMQ=; b=cmDQJCav3/vljzgMhmVPwadZVGq//90DHKR6mzEgI/TLONP3fxM1Utq+YnuVYeQNkY QfqYzXmB2XxYAcOV3h61mUODutVjS2UQJbVldI+9Vf2iSpQhqAGpuwo+SLwgQY3ajiUH nTET+wP6Fz/BbVcg02fBbway85LuSE8gEPoE9/iauEeezI4I639M8kQfQO659VSpikRb gA+1jggdOldAR7OkLF2VQE/wfNKEZ1ha0+FNgM4wyE6w4U+Bmy5pARz+31AM31awJgNx YFWw1P5obAoW7/IMOEdKUBw6fH3NNP1AGxiim2a+x/y44+QcaBXi1V3nd0h99bXa8HRc Z/Mw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d203-v6si8416295pfd.182.2018.05.31.02.42.17; Thu, 31 May 2018 02:42:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754319AbeEaJlP (ORCPT + 99 others); Thu, 31 May 2018 05:41:15 -0400 Received: from mail.bootlin.com ([62.4.15.54]:44434 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754274AbeEaJlM (ORCPT ); Thu, 31 May 2018 05:41:12 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 5EFDF2079D; Thu, 31 May 2018 11:41:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (242.171.71.37.rev.sfr.net [37.71.171.242]) by mail.bootlin.com (Postfix) with ESMTPSA id 3223620728; Thu, 31 May 2018 11:41:01 +0200 (CEST) Date: Thu, 31 May 2018 11:41:01 +0200 From: Alexandre Belloni To: Baolin Wang Cc: a.zummo@towertech.it, broonie@kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: sprd: Add new RTC power down check method Message-ID: <20180531094101.GB2727@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/05/2018 17:18:08+0800, Baolin Wang wrote: > We should use the new method to check if RTC was powered down, which > is more solid. Since we have introduced power control and power status > registers, and we just check if the power status is the default value > (0x96), if yes that means the RTC has been powered down. Meanwhile We > can set the power control register to be one valid value to change > the power status to indicate RTC device is valid now. > > Signed-off-by: Baolin Wang > --- > drivers/rtc/rtc-sc27xx.c | 47 +++++++++++++++++++++++----------------------- > 1 file changed, 24 insertions(+), 23 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com