Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Stanislav Nijnikov <Stanislav.Nijnikov@wdc.com>
To:     Evan Green <evgreen@chromium.org>,
        Vinayak Holikatti <vinholikatti@gmail.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
CC:     Gwendal Grignou <gwendal@chromium.org>,
        Alex Lemberg <Alex.Lemberg@wdc.com>,
        Avri Altman <Avri.Altman@wdc.com>
Subject: RE: [PATCH 0/7] Enable UFS provisioning via Linux
Thread-Topic: [PATCH 0/7] Enable UFS provisioning via Linux
Thread-Index: AQHT93lpGmTFqrK/4k6nSxRetFdr1aRJmw1A
Date:   Thu, 31 May 2018 10:04:18 +0000
Message-ID: <MWHPR04MB11372C75BFC9416BAF5E81A19A630@MWHPR04MB1137.namprd04.prod.outlook.com>
References: <20180529181740.195362-1-evgreen@chromium.org>
In-Reply-To: <20180529181740.195362-1-evgreen@chromium.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c9aad1c2-5870-41dd-bac9-08d5c6dddfb2
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2018 10:04:18.4803
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0416
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Evan,
I have some generic notes:
- Why to create new sysfs entries for the configuration descriptor fields i=
f they are just duplication of fields in the device and unit descriptors? A=
nd the sysfs representation of the device and unit descriptors is existing =
already.
- It would be nice to have some "packet" mode allowing to gather configurat=
ion changes and apply them at once, not one by one.
- Why to put documentation update in the separate patches?

Regards
Stanislav

> -----Original Message-----
> From: Evan Green <evgreen@chromium.org>
> Sent: Tuesday, May 29, 2018 9:18 PM
> To: Vinayak Holikatti <vinholikatti@gmail.com>; James E.J. Bottomley <jej=
b@linux.vnet.ibm.com>; Martin K. Petersen
> <martin.petersen@oracle.com>; Stanislav Nijnikov <Stanislav.Nijnikov@wdc.=
com>; linux-kernel@vger.kernel.org; linux-
> scsi@vger.kernel.org
> Cc: Gwendal Grignou <gwendal@chromium.org>; Evan Green <evgreen@chromium.=
org>
> Subject: [PATCH 0/7] Enable UFS provisioning via Linux
>=20
> This series enables provisioning UFS devices using the existing sysfs
> interface. This functionality is primarily useful along the assembly
> line, but might also be useful for end users that receive devices that
> aren't locked down.
>=20
> Evan Green (7):
>   scsi: ufs: Add Configuration Descriptor to sysfs
>   scsi: ufs: Add config descriptor documentation
>   scsi: ufs: Make sysfs attributes writable
>   scsi: ufs: sysfs: Document attribute writability
>   scsi: ufs: Refactor descriptor read for write
>   scsi: ufs: Enable writing config descriptor
>   scsi: ufs: Update config descriptor documentation
>=20
>  Documentation/ABI/testing/sysfs-driver-ufs | 174 ++++++++++++++++++++---
>  drivers/scsi/ufs/ufs-sysfs.c               | 217 +++++++++++++++++++++++=
+++---
>  drivers/scsi/ufs/ufs.h                     |  29 ++++
>  drivers/scsi/ufs/ufshcd.c                  |  89 ++++++++----
>  drivers/scsi/ufs/ufshcd.h                  |  16 ++-
>  5 files changed, 458 insertions(+), 67 deletions(-)
>=20
> --
> 2.13.5