Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp520514imm; Thu, 31 May 2018 04:58:24 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIAMRrfjtWBJ95G5r9IzO3PWhq3JEB91HewJ6T8u8IUWg1omw/T/Aj9WTagh/snMcEuPmgz X-Received: by 2002:a62:18a:: with SMTP id 132-v6mr6541199pfb.62.1527767903975; Thu, 31 May 2018 04:58:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527767903; cv=none; d=google.com; s=arc-20160816; b=DIw407NXT+IT3m/GqnT5TBmtt77jfhVvjCc9mIy5BKgMys/agadYOveU1V2Aj7iJjk LzCmKafxlBs0mtO4ZisofJwrRyv7Js9893WySOmxSuRY+kM3Qe+ynakoTehAyPg8FLYp y48YXyzCDP88T6ltq/xM6akkuTjJBGcm71JrcDlRN+XEn3oVOgmG6vk5nohX+11P9JMK ZvQFpSFat9lGgBeEfg3vBsuxVv1aPftWmm86eTFfIukg1GGeTaYKTGtfbQaa6i0lw2qb J4hDtegqZPzFfAiYFJumM9Sg1Ixp1iN0KJHAK6h7XqcT5MnIGMwb1ni/s13njpx7xs9n pXmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=3aWdneXhWNMcClCKXNpr42hly+Lt8OmtNRVgDIgT86c=; b=rG2CzCY62KyDs7wgVupotWFli8tz9KCc1TUthkAHXbe3IAFL0caXfnMTo1obYVyoP5 dm8Wcvu1PWI/1rsqJHvlKAwdsEBEwuFSLbd9rd+lyVYDVYBWCASeUog+FzOo7MtPyL8Y svAw9X/Vn8d6Rq2J/w1/gL2zU37py1mdxz31zgrBkfGNitnvGm7tiliGnMfO4p2QWxTq /aXUc2Wj6b6YccfCZv5l1kzM0flkgYRshujETViPRbw5zY+EewO5VJh2I7MaUn7D2ZY4 qbE0Nn3+ZNyvYWa4mkKjL+LcjJf9fY0Wz05z5Xj/Uqf8v/SF1uwiy7DbXUzWqTiQla4B +xsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=O54B7IYZ; dkim=pass header.i=@codeaurora.org header.s=default header.b=as6/l9JA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z190-v6si14579069pgd.646.2018.05.31.04.58.09; Thu, 31 May 2018 04:58:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=O54B7IYZ; dkim=pass header.i=@codeaurora.org header.s=default header.b=as6/l9JA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754828AbeEaL4A (ORCPT + 99 others); Thu, 31 May 2018 07:56:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56812 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754221AbeEaLz6 (ORCPT ); Thu, 31 May 2018 07:55:58 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5805260646; Thu, 31 May 2018 11:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527767758; bh=JrIoHtSQp58ZmGdEbZqmjpM2YPny2LaoyzSsDZ45KC8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=O54B7IYZAlJqzggRRRrRIRg9ifb9cv6cQrRVtAyqpWDWkrX0G3O1JfIVNVhSjgfEr n9CllMCavuj4k6FcDhOJjuX8ji7FkHdWCHJKgt015z/FGanAez8YzWjst3gHu4xEIV Vfymz+5MI92UKXjIrtU39onmsO4m9qB0RHNX29mY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.1.125] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: timur@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7FCBD605FF; Thu, 31 May 2018 11:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527767757; bh=JrIoHtSQp58ZmGdEbZqmjpM2YPny2LaoyzSsDZ45KC8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=as6/l9JAjsL6rOn6idOelE1qiqqcDcgPUxDHSH7+wJyiMacZlLDsZnwAfo/82jl9s 3o6f3xwHjh+dmnuaD0TBLLWHCIS19XLnAG3nUmziIldlFgw2XtuSVPO+V3HcOvl9t2 tgr7JXQ17jM7rmRnyDpIuix6v6RlpkqFTrElYhtI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7FCBD605FF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering To: Sebastian Gottschall , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bjorn Andersson , Linus Walleij , Sasha Levin References: <20180528100240.256525891@linuxfoundation.org> <20180528100302.722883806@linuxfoundation.org> <7c34ccef-2fa8-8b53-2677-29f6fbe71a04@dd-wrt.com> <20180531114553.GB11598@kroah.com> From: Timur Tabi Message-ID: <510e5f2c-718a-de42-8274-9345d13e7797@codeaurora.org> Date: Thu, 31 May 2018 06:55:55 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/18 6:53 AM, Sebastian Gottschall wrote: >> > i checked initially 4.9 with latest patches and 4.14 and reverted this > line to get back to the old behaviour but a which view in the current > 4.17 tree shows > that the same patch has been included in 4.17. it was introduced in the > kernel mainline on 12.feb 2018 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/qcom/pinctrl-msm.c?h=v4.17-rc7&id=a7aa75a2a7dba32594291a71c3704000a2fd7089 I believe that this patch should not be applied to *any* stable kernel. It completely breaks legacy GPIO numbering, and it does so intentionally. That may be okay for future kernels, but IMHO it's wrong for older kernels. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.