Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp671141imm; Thu, 31 May 2018 07:27:25 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIK20YZS3aflhl/m+LDrxFzbItCYqm88PjSRwz5ulLoO/31KeisWWth16SVlSDPPvzgP60H X-Received: by 2002:a65:6491:: with SMTP id e17-v6mr1139129pgv.44.1527776844967; Thu, 31 May 2018 07:27:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527776844; cv=none; d=google.com; s=arc-20160816; b=UQXo+vLpZbH+iYBvY4aDI6mndcQAcOJeMQGN6N5uuWAqws4UinWwsDMfoJQV35Ssvr K9AbhMb7IPxBR324QMn+qJPXgiIiou7K+r0c3OyPWkd/jKVaY6vHibnZ/+yfVMMokmhK RYfae+loESjFwMAXIIdeWGuVWKgo92D9dvxSt327JBwVcguwujXpTW9L/S816J4mx3p3 PeoI/Zk2vHqkUPQlQveSAzaZWsJU6iQ9P1mIvVfrKdDXSiifq2usTSJV+xvcsFoTbItJ 5qzv+VmowkkJm5e6Rt+WdeBy0PhHnWN46ijMo4Ppq82dujGB0d5CEwfS7XaztAxyES7w +fAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=8I48YqP1nic+dPb9wiXcZ4dC6Qgwla54zRYuOMmmWHA=; b=r8LrfeltyZozeKpjC7w+Oz4H+fJKVPhQfErDdit00OzhdfXSJvpJQByYosIYFdvkMS 5CyXNdKdiKoKR3+52bF/y8c6Vl9hvc/jIVcEYciMTs3m9MuqhLGyKbJL4w5QYp7jNo10 pwuEeyVaaNqi4e74g8rVlJoTUucvpwNuinsHCnOUPj1smFL0tvMDLKmxx63qNenp7Wlj AeB139rlPVEEOeMRwTi6zE4jJR+qlC1OmvgDkj7PnUHsqDAkevak5gvrT/CTWnMrGcRC g290W34JTCueY6PQcE/48I2HdkhIc/ogMrXwPyg7KI3C1EjfHZn3lr/MKekFfnyk7aZH LSfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f20-v6si14351590pgn.464.2018.05.31.07.27.10; Thu, 31 May 2018 07:27:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755450AbeEaO01 (ORCPT + 99 others); Thu, 31 May 2018 10:26:27 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:42440 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755356AbeEaO0Z (ORCPT ); Thu, 31 May 2018 10:26:25 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4VEOTLN068333 for ; Thu, 31 May 2018 10:26:25 -0400 Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx0a-001b2d01.pphosted.com with ESMTP id 2jahdf4g6v-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 31 May 2018 10:26:25 -0400 Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 31 May 2018 08:26:24 -0600 Received: from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 31 May 2018 08:26:20 -0600 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4VEP45a6226332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 31 May 2018 07:25:04 -0700 Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C698D78057; Thu, 31 May 2018 08:25:04 -0600 (MDT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id 5129A78037; Thu, 31 May 2018 08:25:04 -0600 (MDT) From: Stefan Berger To: zohar@linux.vnet.ibm.com, paul@paul-moore.com, linux-integrity@vger.kernel.org, linux-audit@redhat.com Cc: sgrubb@redhat.com, linux-kernel@vger.kernel.org, Stefan Berger Subject: [PATCH v2 1/4] ima: Call audit_log_string() rather than logging it untrusted Date: Thu, 31 May 2018 10:24:57 -0400 X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180531142500.4193818-1-stefanb@linux.vnet.ibm.com> References: <20180531142500.4193818-1-stefanb@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18053114-8235-0000-0000-00000D9F2AED X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009102; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000264; SDB=6.01040334; UDB=6.00532532; IPR=6.00819463; MB=3.00021393; MTD=3.00000008; XFM=3.00000015; UTC=2018-05-31 14:26:22 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18053114-8236-0000-0000-00004143DFB2 Message-Id: <20180531142500.4193818-2-stefanb@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-31_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1805310163 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The parameters passed to this logging function are all provided by a privileged user and therefore we can call audit_log_string() rather than audit_log_untrustedstring(). Signed-off-by: Stefan Berger Suggested-by: Steve Grubb Acked-by: Paul Moore --- security/integrity/ima/ima_policy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c index 8bbc18eb07eb..1d00db19d167 100644 --- a/security/integrity/ima/ima_policy.c +++ b/security/integrity/ima/ima_policy.c @@ -634,7 +634,7 @@ static void ima_log_string_op(struct audit_buffer *ab, char *key, char *value, audit_log_format(ab, "%s<", key); else audit_log_format(ab, "%s=", key); - audit_log_untrustedstring(ab, value); + audit_log_string(ab, value); audit_log_format(ab, " "); } static void ima_log_string(struct audit_buffer *ab, char *key, char *value) -- 2.13.6