Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp676305imm; Thu, 31 May 2018 07:32:20 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKhi6Dg5atNRn3YaGaKyyQiHMzSUcpjCS7sUYYFsLyCcXbxilzr7O4reLahYL0Tkat1h715 X-Received: by 2002:aa7:81cc:: with SMTP id c12-v6mr7109780pfn.169.1527777140114; Thu, 31 May 2018 07:32:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527777140; cv=none; d=google.com; s=arc-20160816; b=jhSeoY82D+uiTpPdD7OYo9RA6yQ/YeJWH3iHPFXzHlPQnNwXWO47QUUC6cFKX/8d78 JT0rHrpOLWQ2O8LKh1u3/+9udascXVVEHkkgbuQSJdmP5nMagXfeEqjfPzneznZZz++j 0Ex/x/VK3FR6jS7B1DRoHvs32v2ikX7PdimhsQ1uvUCpHpbMibevpR8aifvI+ucukkt9 PM9iu8aA0AQi0SjNwo9LLyf2ZbVt+2CkEFDy5hFuZhoxYFIR85uJxn1GIPURCoPtQmM4 H2ksZvrSLJZg59jNqYiggk1x8CoTiYnBhVMZbILqhO349bIh3MBvRua7oduuuLBJf8UC TVsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:mime-version:user-agent :references:message-id:in-reply-to:subject:cc:to:from:date :dkim-signature:arc-authentication-results; bh=RoDDj5SXtfTRkM82binxG38InFGuQyJMZ5fTVGdutzM=; b=UGREZNb83lfUjAJEgpr0yRPZKPWoNN9UsB+ty+HrT+5xxWxTbvlO5464MJT3hvlEb7 skeJLAZZkHLnwWatyBmbu/lNaia4UerQnpJpnNt0fNho9jLmuJY3t0R7yB/3A2avhK8W trAbA/wonCunXIssRqIf8nkX9WNT1wjL6Iqfz5q41hNUv8OhVqhk1/URVvxZlaneDLUm 2qFQnJbyZ13J3i4rmV9dUWR8wW0Uo6K+Kj8d3Cb4Zg3tqO1xM2dGywwNFQ5MWIdOcHd6 pzTkugBk+nxCPSBbHeUtpCqRG6UnzyOMiDuIKNthYKc6aAiS5RjBKgo8pN8119BQ5QBm +HiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazonses.com header.s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug header.b=KHgocvwk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3-v6si2245454pgc.645.2018.05.31.07.32.05; Thu, 31 May 2018 07:32:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazonses.com header.s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug header.b=KHgocvwk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755380AbeEaOae (ORCPT + 99 others); Thu, 31 May 2018 10:30:34 -0400 Received: from a9-99.smtp-out.amazonses.com ([54.240.9.99]:40694 "EHLO a9-99.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755291AbeEaOaa (ORCPT ); Thu, 31 May 2018 10:30:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug; d=amazonses.com; t=1527777029; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:MIME-Version:Content-Type:Feedback-ID; bh=8Bu6yV/PyXIYhk2lHzgWiVQNaFqwI7pOGbvgR1/VlUo=; b=KHgocvwk3WtzA7Elk48Ffbp9NO9HhLn/jSOqxgOEZHBtdHbU8l8oc9d8IFdArTOZ uOBVMa8b67QmJxmLh5Q5+R8duiO6bI+fQyQ9MO4E+OfS85BEB3rMtFgHG3cJyTLnvoh S3vECsFUj/BkylQI8Z1dv0Yn09c5JXugq5aHJQq0= Date: Thu, 31 May 2018 14:30:29 +0000 From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Matthew Wilcox cc: Jia-Ju Bai , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, Linux Kernel Mailing List Subject: Re: Can kfree() sleep at runtime? In-Reply-To: <20180531141452.GC30221@bombadil.infradead.org> Message-ID: <01000163b69b6b62-6c5ac940-d6c1-419a-9dc9-697908020c53-000000@email.amazonses.com> References: <30ecafd7-ed61-907b-f924-77fc37dcc753@gmail.com> <20180531140808.GA30221@bombadil.infradead.org> <01000163b68a8026-56fb6a35-040b-4af9-8b73-eb3b4a41c595-000000@email.amazonses.com> <20180531141452.GC30221@bombadil.infradead.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SES-Outgoing: 2018.05.31-54.240.9.99 Feedback-ID: 1.us-east-1.fQZZZ0Xtj2+TD7V5apTT/NrT6QKuPgzCT/IC7XYgDKI=:AmazonSES Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 May 2018, Matthew Wilcox wrote: > > Freeing a page in the page allocator also was traditionally not sleeping. > > That has changed? > > No. "Your bug" being "The bug in your static analysis tool". It probably > isn't following the data flow correctly (or deeply enough). Well ok this is not going to trigger for kfree(), this is x86 specific and requires CONFIG_DEBUG_PAGEALLOC and a free of a page in a huge page. Ok that is a very contorted situation but how would a static checker deal with that?