Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 31 May 2018 17:47:49 +0300
From:   Yury Norov <ynorov@caviumnetworks.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] bitmap: Drop unnecessary 0 check for u32 array
 operations
Message-ID: <20180531144749.GA6828@yury-thinkpad>
References: <20180531131914.44352-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180531131914.44352-1-andriy.shevchenko@linux.intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2018 14:48:06.2447 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 803261f1-a415-4892-bb01-08d5c7058587
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4374
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 31, 2018 at 04:19:14PM +0300, Andy Shevchenko wrote:
> The nbits == 0 is safe to be supplied to the function body, so,
> remove unnecessary checks in bitmap_to_arr32() and bitmap_from_arr32().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Indeed. Thanks for the catch.

> ---
>  lib/bitmap.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/lib/bitmap.c b/lib/bitmap.c
> index 58f9750e49c6..33e95cd359a2 100644
> --- a/lib/bitmap.c
> +++ b/lib/bitmap.c
> @@ -1132,14 +1132,10 @@ EXPORT_SYMBOL(bitmap_copy_le);
>   *	@buf: array of u32 (in host byte order), the source bitmap
>   *	@nbits: number of bits in @bitmap
>   */
> -void bitmap_from_arr32(unsigned long *bitmap, const u32 *buf,
> -						unsigned int nbits)
> +void bitmap_from_arr32(unsigned long *bitmap, const u32 *buf, unsigned int nbits)

This line is 81 characters length, and it will trigger checkpatch warning.
(But I'm OK with it.)

>  {
>  	unsigned int i, halfwords;
>  
> -	if (!nbits)
> -		return;
> -
>  	halfwords = DIV_ROUND_UP(nbits, 32);
>  	for (i = 0; i < halfwords; i++) {
>  		bitmap[i/2] = (unsigned long) buf[i];
> @@ -1163,9 +1159,6 @@ void bitmap_to_arr32(u32 *buf, const unsigned long *bitmap, unsigned int nbits)
>  {
>  	unsigned int i, halfwords;
>  
> -	if (!nbits)
> -		return;
> -
>  	halfwords = DIV_ROUND_UP(nbits, 32);
>  	for (i = 0; i < halfwords; i++) {
>  		buf[i] = (u32) (bitmap[i/2] & UINT_MAX);
> -- 
> 2.17.0

Acked-by: Yury Norov <ynorov@caviumnetworks.com>